diff mbox series

[committed] testsuite: Fix gcc.target/i386/pr103895.c testcase [PR103895]

Message ID 20220105090525.GO2646553@tucnak
State New
Headers show
Series [committed] testsuite: Fix gcc.target/i386/pr103895.c testcase [PR103895] | expand

Commit Message

Jakub Jelinek Jan. 5, 2022, 9:05 a.m. UTC 
Hi!

The testcase uses SSE and SSE2 intrinsics, so fails on i686-linux
if -msse2 isn't enabled by default.  Fixed by adding -msse2 to
dg-options.

Bootstrapped/regtested on x86_64-linux and i686-linux, committed to
trunk as obvious.

2022-01-05  Jakub Jelinek  <jakub@redhat.com>

	PR target/103895
	* gcc.target/i386/pr103895.c: Add -msse2 to dg-options.


	Jakub

Comments

Andreas Schwab Jan. 5, 2022, 9:16 a.m. UTC | #1 
On Jan 05 2022, Jakub Jelinek via Gcc-patches wrote:

> The testcase uses SSE and SSE2 intrinsics, so fails on i686-linux
> if -msse2 isn't enabled by default.  Fixed by adding -msse2 to
> dg-options.

Shouldn't that use { dg-require-effective-target sse2 }?
Jakub Jelinek Jan. 5, 2022, 9:20 a.m. UTC | #2 
On Wed, Jan 05, 2022 at 10:16:30AM +0100, Andreas Schwab wrote:
> On Jan 05 2022, Jakub Jelinek via Gcc-patches wrote:
> 
> > The testcase uses SSE and SSE2 intrinsics, so fails on i686-linux
> > if -msse2 isn't enabled by default.  Fixed by adding -msse2 to
> > dg-options.
> 
> Shouldn't that use { dg-require-effective-target sse2 }?

Not necessarily, it is a dg-do compile test, so it doesn't care
if assembler can assemble sse2 instructions or not.

	Jakub
diff mbox series

Patch

--- gcc/testsuite/gcc.target/i386/pr103895.c.jj	2022-01-04 23:11:22.788586688 +0100
+++ gcc/testsuite/gcc.target/i386/pr103895.c	2022-01-05 01:30:33.926589366 +0100
@@ -1,5 +1,5 @@ 
 /* { dg-do compile } */
-/* { dg-options "-Og -ffloat-store" } */
+/* { dg-options "-Og -ffloat-store -msse2" } */
 
 #include <emmintrin.h>
 typedef float vFloat __attribute__((__vector_size__(16)));