From patchwork Mon Dec 6 21:04:36 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Jose E. Marchesi" X-Patchwork-Id: 1564232 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.a=rsa-sha256 header.s=default header.b=ekpVKeDf; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=2620:52:3:1:0:246e:9693:128c; helo=sourceware.org; envelope-from=gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=) Received: from sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4J7GDM4LXCz9s5P for ; Tue, 7 Dec 2021 08:05:38 +1100 (AEDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id BEE35385841C for ; Mon, 6 Dec 2021 21:05:35 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org BEE35385841C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1638824735; bh=/qKEwIbc9iblDMFmUkchG4eQ0/Bq/4fMPjDQEbWJUqM=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=ekpVKeDfuEyx+XgO8lhgDg5cg/wmnnd7rgFXcdd+ZyCcoE6I0+IIPyLsBrNyk8h0o BoZrc+08EXMgXLf3uyurb9aR8a9s8JpNqhza1//CmSHAUQrbccEbbiV/kEJKQp9ljv PAZExIW5BIOaSnrRiPp2bh0D7TGVwp+KDNEvLArc= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by sourceware.org (Postfix) with ESMTPS id D0FBB3858D28 for ; Mon, 6 Dec 2021 21:04:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D0FBB3858D28 Received: from pps.filterd (m0246617.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 1B6JbZ5K030929 for ; Mon, 6 Dec 2021 21:04:49 GMT Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by mx0b-00069f02.pphosted.com with ESMTP id 3cscwcbnbk-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Mon, 06 Dec 2021 21:04:48 +0000 Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.1.2/8.16.1.2) with SMTP id 1B6L0d58140027 for ; Mon, 6 Dec 2021 21:04:47 GMT Received: from nam12-mw2-obe.outbound.protection.outlook.com (mail-mw2nam12lp2045.outbound.protection.outlook.com [104.47.66.45]) by userp3020.oracle.com with ESMTP id 3cr1smqq4j-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Mon, 06 Dec 2021 21:04:47 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bQe3yCOg6OwHr5CvkICemDr2hHqdpU0ZaPcGQ1GozTOD8lvvzFforX6+xDIkU2n+P1jkDcmBtVO3L25xft4pTDnE8LJuFo+FZwJFBifLozExBapyEt5SCoEAnU8fce/n6cKAmkuFMbWR2PI6tY8etqbkQa7Aqvtav2unSyf0uu9fVbtNkNx1EtjlDHi085vVVZVel5UlMulNgtHT6SMuH+ai4w34Ub2rsyqfXChgYtNVpCqJcomOCRT6UsS7BeNF25RZUtIc+1qlIbTFq6AiEoYs8bYMyvG1HY04bLg6Pi6e4+9eiNFvHEiZ7S7vEwkMXfrx68yQqVdxhk/V4Ky9MA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/qKEwIbc9iblDMFmUkchG4eQ0/Bq/4fMPjDQEbWJUqM=; b=UztdNj9HrQO3tfeza7s9XhzYjdUWZYxGK+egq2sb+B03bIrVC46xVG7kOUso9kpwa0/2jw0wzpnEQPD2XRazr71duFIQlHcc72wObUqtiIIMO51DbZeB+hqreL5PjWkkY0rsq74MirrxKFvYAYYXXcmfJiir68hD5jnWFOwPQGhgTyionR+FjOlPcnPWokGE0owdUds4RvVD5L4H58krnXh9M7KzpQj95gfBQpfwDKioVw3chO+pmDPXdahUF//Rh1684gO5hYpb3RtPIWORS/M+oppzesNMG4q6PplPBneID+kY+HESGu0pzzMG2DZ5jheBjaUSr9SJBn3esm+HAQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none Received: from BYAPR10MB2888.namprd10.prod.outlook.com (2603:10b6:a03:88::32) by BYAPR10MB3014.namprd10.prod.outlook.com (2603:10b6:a03:87::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.21; Mon, 6 Dec 2021 21:04:44 +0000 Received: from BYAPR10MB2888.namprd10.prod.outlook.com ([fe80::8966:789e:5a45:942]) by BYAPR10MB2888.namprd10.prod.outlook.com ([fe80::8966:789e:5a45:942%6]) with mapi id 15.20.4755.021; Mon, 6 Dec 2021 21:04:44 +0000 To: gcc-patches@gcc.gnu.org Subject: [COMMITTED] bpf: mark/remove unused arguments and remove an unused function Date: Mon, 6 Dec 2021 22:04:36 +0100 Message-Id: <20211206210436.14396-1-jose.marchesi@oracle.com> X-Mailer: git-send-email 2.11.0 X-ClientProxiedBy: AM7PR04CA0018.eurprd04.prod.outlook.com (2603:10a6:20b:110::28) To BYAPR10MB2888.namprd10.prod.outlook.com (2603:10b6:a03:88::32) MIME-Version: 1.0 Received: from termi.localdomain (141.143.193.68) by AM7PR04CA0018.eurprd04.prod.outlook.com (2603:10a6:20b:110::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.16 via Frontend Transport; Mon, 6 Dec 2021 21:04:43 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: fe3a0ac6-3569-486a-369d-08d9b8fc075c X-MS-TrafficTypeDiagnostic: BYAPR10MB3014:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7691; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: /1sXcIwM71lFzgniMRPSwRWRAlU2i+bydjzk5QlAQsc+Z/BSGyx5OZK844+BRSK4bRGF4Q8hdMD3LMdGyk0391XsDoCanNnCLklkpNw8rp3yl3Ngr3CvCdVZTR3d3fhZw4yExrhVeCs6XEng0299gVwaXXNAlMpzL1yLh9lQagUPHZ0AuEIWJPTQfYp1SQD+q1uPOlPxAShSHcH9QSgbd1EGwBXVVByHbwkStMgDloiRCQWMsTfgV+Bafp3DzZTuVlCk4BhhQjrW5SVwivxZaAwWj1o3ak4UIbBZR5BDvGUVRGfB16QnK8SnMYgUYTQDrebADtBDuqj2iSkil9iRKlWpTU3NpDQ8kMtzJ5h0PDCD92n+GxH5vAz6nr7x1FcvQCT95hrGSvKdaFmoKvureEOMvv5WihDu9rM5NJ1W1VZz9+2NabCx6sj/xmr98x27I/VgIdPHLO/QvLMMP0apUZpqzixVWy4DiYG374pWANtcD1um4hkkISxVQkguvKWGES7HbRXVNq0WOw6OI+tWzoG3TZXG9cVarA+GMPFoO85FVkkp1s++wScbeNtIAZnvkWkDEsLa97EMGDTJ086NyyKGXdsoTrErIY+piCxEWbZgW5G0biFnl59BRoJ2GI/DE2O/bQYtOFUvV7Rd3c3JvPe2DZxfz1KLsm22N7zwXJxix/Fi2hFnEFbtZKWUmOGw1FM2NXPu9aHqbic2knSsuw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR10MB2888.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(83380400001)(956004)(6666004)(6506007)(2906002)(26005)(38350700002)(6512007)(8676002)(2616005)(186003)(38100700002)(508600001)(66946007)(52116002)(86362001)(316002)(5660300002)(66556008)(36756003)(6486002)(8936002)(6916009)(66476007)(1076003); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: w5t9jjXxFAtI13gpRErb8qNOWv8txxwNxQPH4eYoT4MdUeu3NnwpihYdj/ZQK2iAiqpCElalyQe55P2yDhmRfP3FFu5rE/TgW7dhZKIHYNVtYgi1tGq0St7VIQ7hBGrXGdcFqwwxL7pz1gCHM5qxFmVdpXfe9mUHSLDH6gV9qMo3+zX0FKB9shmCkBsKoo7LNtlc+mSOl41VSJuq8MIv13Ihus2F1qH6PlEj2uoGg5ZoEHyU+4Tr3MdIZpqdnKTiz62H01AhS6cG87BYB2/I6Hvv4FX+zP80QfpbAsLB1Iv0iETnMCvsdQsflOY8wyrIm5gUM534i4ZeHrJPwBNLltGJJfvl8ESuxzz9q7Tg7FcT9s2L+EPhKu7KJkVMuytUnu1DzbsSIsNkLJrv0lKw5n7HDk+g0FFU4a64SoZiBkUgBFDBmNCPderV1z/mLen31Idv0liBhorADkiErQCHZyyTZVnV85FD2MNoM3i88/regsl7+2VbZ4hc4ODggW/ZyUmsSnSMK6hgJn4lwFwBRvlNrvbmNTDxc8zZa5ksuUCjgrDz4QPV2h2lNIDH9dcH7ZC21f1U8vPcbSAKGLBeP0MBdC0b0D047c2f2TlrOVl9kKXfMq2ocWht2O0x05vk6jgh0xKICIEwWMptvKN0WjB+QuzrMZNEgQoj2KB0oSMr3J9ebLbi6Hzk3bocAxivgsCKL6E80RH/pSlp7+GfnJl8VsLyUKZDHUU1w6A183G3ZcP8BlsXgaEXM82ewEs1Bpk6mwvE4PMX8am67s3+BVaVdyCB641prb2ArZ//DPTSysR1QHTnxuvdzzCp19ihOzgabLDirtIhgv4PlBYuBeZYfHDGiCcToVxmHFvJ6nF802t8HdkEt79OZfeY2PQPGdM97ZW1RkKdh0F+Ps/uTZPK62gIeRAx3w1Gb+NUVawRFa7K3FYedv1aAj2LkL5JG/RShP8LXaXX8vm966wDNvaBqLNA3mATYkS6jAalg6rP1y/zZ7KoT+7IXj48FWh2OZhl507nlItRtO4y2QJf1UFrMpNN60NgXJ1e9wLvjSyGDdmPKFCtPeZwccdJJ/42/o7tMjWLgf6tVE4+QcffZkycZ0O6mkadTNnvcoONDMVjC2+6hyIucHrdQFS1zCD9ykMsCg34a9lTkKVcuGdTracNlOjVoCTj/OrHI4XcNGVRHd4hHmW/cVBV+hWY8Rf3MyMoGdDlLs5h/Ngt6phkxE5QzUhrXanFfJ1IlAiYK95nMOvQNHeZOEUb5d6fzOrZmdN0cYCNrJyLpL1Ltud+HBlqHeYLDuM2foPY4TR7+SSS0gMQWo2tY0vO7X0M+1KfGBK6kGCUEFudP9+zeb2yoVbzXANSeuvocQmG3nwYMVqVacmwmhj3ooeoIy0itFfawVQHWlWVGK4c//2fbsZdaCrFqdewWDdyRBHxQsaBxkeK6KdPJ5HPs6mhmN/Nw2i4kNZKysul1H/cZZfaONdOqjDsawsOcZUSWqe8wPb/UVaKTKyu7c8DwtsCyWgHAsT30RdQtN+vacTBuhGQkjPPLdiXMH9Lpsp6HP6Qp8IrgHwVRFVcC/r1Azq1X+D5fHfR3Gfy9v/r7xJ7sGDHRu+YfTkvOLHG00mMdpcr9qa9tMsdJspdqtphFXpdimAkrgTUHEjN6/0JLtqVvkrbqycFYoF1lScqZzBtY3r39mFclzs= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: fe3a0ac6-3569-486a-369d-08d9b8fc075c X-MS-Exchange-CrossTenant-AuthSource: BYAPR10MB2888.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Dec 2021 21:04:44.7357 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: hHt4Nv9WqaMu+/LZLY6pTT/y57Eg9YB9yD0Cwsa8qGXMz8Wc5dZlwrnnNO8ud9tU81yQDh2Wik0btUq9kxCYBmOC5ERGcYCG1HmRAW1SjQo= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR10MB3014 X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10190 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 mlxscore=0 spamscore=0 phishscore=0 bulkscore=0 suspectscore=0 malwarescore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000 definitions=main-2112060128 X-Proofpoint-ORIG-GUID: nPULmh7VdgHhL_gGBtwmjKJTUSvaF8qW X-Proofpoint-GUID: nPULmh7VdgHhL_gGBtwmjKJTUSvaF8qW X-Spam-Status: No, score=-12.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, MSGID_FROM_MTA_HEADER, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: "Jose E. Marchesi via Gcc-patches" From: "Jose E. Marchesi" Reply-To: "Jose E. Marchesi" Errors-To: gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org Sender: "Gcc-patches" This patch does a little bit of cleanup by removing some unused arguments, or marking them as unused. It also removes the function ctfc_debuginfo_early_finish_p and the corresponding hook macro definition, which are not used by GCC. gcc/ * config/bpf/bpf.c (bpf_handle_preserve_access_index_attribute): Mark arguments `args' and flags' as unused. (bpf_core_newdecl): Remove unused local `newdecl'. (bpf_core_newdecl): Remove unused argument `loc'. (ctfc_debuginfo_early_finish_p): Remove unused function. (TARGET_CTFC_DEBUGINFO_EARLY_FINISH_P): Remove definition. (bpf_core_walk): Do not pass a location to bpf_core_newdecl. --- gcc/config/bpf/bpf.c | 25 +++++-------------------- 1 file changed, 5 insertions(+), 20 deletions(-) diff --git a/gcc/config/bpf/bpf.c b/gcc/config/bpf/bpf.c index 82bb698bd91..9d2c0bb6818 100644 --- a/gcc/config/bpf/bpf.c +++ b/gcc/config/bpf/bpf.c @@ -129,8 +129,8 @@ bpf_handle_fndecl_attribute (tree *node, tree name, static tree bpf_handle_preserve_access_index_attribute (tree *node, tree name, - tree args, - int flags, + tree args ATTRIBUTE_UNUSED, + int flags ATTRIBUTE_UNUSED, bool *no_add_attrs) { if (TREE_CODE (*node) != RECORD_TYPE && TREE_CODE (*node) != UNION_TYPE) @@ -258,20 +258,6 @@ bpf_option_override (void) #undef TARGET_OPTION_OVERRIDE #define TARGET_OPTION_OVERRIDE bpf_option_override -/* Return FALSE iff -mcore has been specified. */ - -static bool -ctfc_debuginfo_early_finish_p (void) -{ - if (TARGET_BPF_CORE) - return false; - else - return true; -} - -#undef TARGET_CTFC_DEBUGINFO_EARLY_FINISH_P -#define TARGET_CTFC_DEBUGINFO_EARLY_FINISH_P ctfc_debuginfo_early_finish_p - /* Implement TARGET_ASM_INIT_SECTIONS. */ static void @@ -1266,15 +1252,14 @@ bpf_core_get_index (const tree node) return -1; } -/* Synthesize a new builtin function declaration at LOC with signature TYPE. +/* Synthesize a new builtin function declaration with signature TYPE. Used by bpf_resolve_overloaded_builtin to resolve calls to __builtin_preserve_access_index. */ static tree -bpf_core_newdecl (location_t loc, tree type) +bpf_core_newdecl (tree type) { tree rettype = build_function_type_list (type, type, NULL); - tree newdecl = NULL_TREE; char name[80]; int len = snprintf (name, sizeof (name), "%s", "__builtin_pai_"); @@ -1317,7 +1302,7 @@ bpf_core_walk (tree *tp, int *walk_subtrees, void *data) if (bpf_core_is_maybe_aggregate_access (*tp)) { - tree newdecl = bpf_core_newdecl (loc, TREE_TYPE (*tp)); + tree newdecl = bpf_core_newdecl (TREE_TYPE (*tp)); tree newcall = build_call_expr_loc (loc, newdecl, 1, *tp); *tp = newcall; *walk_subtrees = 0;