diff mbox series

[v2] powerpc: Remove LINK_OS_EXTRA_SPEC{32, 64} from --with-advance-toolchain

Message ID 20211110142126.2435206-1-lamm@linux.ibm.com
State New
Headers show
Series [v2] powerpc: Remove LINK_OS_EXTRA_SPEC{32, 64} from --with-advance-toolchain | expand

Commit Message

Lucas A. M. Magalhaes Nov. 10, 2021, 2:21 p.m. UTC 
Historically this was added to fill gaps from ld.so.cache on early AT
releases. This now are just causing errors and rework. Since AT5.0 the
AT's ld.so is using a correctly configured ld.so.cache and sets the
DT_INTERP to AT's ld.so. This two factors are sufficient for an AT
builded program to get the correct libraries.

GCC congured with --with-advance-toolchain has issues building GlibC
releases because it adds DT_RUNPATH to ld.so and that's unsupported.

2021-11-10  Lucas A. M. Magalhães  <lamm@linux.ibm.com>

gcc/
	* config.gcc (powerpc*-*-*): Remove -rpath from
	--with-advance-toochain
---
 gcc/config.gcc | 10 ----------
 1 file changed, 10 deletions(-)

Comments

Segher Boessenkool Nov. 10, 2021, 2:37 p.m. UTC | #1 
On Wed, Nov 10, 2021 at 11:21:26AM -0300, Lucas A. M. Magalhaes wrote:
> Historically this was added to fill gaps from ld.so.cache on early AT
> releases. This now are just causing errors and rework. Since AT5.0 the
> AT's ld.so is using a correctly configured ld.so.cache and sets the
> DT_INTERP to AT's ld.so. This two factors are sufficient for an AT
> builded program to get the correct libraries.
> 
> GCC congured with --with-advance-toolchain has issues building GlibC
> releases because it adds DT_RUNPATH to ld.so and that's unsupported.
> 
> 2021-11-10  Lucas A. M. Magalhães  <lamm@linux.ibm.com>
> 
> gcc/
> 	* config.gcc (powerpc*-*-*): Remove -rpath from
> 	--with-advance-toochain

I fixed the title and this last line, and pushed it to trunk.  Thanks!


Segher
diff mbox series

Patch

diff --git a/gcc/config.gcc b/gcc/config.gcc
index fb1f06f3da8..9eba3ece0a9 100644
--- a/gcc/config.gcc
+++ b/gcc/config.gcc
@@ -5088,16 +5088,6 @@  case "${target}" in
 			(at="/opt/$with_advance_toolchain"
 			 echo "/* Use Advance Toolchain $at */"
 			 echo
-			 echo "#undef  LINK_OS_EXTRA_SPEC32"
-			 echo "#define LINK_OS_EXTRA_SPEC32" \
-			      "\"%(link_os_new_dtags)" \
-			      "-rpath $prefix/lib -rpath $at/lib\""
-			 echo
-			 echo "#undef  LINK_OS_EXTRA_SPEC64"
-			 echo "#define LINK_OS_EXTRA_SPEC64" \
-			      "\"%(link_os_new_dtags)" \
-			      "-rpath $prefix/lib64 -rpath $at/lib64\""
-			 echo
 			 echo "#undef  LINK_OS_NEW_DTAGS_SPEC"
 			 echo "#define LINK_OS_NEW_DTAGS_SPEC" \
 			      "\"--enable-new-dtags\""