Message ID | 20211004093126.GK304296@tucnak |
---|---|
State | New |
Headers | show |
Series | var-tracking: Fix a wrong-debug issue caused by my r10-7665 var-tracking change [PR102441] | expand |
Hello, Jakub, On Oct 4, 2021, Jakub Jelinek <jakub@redhat.com> wrote: > Finally, patch2, the shortest patch, uses MO_VAL_SET whenever destination > is not sp and otherwise drops the micro-operation on the floor. That sounds quite reasonable to me, and it is indeed my favorite of the 3 proposed patches, because the mapping of locations to values is kept most accurate. Thanks!
On October 9, 2021 5:26:17 AM GMT+02:00, Alexandre Oliva <oliva@adacore.com> wrote: >Hello, Jakub, > >On Oct 4, 2021, Jakub Jelinek <jakub@redhat.com> wrote: > >> Finally, patch2, the shortest patch, uses MO_VAL_SET whenever destination >> is not sp and otherwise drops the micro-operation on the floor. > >That sounds quite reasonable to me, and it is indeed my favorite of the >3 proposed patches, because the mapping of locations to values is kept >most accurate. What I thought as well. Thus, OK. Richard. >Thanks! >
--- gcc/var-tracking.c.jj 2021-05-04 21:02:24.196799586 +0200 +++ gcc/var-tracking.c 2021-09-24 19:23:16.420154828 +0200 @@ -6133,7 +6133,9 @@ add_stores (rtx loc, const_rtx expr, voi { if (preserve) preserve_value (v); - return; + mo.type = MO_CLOBBER; + mo.u.loc = loc; + goto log_and_return; } nloc = replace_expr_with_values (oloc);