| Message ID | 20210827035658.58286-1-yunqiang.su@cipunited.com |
|---|---|
| State | New |
| Headers | show |
| Series | MIPS: use N64 ABI by default if the triple end with -gnuabi64 | expand |
On Thu, 2021-08-26 at 23:56 -0400, YunQiang Su wrote: > gcc/ChangeLog: > > PR target/102089 > * config.gcc: MIPS: use N64 ABI by default if the triple end > with -gnuabi64, which is used by Debian since 2013. > --- > gcc/config.gcc | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > > diff --git a/gcc/config.gcc b/gcc/config.gcc > index 0ff5cac15..0c91be6f3 100644 > --- a/gcc/config.gcc > +++ b/gcc/config.gcc > @@ -2553,16 +2553,30 @@ mips*-*-linux*) # Linux MIPS, either endian. > target_cpu_default=MASK_SOFT_FLOAT_ABI > enable_mips_multilibs="yes" > ;; > + mipsisa64r6*-*-linux-gnuabi64) > + default_mips_abi=64 > + default_mips_arch=mips64r6 > + enable_mips_multilibs="yes" > + ;; > mipsisa64r6*-*-linux*) > default_mips_abi=n32 > default_mips_arch=mips64r6 > enable_mips_multilibs="yes" > ;; > + mipsisa64r2*-*-linux-gnuabi64) > + default_mips_abi=64 > + default_mips_arch=mips64r2 > + enable_mips_multilibs="yes" > + ;; > mipsisa64r2*-*-linux*) > default_mips_abi=n32 > default_mips_arch=mips64r2 > enable_mips_multilibs="yes" > ;; > + mips64*-*-linux-gnuabi64 | mipsisa64*-*-linux-gnuabi64) > + default_mips_abi=64 > + enable_mips_multilibs="yes" > + ;; > mips64*-*-linux* | mipsisa64*-*-linux*) > default_mips_abi=n32 > enable_mips_multilibs="yes" LGTM, but I don't have the privilege to approve any change so you'll still need to wait for approval :) And I think the behavior change should be announced in https://gcc.gnu.org/gcc-12/changes.html, if it's approved.
On 8/26/2021 10:20 PM, Xi Ruoyao via Gcc-patches wrote: > On Thu, 2021-08-26 at 23:56 -0400, YunQiang Su wrote: >> gcc/ChangeLog: >> >> PR target/102089 >> * config.gcc: MIPS: use N64 ABI by default if the triple end >> with -gnuabi64, which is used by Debian since 2013. >> --- >> gcc/config.gcc | 14 ++++++++++++++ >> 1 file changed, 14 insertions(+) >> >> diff --git a/gcc/config.gcc b/gcc/config.gcc >> index 0ff5cac15..0c91be6f3 100644 >> --- a/gcc/config.gcc >> +++ b/gcc/config.gcc >> @@ -2553,16 +2553,30 @@ mips*-*-linux*) # Linux MIPS, either endian. >> target_cpu_default=MASK_SOFT_FLOAT_ABI >> enable_mips_multilibs="yes" >> ;; >> + mipsisa64r6*-*-linux-gnuabi64) >> + default_mips_abi=64 >> + default_mips_arch=mips64r6 >> + enable_mips_multilibs="yes" >> + ;; >> mipsisa64r6*-*-linux*) >> default_mips_abi=n32 >> default_mips_arch=mips64r6 >> enable_mips_multilibs="yes" >> ;; >> + mipsisa64r2*-*-linux-gnuabi64) >> + default_mips_abi=64 >> + default_mips_arch=mips64r2 >> + enable_mips_multilibs="yes" >> + ;; >> mipsisa64r2*-*-linux*) >> default_mips_abi=n32 >> default_mips_arch=mips64r2 >> enable_mips_multilibs="yes" >> ;; >> + mips64*-*-linux-gnuabi64 | mipsisa64*-*-linux-gnuabi64) >> + default_mips_abi=64 >> + enable_mips_multilibs="yes" >> + ;; >> mips64*-*-linux* | mipsisa64*-*-linux*) >> default_mips_abi=n32 >> enable_mips_multilibs="yes" > LGTM, but I don't have the privilege to approve any change so you'll > still need to wait for approval :) Yea, but having a second pair of eyes chime in is definitely helpful. > > And I think the behavior change should be announced in > https://gcc.gnu.org/gcc-12/changes.html, if it's approved. Agreed. The configure change is approved. And a change to the gcc-12 changes.html is pre-approved. jeff
On Fri, 2021-08-27 at 15:38 -0600, Jeff Law wrote: > > > On 8/26/2021 10:20 PM, Xi Ruoyao via Gcc-patches wrote: > > On Thu, 2021-08-26 at 23:56 -0400, YunQiang Su wrote: > > > gcc/ChangeLog: > > > > > > PR target/102089 > > > * config.gcc: MIPS: use N64 ABI by default if the triple > > > end > > > with -gnuabi64, which is used by Debian since 2013. > > > --- > > > gcc/config.gcc | 14 ++++++++++++++ > > > 1 file changed, 14 insertions(+) > > > > > > diff --git a/gcc/config.gcc b/gcc/config.gcc > > > index 0ff5cac15..0c91be6f3 100644 > > > --- a/gcc/config.gcc > > > +++ b/gcc/config.gcc > > > @@ -2553,16 +2553,30 @@ mips*-*-linux*) # > > > Linux MIPS, either endian. > > > target_cpu_default=MASK_SOFT_FLOAT_ABI > > > enable_mips_multilibs="yes" > > > ;; > > > + mipsisa64r6*-*-linux-gnuabi64) > > > + default_mips_abi=64 > > > + default_mips_arch=mips64r6 > > > + enable_mips_multilibs="yes" > > > + ;; > > > mipsisa64r6*-*-linux*) > > > default_mips_abi=n32 > > > default_mips_arch=mips64r6 > > > enable_mips_multilibs="yes" > > > ;; > > > + mipsisa64r2*-*-linux-gnuabi64) > > > + default_mips_abi=64 > > > + default_mips_arch=mips64r2 > > > + enable_mips_multilibs="yes" > > > + ;; > > > mipsisa64r2*-*-linux*) > > > default_mips_abi=n32 > > > default_mips_arch=mips64r2 > > > enable_mips_multilibs="yes" > > > ;; > > > + mips64*-*-linux-gnuabi64 | mipsisa64*-*-linux- > > > gnuabi64) > > > + default_mips_abi=64 > > > + enable_mips_multilibs="yes" > > > + ;; > > > mips64*-*-linux* | mipsisa64*-*-linux*) > > > default_mips_abi=n32 > > > enable_mips_multilibs="yes" > > LGTM, but I don't have the privilege to approve any change so you'll > > still need to wait for approval :) > Yea, but having a second pair of eyes chime in is definitely helpful. > > > > > And I think the behavior change should be announced in > > https://gcc.gnu.org/gcc-12/changes.html, if it's approved. > Agreed. > > The configure change is approved. Pushed to trunk as 91f78b67. Jeff: YunQiang is working on compilers for CIP United, a company producing MIPS IPs, chips, and toolchains. Is it possible to grant him a write-after-approval? > And a change to the gcc-12 changes.html is pre-approved.
On 8/28/2021 1:17 AM, Xi Ruoyao wrote: > On Fri, 2021-08-27 at 15:38 -0600, Jeff Law wrote: >> >> On 8/26/2021 10:20 PM, Xi Ruoyao via Gcc-patches wrote: >>> On Thu, 2021-08-26 at 23:56 -0400, YunQiang Su wrote: >>>> gcc/ChangeLog: >>>> >>>> PR target/102089 >>>> * config.gcc: MIPS: use N64 ABI by default if the triple >>>> end >>>> with -gnuabi64, which is used by Debian since 2013. >>>> --- >>>> gcc/config.gcc | 14 ++++++++++++++ >>>> 1 file changed, 14 insertions(+) >>>> >>>> diff --git a/gcc/config.gcc b/gcc/config.gcc >>>> index 0ff5cac15..0c91be6f3 100644 >>>> --- a/gcc/config.gcc >>>> +++ b/gcc/config.gcc >>>> @@ -2553,16 +2553,30 @@ mips*-*-linux*) # >>>> Linux MIPS, either endian. >>>> target_cpu_default=MASK_SOFT_FLOAT_ABI >>>> enable_mips_multilibs="yes" >>>> ;; >>>> + mipsisa64r6*-*-linux-gnuabi64) >>>> + default_mips_abi=64 >>>> + default_mips_arch=mips64r6 >>>> + enable_mips_multilibs="yes" >>>> + ;; >>>> mipsisa64r6*-*-linux*) >>>> default_mips_abi=n32 >>>> default_mips_arch=mips64r6 >>>> enable_mips_multilibs="yes" >>>> ;; >>>> + mipsisa64r2*-*-linux-gnuabi64) >>>> + default_mips_abi=64 >>>> + default_mips_arch=mips64r2 >>>> + enable_mips_multilibs="yes" >>>> + ;; >>>> mipsisa64r2*-*-linux*) >>>> default_mips_abi=n32 >>>> default_mips_arch=mips64r2 >>>> enable_mips_multilibs="yes" >>>> ;; >>>> + mips64*-*-linux-gnuabi64 | mipsisa64*-*-linux- >>>> gnuabi64) >>>> + default_mips_abi=64 >>>> + enable_mips_multilibs="yes" >>>> + ;; >>>> mips64*-*-linux* | mipsisa64*-*-linux*) >>>> default_mips_abi=n32 >>>> enable_mips_multilibs="yes" >>> LGTM, but I don't have the privilege to approve any change so you'll >>> still need to wait for approval :) >> Yea, but having a second pair of eyes chime in is definitely helpful. >> >>> And I think the behavior change should be announced in >>> https://gcc.gnu.org/gcc-12/changes.html, if it's approved. >> Agreed. >> >> The configure change is approved. > Pushed to trunk as 91f78b67. > > Jeff: YunQiang is working on compilers for CIP United, a company > producing MIPS IPs, chips, and toolchains. Is it possible to grant him > a write-after-approval? Of course. There's a link to the proper form here: https://gcc.gnu.org/gitwrite.html#authenticated YunQiang can fill that out, list me a sponsor and the overseers will get an account set up. Thanks, jeff
diff --git a/gcc/config.gcc b/gcc/config.gcc index 0ff5cac15..0c91be6f3 100644 --- a/gcc/config.gcc +++ b/gcc/config.gcc @@ -2553,16 +2553,30 @@ mips*-*-linux*) # Linux MIPS, either endian. target_cpu_default=MASK_SOFT_FLOAT_ABI enable_mips_multilibs="yes" ;; + mipsisa64r6*-*-linux-gnuabi64) + default_mips_abi=64 + default_mips_arch=mips64r6 + enable_mips_multilibs="yes" + ;; mipsisa64r6*-*-linux*) default_mips_abi=n32 default_mips_arch=mips64r6 enable_mips_multilibs="yes" ;; + mipsisa64r2*-*-linux-gnuabi64) + default_mips_abi=64 + default_mips_arch=mips64r2 + enable_mips_multilibs="yes" + ;; mipsisa64r2*-*-linux*) default_mips_abi=n32 default_mips_arch=mips64r2 enable_mips_multilibs="yes" ;; + mips64*-*-linux-gnuabi64 | mipsisa64*-*-linux-gnuabi64) + default_mips_abi=64 + enable_mips_multilibs="yes" + ;; mips64*-*-linux* | mipsisa64*-*-linux*) default_mips_abi=n32 enable_mips_multilibs="yes"