From patchwork Tue May 25 06:44:05 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aldy Hernandez X-Patchwork-Id: 1483219 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=2620:52:3:1:0:246e:9693:128c; helo=sourceware.org; envelope-from=gcc-patches-bounces@gcc.gnu.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.a=rsa-sha256 header.s=default header.b=klnw22SP; dkim-atps=neutral Received: from sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4Fq4Lc0Q3lz9sRf for ; Tue, 25 May 2021 16:44:24 +1000 (AEST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 87FA0384841E; Tue, 25 May 2021 06:44:21 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 87FA0384841E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1621925061; bh=C0SGu3U884j3EQdC6snIWpsS4aqiDHWuQQeJbqrdX34=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=klnw22SPPqCI+DRNN3C686S30GRcdeiEc7ik3bBu60lTeeyvTmA5nfjxpLjeeGBCg Il198UuSkWNNeCnUtqTHW0D05C+il0fFXrHkfMS17tvVHe7x4rkrKIRB9L2YXGpbu4 zFk324Xro1E3xUAbKeS0Oq8P/THs4PFZ3CpWaRJc= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 47E1A385701F for ; Tue, 25 May 2021 06:44:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 47E1A385701F Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-216-I1q_6DFRPPycBoJ727qDeg-1; Tue, 25 May 2021 02:44:16 -0400 X-MC-Unique: I1q_6DFRPPycBoJ727qDeg-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B81178015F5; Tue, 25 May 2021 06:44:15 +0000 (UTC) Received: from abulafia.quesejoda.com (ovpn-112-115.ams2.redhat.com [10.36.112.115]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 503515D6AC; Tue, 25 May 2021 06:44:15 +0000 (UTC) Received: from abulafia.quesejoda.com (localhost [127.0.0.1]) by abulafia.quesejoda.com (8.16.1/8.15.2) with ESMTPS id 14P6iCD11347674 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Tue, 25 May 2021 08:44:13 +0200 Received: (from aldyh@localhost) by abulafia.quesejoda.com (8.16.1/8.16.1/Submit) id 14P6iCDI1347673; Tue, 25 May 2021 08:44:12 +0200 To: GCC patches Subject: [PATCH] Fix selftest for targets where short and int are the same size. Date: Tue, 25 May 2021 08:44:05 +0200 Message-Id: <20210525064405.1347426-1-aldyh@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-13.3 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Aldy Hernandez via Gcc-patches From: Aldy Hernandez Reply-To: Aldy Hernandez Errors-To: gcc-patches-bounces@gcc.gnu.org Sender: "Gcc-patches" avr-elf seems to use HImode for both integer_type_node and signed_char_type_node, which is causing the check for different sized VARYING ranges to fail. I've fixed this by using a char which I think should always be smaller than an int. Is there a preferred way of fixing this? Perhaps build_nonstandard_integer or __attribute__((mode(XX)))? Tested on an x86-64 x avr-elf. gcc/ChangeLog: * value-range.cc (range_tests_legacy): Use signed char instead of signed short. --- gcc/value-range.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/gcc/value-range.cc b/gcc/value-range.cc index 8d7b46c0239..5eefd5ff174 100644 --- a/gcc/value-range.cc +++ b/gcc/value-range.cc @@ -2251,10 +2251,10 @@ range_tests_legacy () // VARYING of different sizes should not be equal. int_range_max r0 (integer_type_node); - int_range_max r1 (short_integer_type_node); + int_range_max r1 (signed_char_type_node); ASSERT_TRUE (r0 != r1); value_range vr0 (integer_type_node); - int_range_max vr1 (short_integer_type_node); + int_range_max vr1 (signed_char_type_node); ASSERT_TRUE (vr0 != vr1); }