diff mbox series

PR rtl-optimization/100263: Ensure register can change mode

Message ID 20210505072000.3513197-1-stefansf@linux.ibm.com
State New
Headers show
Series PR rtl-optimization/100263: Ensure register can change mode | expand

Commit Message

Stefan Schulze Frielinghaus May 5, 2021, 7:20 a.m. UTC
For move2add_valid_value_p we also have to ask the target whether a
register can be accessed in a different mode than it was set before.

gcc/ChangeLog:

	PR rtl-optimization/100263
	* postreload.c (move2add_valid_value_p): Ensure register can
	change mode.

Bootstrapped and regtested releases/gcc-{8,9,10,11} and master on IBM Z.
Ok for those branches?

---
 gcc/postreload.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Eric Botcazou May 5, 2021, 10:29 a.m. UTC | #1
> For move2add_valid_value_p we also have to ask the target whether a
> register can be accessed in a different mode than it was set before.
> 
> gcc/ChangeLog:
> 
> 	PR rtl-optimization/100263
> 	* postreload.c (move2add_valid_value_p): Ensure register can
> 	change mode.
> 
> Bootstrapped and regtested releases/gcc-{8,9,10,11} and master on IBM Z.
> Ok for those branches?

Yes, OK everywhere, thanks.
diff mbox series

Patch

diff --git a/gcc/postreload.c b/gcc/postreload.c
index dc67643384d..60a622dbaf3 100644
--- a/gcc/postreload.c
+++ b/gcc/postreload.c
@@ -1725,7 +1725,8 @@  move2add_valid_value_p (int regno, scalar_int_mode mode)
     {
       scalar_int_mode old_mode;
       if (!is_a <scalar_int_mode> (reg_mode[regno], &old_mode)
-	  || !MODES_OK_FOR_MOVE2ADD (mode, old_mode))
+	  || !MODES_OK_FOR_MOVE2ADD (mode, old_mode)
+	  || !REG_CAN_CHANGE_MODE_P (regno, old_mode, mode))
 	return false;
       /* The value loaded into regno in reg_mode[regno] is also valid in
 	 mode after truncation only if (REG:mode regno) is the lowpart of