[v2,03/21] libcc1: inline some simple methods

Message ID	20210428010119.806184-4-tom@tromey.com
State	New
Headers	show Return-Path: <gcc-patches-bounces@gcc.gnu.org> DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 300013854813 From: Tom Tromey <tom@tromey.com> To: gcc-patches@gcc.gnu.org Subject: [PATCH v2 03/21] libcc1: inline some simple methods Date: Tue, 27 Apr 2021 19:01:01 -0600 Message-Id: <20210428010119.806184-4-tom@tromey.com> In-Reply-To: <20210428010119.806184-1-tom@tromey.com> References: <20210428010119.806184-1-tom@tromey.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: list Cc: Tom Tromey <tom@tromey.com> Errors-To: gcc-patches-bounces@gcc.gnu.org Sender: "Gcc-patches" <gcc-patches-bounces@gcc.gnu.org>
Series	C++11-based improvements for libcc1 \| expand [v2,00/21] C++11-based improvements for libcc1 [v2,01/21] libcc1: use templates to unmarshall enums [v2,02/21] libcc1: use "override" [v2,03/21] libcc1: inline some simple methods [v2,04/21] libcc1: delete copy constructor and assignment operators [v2,05/21] libcc1: use variadic templates for "call" [v2,06/21] libcc1: use variadic templates for "rpc" [v2,07/21] libcc1: use std::vector when building function types [v2,08/21] libcc1: add deleter objects [v2,09/21] libcc1: add more uses of 'deleter' [v2,10/21] libcc1: use unique_ptr more [v2,11/21] libcc1: unify compiler handling [v2,12/21] libcc1: use foreach [v2,13/21] libcc1: use static_assert [v2,14/21] libcc1: share basic context code [v2,15/21] libcc1: share GDB plugin code [v2,16/21] libcc1: use GCC_FE_VERSION_1 in C++ plugin [v2,17/21] libcc1: share the GCC interface code [v2,18/21] libcc1: fix a memory leak [v2,19/21] libcc1: use variadic templates for callbacks [v2,20/21] libcc1: avoid extra string copies [v2,21/21] libcc1: avoid a call to c_str

Message ID

20210428010119.806184-4-tom@tromey.com

State

New

Headers

DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 300013854813
From: Tom Tromey <tom@tromey.com>
To: gcc-patches@gcc.gnu.org
Subject: [PATCH v2 03/21] libcc1: inline some simple methods
Date: Tue, 27 Apr 2021 19:01:01 -0600
Message-Id: <20210428010119.806184-4-tom@tromey.com>
In-Reply-To: <20210428010119.806184-1-tom@tromey.com>
References: <20210428010119.806184-1-tom@tromey.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: list
Cc: Tom Tromey <tom@tromey.com>
Errors-To: gcc-patches-bounces@gcc.gnu.org
Sender: "Gcc-patches" <gcc-patches-bounces@gcc.gnu.org>

Series

C++11-based improvements for libcc1 | expand

Commit Message

Tom Tromey April 28, 2021, 1:01 a.m. UTC

This changes libcc1 to inline a trivial method and to use the default
constructor.

libcc1/ChangeLog
2021-04-27  Tom Tromey  <tom@tromey.com>

	* connection.hh (~connection): Use default.
	(print): Inline.
	* connection.cc (cc1_plugin::connection::~connection)
	(cc1_plugin::connection::print): Remove definitions.
---
 libcc1/ChangeLog     | 7 +++++++
 libcc1/connection.cc | 9 ---------
 libcc1/connection.hh | 6 ++++--
 3 files changed, 11 insertions(+), 11 deletions(-)

Comments

Jeff Law April 28, 2021, 3:54 p.m. UTC | #1

On 4/27/2021 7:01 PM, Tom Tromey wrote:
> This changes libcc1 to inline a trivial method and to use the default
> constructor.
>
> libcc1/ChangeLog
> 2021-04-27  Tom Tromey  <tom@tromey.com>
>
> 	* connection.hh (~connection): Use default.
> 	(print): Inline.
> 	* connection.cc (cc1_plugin::connection::~connection)
> 	(cc1_plugin::connection::print): Remove definitions.

OK

Jeff

diff --git a/libcc1/connection.cc b/libcc1/connection.cc
index 64a6d4922c15..66d573911080 100644
--- a/libcc1/connection.cc
+++ b/libcc1/connection.cc
@@ -27,15 +27,6 @@  along with GCC; see the file COPYING3.  If not see
 #include "connection.hh"
 #include "rpc.hh"
 
-cc1_plugin::connection::~connection ()
-{
-}
-
-void
-cc1_plugin::connection::print (const char *)
-{
-}
-
 cc1_plugin::status
 cc1_plugin::connection::send (char c)
 {
diff --git a/libcc1/connection.hh b/libcc1/connection.hh
index 50e8a8b5a032..a0e99bdbd98f 100644
--- a/libcc1/connection.hh
+++ b/libcc1/connection.hh
@@ -46,7 +46,7 @@  namespace cc1_plugin
     {
     }
 
-    virtual ~connection ();
+    virtual ~connection () = default;
 
     // Send a single character.  This is used to introduce various
     // higher-level protocol elements.
@@ -89,7 +89,9 @@  namespace cc1_plugin
       m_callbacks.add_callback (name, func);
     }
 
-    virtual void print (const char *);
+    virtual void print (const char *)
+    {
+    }
 
   private:

[v2,03/21] libcc1: inline some simple methods

Commit Message

Comments

Patch