From patchwork Mon Apr 26 12:45:46 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?Christoph_M=C3=BCllner?= X-Patchwork-Id: 1470280 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=2620:52:3:1:0:246e:9693:128c; helo=sourceware.org; envelope-from=gcc-patches-bounces@gcc.gnu.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.a=rsa-sha256 header.s=default header.b=aIqG4fMP; dkim-atps=neutral Received: from sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4FTPld6GFGz9sWH for ; Mon, 26 Apr 2021 22:46:21 +1000 (AEST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id D82E039450D4; Mon, 26 Apr 2021 12:46:05 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D82E039450D4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1619441165; bh=DSE56pXh2sDwXB6Fs9IftBtCDAR7v27Qo2oN2T4iee0=; h=To:Subject:Date:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=aIqG4fMPkydoqYYyc+Lu++TpQL16S+xFHVHSugzeJTvYhlLc4n5WDawawTJIwv+Nt 0GfXohMh6sGAPuXuAWPlCyUdxXnulsDYolATEmEA7K+P3UWIA4933fcfPb4FjdYyv8 uibN9CFuE21bxAgMapCaAMeHXca6l98wJb0sBXfY= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mail-ej1-f41.google.com (mail-ej1-f41.google.com [209.85.218.41]) by sourceware.org (Postfix) with ESMTPS id AFC5F389041B; Mon, 26 Apr 2021 12:46:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org AFC5F389041B Received: by mail-ej1-f41.google.com with SMTP id r9so84235585ejj.3; Mon, 26 Apr 2021 05:46:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=DSE56pXh2sDwXB6Fs9IftBtCDAR7v27Qo2oN2T4iee0=; b=mOmphKHvUHFzES0BncTkhqSchl/tRH30Om2LwPdsTvDdHsl4y2f6019teJ6CwK7qZo u+7SqJ3AQYF3lTWDdocrf23Ux3rs4xHu9dtWHM5iFy9R5sDLC5HP7XunwSwPLSIBI8NM WIuyd5wqsQ8nHUCVY42iHSlVdxpLC60LeecZHPgVFq50ZtDoMN/qumMR9iRRy0+Dipmi aVhteYmhLkX6sYYGTq1CH36crsMKxZYF8AHV1cuFnpB8lPXEmTpBzmqXX8atbX3S0o1o WIXZHriT93S6A0RFnKkWPoK4jFUE0cT6ylk23RvZ9IHkdZJQ02GAL2+X5FsBsurun1fC Eg+w== X-Gm-Message-State: AOAM5334UWYXG+k5uB1JAOv6egVCFVwSOTWq4B7wqPvQ8fPKHZTCQrDi KiVj4ZLQlz7PAw/lN1t3zxNRQzoPfyBA1Q== X-Google-Smtp-Source: ABdhPJw59dIWFc7u9WViyzISw69ezRQV7w7tLqdj7Qxv+7t6rIzPGhtVP3Qyu3SpuiTfZGHDi4ZHqw== X-Received: by 2002:a17:906:f8cd:: with SMTP id lh13mr18454328ejb.387.1619441160620; Mon, 26 Apr 2021 05:46:00 -0700 (PDT) Received: from beast.fritz.box (62-178-178-158.cable.dynamic.surfer.at. [62.178.178.158]) by smtp.gmail.com with ESMTPSA id o20sm14126755eds.65.2021.04.26.05.45.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Apr 2021 05:46:00 -0700 (PDT) To: gcc-patches@gcc.gnu.org Subject: [PATCH 04/10] RISC-V: Don't use amoswap for atomic stores [PR 100265] Date: Mon, 26 Apr 2021 14:45:46 +0200 Message-Id: <20210426124552.3316789-5-cmuellner@gcc.gnu.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210426124552.3316789-1-cmuellner@gcc.gnu.org> References: <20210426124552.3316789-1-cmuellner@gcc.gnu.org> MIME-Version: 1.0 X-Spam-Status: No, score=-11.4 required=5.0 tests=BAYES_00, FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, GIT_PATCH_0, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Christoph Muellner via Gcc-patches From: =?utf-8?q?Christoph_M=C3=BCllner?= Reply-To: Christoph Muellner Cc: Kito Cheng Errors-To: gcc-patches-bounces@gcc.gnu.org Sender: "Gcc-patches" Using amoswap as atomic store is not an expected optimization and most likely causes a performance penalty. Neither SW nor HW have a benefit from this optimization, so let's simply drop it. gcc/ PR 100265 * config/riscv/sync.md (atomic_store): Remove. --- gcc/config/riscv/sync.md | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/gcc/config/riscv/sync.md b/gcc/config/riscv/sync.md index aeeb2e854b68..efd49745a8e2 100644 --- a/gcc/config/riscv/sync.md +++ b/gcc/config/riscv/sync.md @@ -57,17 +57,6 @@ ;; Atomic memory operations. -;; Implement atomic stores with amoswap. Fall back to fences for atomic loads. -(define_insn "atomic_store" - [(set (match_operand:GPR 0 "memory_operand" "=A") - (unspec_volatile:GPR - [(match_operand:GPR 1 "reg_or_0_operand" "rJ") - (match_operand:SI 2 "const_int_operand")] ;; model - UNSPEC_ATOMIC_STORE))] - "TARGET_ATOMIC" - "amoswap.%A2 zero,%z1,%0" - [(set (attr "length") (const_int 8))]) - (define_insn "atomic_" [(set (match_operand:GPR 0 "memory_operand" "+A") (unspec_volatile:GPR