From patchwork Thu Apr 1 09:12:40 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jakub Jelinek X-Patchwork-Id: 1460915 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=8.43.85.97; helo=sourceware.org; envelope-from=gcc-patches-bounces@gcc.gnu.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.a=rsa-sha256 header.s=default header.b=yDj9WJPE; dkim-atps=neutral Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4F9yCH4Gxzz9sV5 for ; Thu, 1 Apr 2021 20:13:14 +1100 (AEDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id B54B2384B072; Thu, 1 Apr 2021 09:13:10 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B54B2384B072 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1617268390; bh=AcYH7n+iIGoeAdrCZfnREhrugDBmydIf0dwKTratM4I=; h=Date:To:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=yDj9WJPEpAeJro4vnBMPEHgl968363JltscgubAkJ87Uu+1bY4XU1o5oE3rRFc0Oe Aapqy2Jj53l/PgzMwpi/t2Zo/uNyHeCvS5V9C90DdCjJNz42PKimjmt4d4OsH8f8iR W1NqvjdO9U2e1ugXq7nm2C1SBgXsTbfx3IUL/Wjs= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id 6FEC73858028 for ; Thu, 1 Apr 2021 09:13:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 6FEC73858028 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-575-SCAN5lvdN-KeE6ZhoSd2aA-1; Thu, 01 Apr 2021 05:13:03 -0400 X-MC-Unique: SCAN5lvdN-KeE6ZhoSd2aA-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 9E8098B2808; Thu, 1 Apr 2021 09:12:44 +0000 (UTC) Received: from tucnak.zalov.cz (ovpn-112-95.ams2.redhat.com [10.36.112.95]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4691F10016DB; Thu, 1 Apr 2021 09:12:44 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.16.1/8.16.1) with ESMTPS id 1319CfCk3892348 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Thu, 1 Apr 2021 11:12:41 +0200 Received: (from jakub@localhost) by tucnak.zalov.cz (8.16.1/8.16.1/Submit) id 1319Cecj3892347; Thu, 1 Apr 2021 11:12:40 +0200 Date: Thu, 1 Apr 2021 11:12:40 +0200 To: gcc-patches@gcc.gnu.org, Martin =?utf-8?b?TGnFoWth?= Subject: doc: Fix up symver attribute documentation Message-ID: <20210401091240.GX1179226@tucnak> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline X-Spam-Status: No, score=-5.9 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Jakub Jelinek via Gcc-patches From: Jakub Jelinek Reply-To: Jakub Jelinek Errors-To: gcc-patches-bounces@gcc.gnu.org Sender: "Gcc-patches" Hi! When looking at the symver documentation, I've noticed a couple of syntax errors in it. Committed to trunk as obvious. But looking more at it, the r11-2859-g363080bb8bd2cca81dd9e2e774910a8c8226f430 change that introduced this has another problem - the documentation still talks about foo_v1 but the alias attribute has been removed from the example. Maybe it would be better to restore to the old way for symver_foo_v1 with its GCC 10 attributes, describe what that does, then have the bar example and add baz example with multiple symver attributes in the same attribute and describe what each of them does and mention that only binutils 2.35 and later actually handle some of the forms. 2021-04-01 Jakub Jelinek * doc/extend.texi (symver attribute): Fix up syntax errors in the examples. Jakub --- gcc/doc/extend.texi.jj 2021-03-03 09:43:57.898723872 +0100 +++ gcc/doc/extend.texi 2021-04-01 10:56:25.604914998 +0200 @@ -3851,13 +3851,13 @@ output. One can also define multiple version for a given symbol. @smallexample -__attribute__ ((__symver__ ("foo@@VERS_2"), ("foo@@VERS_3"))) +__attribute__ ((__symver__ ("foo@@VERS_2"), __symver__ ("foo@@VERS_3"))) int symver_foo_v1 (void) @{ @} -__attribute__ ((__symver__ ("bar@@VERS_2")))) -__attribute__ ((__symver__ ("bar@@VERS_3")))) +__attribute__ ((__symver__ ("bar@@VERS_2"))) +__attribute__ ((__symver__ ("bar@@VERS_3"))) int symver_bar_v1 (void) @{ @}