diff mbox series

[committed] gcse, ipa-devirt: Use %wd/%wu instead of HOST_WIDE_INT_PRINT* in diagnostics [PR99288]

Message ID 20210227094615.GC4020736@tucnak
State New
Headers show
Series [committed] gcse, ipa-devirt: Use %wd/%wu instead of HOST_WIDE_INT_PRINT* in diagnostics [PR99288] | expand

Commit Message

Jakub Jelinek Feb. 27, 2021, 9:46 a.m. UTC 
Hi!

HOST_WIDE_INT_PRINT* in the string literals of warning/error/inform etc.
make those messages non-translatable, and we have a perfectly fine
alternative when not using system *printf - %w{d,u}.

Bootstrapped/regtested on x86_64-linux and i686-linux, committed to trunk
as obvious.

2021-02-27  Jakub Jelinek  <jakub@redhat.com>

	PR other/99288
	* gcse.c (gcse_or_cprop_is_too_expensive): Use %wu instead of
	HOST_WIDE_INT_PRINT_UNSIGNED in warning format string.
	* ipa-devirt.c (ipa_odr_read_section): Use %wd instead of
	HOST_WIDE_INT_PRINT_DEC in inform format string.  Fix comment
	typos.



	Jakub
diff mbox series

Patch

--- gcc/gcse.c.jj	2021-01-29 15:18:07.997293117 +0100
+++ gcc/gcse.c	2021-02-26 17:03:23.174388798 +0100
@@ -4011,8 +4011,7 @@  gcse_or_cprop_is_too_expensive (const ch
     {
       warning (OPT_Wdisabled_optimization,
 	       "%s: %d basic blocks and %d registers; "
-	       "increase %<--param max-gcse-memory%> above "
-	       HOST_WIDE_INT_PRINT_UNSIGNED,
+	       "increase %<--param max-gcse-memory%> above %wu",
 	       pass, n_basic_blocks_for_fn (cfun), max_reg_num (),
 	       memory_request / 1024);
 
--- gcc/ipa-devirt.c.jj	2021-01-04 10:25:38.196241037 +0100
+++ gcc/ipa-devirt.c	2021-02-26 17:05:11.904182848 +0100
@@ -4261,13 +4261,12 @@  ipa_odr_read_section (struct lto_file_de
 			    " in another translation unit",
 			    this_enum.vals[j].name, warn_name);
 		  /* FIXME: In case there is easy way to print wide_ints,
-		     perhaps we could do it here instead of overlfow checpl.  */
+		     perhaps we could do it here instead of overflow check.  */
 		  else if (wi::fits_shwi_p (this_enum.vals[j].val)
 			   && wi::fits_shwi_p (warn_value))
 		    inform (this_enum.vals[j].locus,
-			    "name %qs is defined to " HOST_WIDE_INT_PRINT_DEC
-			    " while another translation unit defines "
-			    "it as " HOST_WIDE_INT_PRINT_DEC,
+			    "name %qs is defined to %wd while another "
+			    "translation unit defines it as %wd",
 			    warn_name, this_enum.vals[j].val.to_shwi (),
 			    warn_value.to_shwi ());
 		  else