| Message ID | 20210114150053.2939319-1-hjl.tools@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | i386: Update PR target/95021 tests | expand |
On Thu, Jan 14, 2021 at 4:00 PM H.J. Lu <hjl.tools@gmail.com> wrote: > > Also pass -mpreferred-stack-boundary=4 -mno-stackrealign to avoid > disabling STV by: > > /* Disable STV if -mpreferred-stack-boundary={2,3} or > -mincoming-stack-boundary={2,3} or -mstackrealign - the needed > stack realignment will be extra cost the pass doesn't take into > account and the pass can't realign the stack. */ > if (ix86_preferred_stack_boundary < 128 > || ix86_incoming_stack_boundary < 128 > || opts->x_ix86_force_align_arg_pointer) > opts->x_target_flags &= ~MASK_STV; > > PR target/98676 > * gcc.target/i386/pr95021-1.c: Add -mpreferred-stack-boundary=4 > -mno-stackrealign. > * gcc.target/i386/pr95021-3.c: Likewise. OK. Thanks, Uros. > --- > gcc/testsuite/gcc.target/i386/pr95021-1.c | 2 +- > gcc/testsuite/gcc.target/i386/pr95021-3.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/gcc/testsuite/gcc.target/i386/pr95021-1.c b/gcc/testsuite/gcc.target/i386/pr95021-1.c > index a0b9a262a87..ec58596959c 100644 > --- a/gcc/testsuite/gcc.target/i386/pr95021-1.c > +++ b/gcc/testsuite/gcc.target/i386/pr95021-1.c > @@ -1,5 +1,5 @@ > /* { dg-do compile { target ia32 } } */ > -/* { dg-options "-O2 -msse2 -mstv -W" } */ > +/* { dg-options "-O2 -msse2 -mstv -mpreferred-stack-boundary=4 -mno-stackrealign -W" } */ > /* { dg-final { scan-assembler "movq\[ \t\]%xmm\[0-9\]+, \\(%esp\\)" } } */ > /* { dg-final { scan-assembler-not "psrlq" } } */ > > diff --git a/gcc/testsuite/gcc.target/i386/pr95021-3.c b/gcc/testsuite/gcc.target/i386/pr95021-3.c > index 52f9e4569b3..0f16b16f793 100644 > --- a/gcc/testsuite/gcc.target/i386/pr95021-3.c > +++ b/gcc/testsuite/gcc.target/i386/pr95021-3.c > @@ -1,5 +1,5 @@ > /* { dg-do compile { target ia32 } } */ > -/* { dg-options "-O2 -msse2 -mstv -mregparm=3 -W -mtune=generic" } */ > +/* { dg-options "-O2 -msse2 -mstv -mpreferred-stack-boundary=4 -mno-stackrealign -mregparm=3 -W -mtune=generic" } */ > /* { dg-final { scan-assembler "movq\[ \t\]+\[^\n\]*, %xmm" } } */ > > #include "pr95021-1.c" > -- > 2.29.2 >
diff --git a/gcc/testsuite/gcc.target/i386/pr95021-1.c b/gcc/testsuite/gcc.target/i386/pr95021-1.c index a0b9a262a87..ec58596959c 100644 --- a/gcc/testsuite/gcc.target/i386/pr95021-1.c +++ b/gcc/testsuite/gcc.target/i386/pr95021-1.c @@ -1,5 +1,5 @@ /* { dg-do compile { target ia32 } } */ -/* { dg-options "-O2 -msse2 -mstv -W" } */ +/* { dg-options "-O2 -msse2 -mstv -mpreferred-stack-boundary=4 -mno-stackrealign -W" } */ /* { dg-final { scan-assembler "movq\[ \t\]%xmm\[0-9\]+, \\(%esp\\)" } } */ /* { dg-final { scan-assembler-not "psrlq" } } */ diff --git a/gcc/testsuite/gcc.target/i386/pr95021-3.c b/gcc/testsuite/gcc.target/i386/pr95021-3.c index 52f9e4569b3..0f16b16f793 100644 --- a/gcc/testsuite/gcc.target/i386/pr95021-3.c +++ b/gcc/testsuite/gcc.target/i386/pr95021-3.c @@ -1,5 +1,5 @@ /* { dg-do compile { target ia32 } } */ -/* { dg-options "-O2 -msse2 -mstv -mregparm=3 -W -mtune=generic" } */ +/* { dg-options "-O2 -msse2 -mstv -mpreferred-stack-boundary=4 -mno-stackrealign -mregparm=3 -W -mtune=generic" } */ /* { dg-final { scan-assembler "movq\[ \t\]+\[^\n\]*, %xmm" } } */ #include "pr95021-1.c"
Also pass -mpreferred-stack-boundary=4 -mno-stackrealign to avoid disabling STV by: /* Disable STV if -mpreferred-stack-boundary={2,3} or -mincoming-stack-boundary={2,3} or -mstackrealign - the needed stack realignment will be extra cost the pass doesn't take into account and the pass can't realign the stack. */ if (ix86_preferred_stack_boundary < 128 || ix86_incoming_stack_boundary < 128 || opts->x_ix86_force_align_arg_pointer) opts->x_target_flags &= ~MASK_STV; PR target/98676 * gcc.target/i386/pr95021-1.c: Add -mpreferred-stack-boundary=4 -mno-stackrealign. * gcc.target/i386/pr95021-3.c: Likewise. --- gcc/testsuite/gcc.target/i386/pr95021-1.c | 2 +- gcc/testsuite/gcc.target/i386/pr95021-3.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)