From patchwork Mon Nov 30 14:17:11 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pierre-Marie de Rodat X-Patchwork-Id: 1408318 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=8.43.85.97; helo=sourceware.org; envelope-from=gcc-patches-bounces@gcc.gnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=adacore.com Received: from sourceware.org (unknown [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4Cl6kT1Ncwz9sSf for ; Tue, 1 Dec 2020 01:17:21 +1100 (AEDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 4DBC63894C17; Mon, 30 Nov 2020 14:17:14 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from rock.gnat.com (rock.gnat.com [IPv6:2620:20:4000:0:a9e:1ff:fe9b:1d1]) by sourceware.org (Postfix) with ESMTP id D1D813892023 for ; Mon, 30 Nov 2020 14:17:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org D1D813892023 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=derodat@adacore.com Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 9E04F561E3; Mon, 30 Nov 2020 09:17:11 -0500 (EST) X-Virus-Scanned: Debian amavisd-new at gnat.com Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 5n3MZSQa3zIn; Mon, 30 Nov 2020 09:17:11 -0500 (EST) Received: from tron.gnat.com (tron.gnat.com [205.232.38.10]) by rock.gnat.com (Postfix) with ESMTP id 84F06116D15; Mon, 30 Nov 2020 09:17:11 -0500 (EST) Received: by tron.gnat.com (Postfix, from userid 4862) id 8404ACB; Mon, 30 Nov 2020 09:17:11 -0500 (EST) Date: Mon, 30 Nov 2020 09:17:11 -0500 From: Pierre-Marie de Rodat To: gcc-patches@gcc.gnu.org Subject: [Ada] Add continuation message when others choice not allowed Message-ID: <20201130141711.GA117724@adacore.com> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.23 (2014-03-12) X-Spam-Status: No, score=-11.1 required=5.0 tests=BAYES_00, GIT_PATCH_0, KAM_DMARC_STATUS, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Yannick Moy Errors-To: gcc-patches-bounces@gcc.gnu.org Sender: "Gcc-patches" In a context where the bounds of an array aggregate are not known, the aggregate is not allowed to include an "others" choice. The error message given by GNAT now includes a suggestion to qualify the aggregate with a constrained subtype to fix the issue. Tested on x86_64-pc-linux-gnu, committed on trunk gcc/ada/ * sem_aggr.adb (Resolve_Array_Aggregate): Improve error message. diff --git a/gcc/ada/sem_aggr.adb b/gcc/ada/sem_aggr.adb --- a/gcc/ada/sem_aggr.adb +++ b/gcc/ada/sem_aggr.adb @@ -1870,10 +1870,15 @@ package body Sem_Aggr is -- Test for the validity of an others choice if present if Others_Present and then not Others_Allowed then - Error_Msg_N - ("OTHERS choice not allowed here", - First (Choice_List (First (Component_Associations (N))))); - return Failure; + declare + Others_N : constant Node_Id := + First (Choice_List (First (Component_Associations (N)))); + begin + Error_Msg_N ("OTHERS choice not allowed here", Others_N); + Error_Msg_N ("\qualify the aggregate with a constrained subtype " + & "to provide bounds for it", Others_N); + return Failure; + end; end if; -- Protect against cascaded errors