diff mbox series

profopt-execute: unset testname_with_flags if create_gcov fails

Message ID 20201126192220.284292-1-iii@linux.ibm.com
State New
Headers show
Series profopt-execute: unset testname_with_flags if create_gcov fails | expand

Commit Message

Ilya Leoshkevich Nov. 26, 2020, 7:22 p.m. UTC 
Bootstrapped and regtested on x86_64-redhat-linux and
s390x-redhat-linux.  Ok for master?



When diffing test results, there sometimes occur spurious "New tests
that PASS" / "Old tests that passed, that have disappeared" messages.
The reason is that if create_gcov is not installed, then the cached
testname_with_flags is not cleared and is carried over to the next
test.

gcc/testsuite/ChangeLog:

2020-11-26  Ilya Leoshkevich  <iii@linux.ibm.com>

	* lib/profopt.exp: Unset testname_with_flags if create_gcov
	fails.
---
 gcc/testsuite/lib/profopt.exp | 1 +
 1 file changed, 1 insertion(+)

Comments

Jeff Law Nov. 30, 2020, 6:04 p.m. UTC | #1 
On 11/26/20 12:22 PM, Ilya Leoshkevich via Gcc-patches wrote:
> Bootstrapped and regtested on x86_64-redhat-linux and
> s390x-redhat-linux.  Ok for master?
>
>
>
> When diffing test results, there sometimes occur spurious "New tests
> that PASS" / "Old tests that passed, that have disappeared" messages.
> The reason is that if create_gcov is not installed, then the cached
> testname_with_flags is not cleared and is carried over to the next
> test.
>
> gcc/testsuite/ChangeLog:
>
> 2020-11-26  Ilya Leoshkevich  <iii@linux.ibm.com>
>
> 	* lib/profopt.exp: Unset testname_with_flags if create_gcov
> 	fails.

OK.

Thanks,
Jeff
diff mbox series

Patch

diff --git a/gcc/testsuite/lib/profopt.exp b/gcc/testsuite/lib/profopt.exp
index d6863439d04..98e1a0e63af 100644
--- a/gcc/testsuite/lib/profopt.exp
+++ b/gcc/testsuite/lib/profopt.exp
@@ -456,6 +456,7 @@  proc profopt-execute { src } {
 		set id [remote_spawn "" $cmd]
 		if { $id < 0 } {
 		    unsupported "$testcase -fauto-profile: cannot run create_gcov"
+		    unset testname_with_flags
 		    set status "fail"
 		    return
 		}