| Message ID | 20201126163258.GA2155377@redhat.com |
|---|---|
| State | New |
| Headers | show |
| Series | doc: Fix description of dg-require-effective-target | expand |
On 11/26/20 9:32 AM, Jonathan Wakely via Gcc-patches wrote: > The optional target selector for the dg-require-effective-target > directive needs to be { target selector } not just { selector } as > currently documented. > > gcc/ChangeLog: > > * doc/sourcebuild.texi (Directives): Fix description of > dg-require-effective-target to include "target" in selector. > > This seems correct according to my testing with the libstdc++ > testsuite, and all existing uses in the gcc/testsuite. > > The other directives that require { target selector } say so > explicitly, e.g. dg-options, dg-additional-options, dg-timeout ... > > OK for trunk? OK jeff
diff --git a/gcc/doc/sourcebuild.texi b/gcc/doc/sourcebuild.texi index 852eaa2e6765..4f7af2074fe7 100644 --- a/gcc/doc/sourcebuild.texi +++ b/gcc/doc/sourcebuild.texi @@ -1141,7 +1141,7 @@ but not if @code{-fpic} is also present: /* @{ dg-skip-if "" @{ *-*-* @} @{ "-O2 -g" "-O3 -g" @} @{ "-fpic" @} @} */ @end smallexample -@item @{ dg-require-effective-target @var{keyword} [@{ @var{selector} @}] @} +@item @{ dg-require-effective-target @var{keyword} [@{ target @var{selector} @}] @} Skip the test if the test target, including current multilib flags, is not covered by the effective-target keyword. If the directive includes the optional @samp{@{ @var{selector} @}}
The optional target selector for the dg-require-effective-target directive needs to be { target selector } not just { selector } as currently documented. gcc/ChangeLog: * doc/sourcebuild.texi (Directives): Fix description of dg-require-effective-target to include "target" in selector. This seems correct according to my testing with the libstdc++ testsuite, and all existing uses in the gcc/testsuite. The other directives that require { target selector } say so explicitly, e.g. dg-options, dg-additional-options, dg-timeout ... OK for trunk? commit 3daf8d7e4208225cebd9fa5af30913837b43d783 Author: Jonathan Wakely <jwakely@redhat.com> Date: Thu Nov 26 16:27:04 2020 doc: Fix description of dg-require-effective-target The optional target selector for the dg-require-effective-target directive needs to be { target selector } not just { selector } as currently documented. gcc/ChangeLog: * doc/sourcebuild.texi (Directives): Fix description of dg-require-effective-target to include "target" in selector.