From patchwork Wed Oct 14 20:48:38 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Malcolm X-Patchwork-Id: 1382343 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=8.43.85.97; helo=sourceware.org; envelope-from=gcc-patches-bounces@gcc.gnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gcc.gnu.org Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.a=rsa-sha256 header.s=default header.b=cALVMocR; dkim-atps=neutral Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4CBPdx3vGXz9sTr for ; Thu, 15 Oct 2020 07:48:50 +1100 (AEDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 5D2033857C55; Wed, 14 Oct 2020 20:48:45 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 5D2033857C55 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1602708525; bh=l1k2G+G8/DUAb40/jI8HwGoP2CRdWW2COTjZKmSGblM=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=cALVMocR6KCUuyBQi6ddkBJNpTihBVoUQ20kpdOWA3/3BpJvojXeRRawarKHeV2jl ZS761mnjG89NRnf99hTzvzFVj7Y89I2isUdk7C8uapTTPMljogB4/OP+/K+sE0dK1A oqx3pccUg3J6dJjADQ8X++cnOjCrhaRY8Rpy/KPI= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id 200813857C43 for ; Wed, 14 Oct 2020 20:48:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 200813857C43 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-159-9hXMdZHPOcWRjzJA3WrBrw-1; Wed, 14 Oct 2020 16:48:40 -0400 X-MC-Unique: 9hXMdZHPOcWRjzJA3WrBrw-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C97AA1074647 for ; Wed, 14 Oct 2020 20:48:39 +0000 (UTC) Received: from t470.redhat.com (ovpn-112-135.phx2.redhat.com [10.3.112.135]) by smtp.corp.redhat.com (Postfix) with ESMTP id 718121992D; Wed, 14 Oct 2020 20:48:39 +0000 (UTC) To: gcc-patches@gcc.gnu.org Subject: [committed] analyzer: fix build with ada [PR93723] Date: Wed, 14 Oct 2020 16:48:38 -0400 Message-Id: <20201014204838.758063-1-dmalcolm@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-13.8 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: David Malcolm via Gcc-patches From: David Malcolm Reply-To: David Malcolm Errors-To: gcc-patches-bounces@gcc.gnu.org Sender: "Gcc-patches" This patch fixes an ICE seen in various ada source files within the analyzer when attempting to bootstrap with --with-build-config=bootstrap-analyzer where: $ cat config/bootstrap-analyzer.mk STAGE2_CFLAGS += -fanalyzer STAGE3_CFLAGS += -fanalyzer With this patch, the bootstrap succeeded (after 7 hours; it normally takes 40-45 minutes on this machine) and the only regression test failures were in gcc.dg/plugin/poly-int-*_plugin.c, due to hitting the 5 minutes per test timeouts (where -fanalyzer was being injected into the test runs). Successfully bootstrapped & regrtested on x86_64-pc-linux-gnu. Pushed to master as r11-3895-g12b267cc606a48a2fef809189c35573c4a51d3a5. gcc/analyzer/ChangeLog: PR analyzer/93723 * store.cc (binding_map::apply_ctor_to_region): Remove redundant assertion. --- gcc/analyzer/store.cc | 1 - 1 file changed, 1 deletion(-) diff --git a/gcc/analyzer/store.cc b/gcc/analyzer/store.cc index 11585123561..7e91addd035 100644 --- a/gcc/analyzer/store.cc +++ b/gcc/analyzer/store.cc @@ -455,7 +455,6 @@ binding_map::apply_ctor_to_region (const region *parent_reg, tree ctor, { gcc_assert (parent_reg); gcc_assert (TREE_CODE (ctor) == CONSTRUCTOR); - gcc_assert (!CONSTRUCTOR_NO_CLEARING (ctor)); unsigned ix; tree index;