From patchwork Wed Oct 7 22:57:56 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alan Modra X-Patchwork-Id: 1378326 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=2620:52:3:1:0:246e:9693:128c; helo=sourceware.org; envelope-from=gcc-patches-bounces@gcc.gnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gcc.gnu.org Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.a=rsa-sha256 header.s=default header.b=gcwC67Or; dkim-atps=neutral Received: from sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4C68sB0Sdwz9sPB for ; Thu, 8 Oct 2020 09:58:54 +1100 (AEDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id D5163386F810; Wed, 7 Oct 2020 22:58:45 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D5163386F810 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1602111525; bh=9/ZFM1H40aFEBcJAst5BpM6/k2F3ZCRjMZln7+IL8BI=; h=To:Subject:Date:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=gcwC67OrqMV9OX5inv7xSHK+p7Q52TmXKEovAmMSz3unRwsLsrfuiC7xZVfCtnYbE Bud4Lnvv6bGRBVOskWhHYNPdFl65eaqvpATUffgyzqwAYiZd1lZ7L2LRqxZ7OJ/5j+ KZ+59jwN2kW6NdXtePDVa05gsMTHDXLbsnbF4LGo= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mail-pf1-x442.google.com (mail-pf1-x442.google.com [IPv6:2607:f8b0:4864:20::442]) by sourceware.org (Postfix) with ESMTPS id 1B35C386F810 for ; Wed, 7 Oct 2020 22:58:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 1B35C386F810 Received: by mail-pf1-x442.google.com with SMTP id l126so2367514pfd.5 for ; Wed, 07 Oct 2020 15:58:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=9/ZFM1H40aFEBcJAst5BpM6/k2F3ZCRjMZln7+IL8BI=; b=QoBYXuii86/PTBFtXKC3LTvsVjC5o4hyRvfZHvV0oEkV0aHdQ4IPFBhlpGZst+RdTa VjWFq5DV7ulFnFr48RqdNghc2VA3nl5zOSND7cshfV4bGVUJiND4UrPtIscFIY/k2vLP 77U7uPinr1r5bCpsgn/axgPV3DX+uQwLQILg25d4XzkLPH2IIUuxkTrVbBiVGBOr2V2k PLJ6VFA598CqPBPnOvNb+UedkVN1p50a8w5KBLgCWORr44Ooa3nV1ZVrsChnQPZUsNu1 Bjof4hbZsMaXknE7t57q4s8798DXdA0DCt3QNoOmaxwj1gPFkMh2Lzp9nm7OQyBpnZsp J/mA== X-Gm-Message-State: AOAM533EI4XKYdL9bCaLURbnxpluF4Wn2bK65nnfkls7LmSVh2Wyz6GZ 2Zv6J+ODeKoYSEjvR8R35dsAK8RBGZiKGQ== X-Google-Smtp-Source: ABdhPJy2a/N2i2i/jPxcopi91cDFAjR4eaaTGmh8UP4tagdFPodK76YDD4EUgJJss/VoDPzKNZj2SA== X-Received: by 2002:a62:2985:0:b029:142:2501:35d3 with SMTP id p127-20020a6229850000b0290142250135d3mr4975280pfp.51.1602111522242; Wed, 07 Oct 2020 15:58:42 -0700 (PDT) Received: from bubble.grove.modra.org ([2406:3400:51d:8cc0:e872:ea73:2f18:2dba]) by smtp.gmail.com with ESMTPSA id u15sm4451348pfm.61.2020.10.07.15.58.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Oct 2020 15:58:41 -0700 (PDT) To: gcc-patches@gcc.gnu.org Subject: [PATCH 4/8] [RS6000] rs6000_rtx_costs tidy break/return Date: Thu, 8 Oct 2020 09:27:56 +1030 Message-Id: <20201007225800.9536-5-amodra@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20201007225800.9536-1-amodra@gmail.com> References: <20201007225800.9536-1-amodra@gmail.com> X-Spam-Status: No, score=-10.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Alan Modra via Gcc-patches From: Alan Modra Reply-To: Alan Modra Cc: segher@kernel.crashing.org Errors-To: gcc-patches-bounces@gcc.gnu.org Sender: "Gcc-patches" Most cases use "return false" rather than breaking out of the switch. Do so in all cases. * config/rs6000/rs6000.c (rs6000_rtx_costs): Tidy break/return. diff --git a/gcc/config/rs6000/rs6000.c b/gcc/config/rs6000/rs6000.c index bc5e51aa5ce..383d2901c9f 100644 --- a/gcc/config/rs6000/rs6000.c +++ b/gcc/config/rs6000/rs6000.c @@ -21371,7 +21371,7 @@ rs6000_rtx_costs (rtx x, machine_mode mode, int outer_code, *total = rs6000_cost->fp; else *total = rs6000_cost->dmul; - break; + return false; case DIV: case MOD: @@ -21539,7 +21539,7 @@ rs6000_rtx_costs (rtx x, machine_mode mode, int outer_code, *total = rs6000_cost->fp; return false; } - break; + return false; case NE: case EQ: @@ -21577,13 +21577,11 @@ rs6000_rtx_costs (rtx x, machine_mode mode, int outer_code, *total = 0; return true; } - break; + return false; default: - break; + return false; } - - return false; } /* Debug form of r6000_rtx_costs that is selected if -mdebug=cost. */