Message ID | 20200413233901.2417-1-jcmvbkbc@gmail.com |
---|---|
State | New |
Headers | show |
Series | xtensa: fix PR target/94584 | expand |
On Mon, Apr 13, 2020 at 4:39 PM Max Filippov <jcmvbkbc@gmail.com> wrote: > 2020-04-13 Max Filippov <jcmvbkbc@gmail.com> > gcc/ > * config/xtensa/xtensa.md (zero_extendhisi2, zero_extendqisi2) > (extendhisi2_internal): Add %v1 before the load instructions. > > gcc/testsuite/ > * gcc.target/xtensa/pr94584.c: New test. Approved. Surprised this hasn't been caught before.
On Tue, Apr 14, 2020 at 4:40 PM augustine.sterling@gmail.com <augustine.sterling@gmail.com> wrote: > > On Mon, Apr 13, 2020 at 4:39 PM Max Filippov <jcmvbkbc@gmail.com> wrote: > > 2020-04-13 Max Filippov <jcmvbkbc@gmail.com> > > gcc/ > > * config/xtensa/xtensa.md (zero_extendhisi2, zero_extendqisi2) > > (extendhisi2_internal): Add %v1 before the load instructions. > > > > gcc/testsuite/ > > * gcc.target/xtensa/pr94584.c: New test. > > Approved. Surprised this hasn't been caught before. Thanks. Applied to master. I'll apply it later to gcc-8 and gcc-9 branches. I believe that we don't have use cases in linux that rely on memw associated with volatile memory access, so it's nice to have non-linux user with different requirements.
diff --git a/gcc/config/xtensa/xtensa.md b/gcc/config/xtensa/xtensa.md index 5b803d3cbe65..749fe477d562 100644 --- a/gcc/config/xtensa/xtensa.md +++ b/gcc/config/xtensa/xtensa.md @@ -538,7 +538,7 @@ "" "@ extui\t%0, %1, 0, 16 - l16ui\t%0, %1" + %v1l16ui\t%0, %1" [(set_attr "type" "arith,load") (set_attr "mode" "SI") (set_attr "length" "3,3")]) @@ -549,7 +549,7 @@ "" "@ extui\t%0, %1, 0, 8 - l8ui\t%0, %1" + %v1l8ui\t%0, %1" [(set_attr "type" "arith,load") (set_attr "mode" "SI") (set_attr "length" "3,3")]) @@ -575,7 +575,7 @@ "" "@ sext\t%0, %1, 15 - l16si\t%0, %1" + %v1l16si\t%0, %1" [(set_attr "type" "arith,load") (set_attr "mode" "SI") (set_attr "length" "3,3")]) diff --git a/gcc/testsuite/gcc.target/xtensa/pr94584.c b/gcc/testsuite/gcc.target/xtensa/pr94584.c new file mode 100644 index 000000000000..1577285b8a68 --- /dev/null +++ b/gcc/testsuite/gcc.target/xtensa/pr94584.c @@ -0,0 +1,24 @@ +/* { dg-do compile } */ +/* { dg-options "-O2 -mserialize-volatile" } */ + +unsigned long load32 (volatile unsigned long *s) +{ + return *s; +} + +short load16s (volatile short *s) +{ + return *s; +} + +unsigned short load16u (volatile unsigned short *s) +{ + return *s; +} + +unsigned char load8 (volatile unsigned char *s) +{ + return *s; +} + +/* { dg-final { scan-assembler-times "memw" 4 } } */