From patchwork Thu Apr 2 18:53:44 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Li, Pan2 via Gcc-patches" X-Patchwork-Id: 1265716 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=8.43.85.97; helo=sourceware.org; envelope-from=gcc-patches-bounces@gcc.gnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=gcc.gnu.org Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.a=rsa-sha256 header.s=default header.b=Gew2Tutv; dkim-atps=neutral Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 48tXKd1HRvz9sPF for ; Fri, 3 Apr 2020 05:54:13 +1100 (AEDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 6AF57388B814; Thu, 2 Apr 2020 18:54:01 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 6AF57388B814 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1585853641; bh=kYn62LBRNO4FYyW7otSzAuGJGgDzQcHJD0+XI7qGhpM=; h=To:Subject:Date:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=Gew2TutvTXuRYJxc4W6HX0UN8qRsAn4L+DbCbjmOI8KUeZzmwE+YNZZdJLg6vmXet S4ep1Abs+NbgFZige5DyQTSg4VCiWB3EctlHnbODV/Rk2QSMRkpRsHvt8RoJDXQqjc fw1p6Kk9AGjdI5RpzUGjtvC3fWiBdtccT2Dzl5CU= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mail-pl1-x643.google.com (mail-pl1-x643.google.com [IPv6:2607:f8b0:4864:20::643]) by sourceware.org (Postfix) with ESMTPS id 469B2388B807 for ; Thu, 2 Apr 2020 18:53:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 469B2388B807 Received: by mail-pl1-x643.google.com with SMTP id x1so1686564plm.4 for ; Thu, 02 Apr 2020 11:53:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=kYn62LBRNO4FYyW7otSzAuGJGgDzQcHJD0+XI7qGhpM=; b=cmWeP+aIiRto6lhc3JxoLWk2iAByPOEUbSgiU5MerSLk9jssotNzUj3XTnvowC5SEp yGLwoNwZcIWgIs5858WPxgIg02NFMy607+J27iSJ6daLnPrKSzy65p0q1IeQaQ/ll5Nk 0yyU+DNjmvSHwKELtl2sDWLRBMiTxTcZNh15zBiqITSQlLRCjHfrcXy0FktohFWuZc9G de20UggR0YemJHyhEN1vvVavormBZ1v/cz7+itXWJjftjOsgwh7RUmKaPDjZBoXlRQ1D bjWv3YW/zEcsGUtPTY0ugeckzPww+ZIysslRcNVXP2IjU+A7M9dQ4ZIkFjmsl55C9adR hM0w== X-Gm-Message-State: AGi0PuZZ3iCl5uy5uHPTu5pf+BjevvunlrMuOBabL8NkqNnp1Mr/Qtlx G09I9+VtIaARftc3MzYobgji8drMhtk= X-Google-Smtp-Source: APiQypJm+5E6BYyPqzPQnkkEeqrC4jgxwdR21ursJbNON7yuDNZlJxYkvFC8MwIpHPQ1ChCicB5nDg== X-Received: by 2002:a17:90a:a889:: with SMTP id h9mr5322532pjq.40.1585853637969; Thu, 02 Apr 2020 11:53:57 -0700 (PDT) Received: from localhost.localdomain (174-21-149-226.tukw.qwest.net. [174.21.149.226]) by smtp.gmail.com with ESMTPSA id r64sm4216973pjb.15.2020.04.02.11.53.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Apr 2020 11:53:57 -0700 (PDT) To: gcc-patches@gcc.gnu.org Subject: [PATCH v2 02/11] aarch64: Accept zeros in add3_carryin Date: Thu, 2 Apr 2020 11:53:44 -0700 Message-Id: <20200402185353.11047-3-richard.henderson@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200402185353.11047-1-richard.henderson@linaro.org> References: <20200402185353.11047-1-richard.henderson@linaro.org> MIME-Version: 1.0 X-Spam-Status: No, score=-19.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Richard Henderson via Gcc-patches From: "Li, Pan2 via Gcc-patches" Reply-To: Richard Henderson Cc: richard.earnshaw@arm.com, segher@kernel.crashing.org, Wilco.Dijkstra@arm.com, marcus.shawcroft@arm.com Errors-To: gcc-patches-bounces@gcc.gnu.org Sender: "Gcc-patches" The expander and the insn pattern did not match, leading to recognition failures in expand. * config/aarch64/aarch64.md (*add3_carryin): Accept zeros. --- gcc/config/aarch64/aarch64.md | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/gcc/config/aarch64/aarch64.md b/gcc/config/aarch64/aarch64.md index 6fdab5f3402..b242f2b1c73 100644 --- a/gcc/config/aarch64/aarch64.md +++ b/gcc/config/aarch64/aarch64.md @@ -2606,16 +2606,17 @@ "" ) -;; Note that add with carry with two zero inputs is matched by cset, -;; and that add with carry with one zero input is matched by cinc. +;; While add with carry with two zero inputs will be folded to cset, +;; and add with carry with one zero input will be folded to cinc, +;; accept the zeros during initial expansion. (define_insn "*add3_carryin" [(set (match_operand:GPI 0 "register_operand" "=r") (plus:GPI (plus:GPI (match_operand:GPI 3 "aarch64_carry_operation" "") - (match_operand:GPI 1 "register_operand" "r")) - (match_operand:GPI 2 "register_operand" "r")))] + (match_operand:GPI 1 "aarch64_reg_or_zero" "rZ")) + (match_operand:GPI 2 "aarch64_reg_or_zero" "rZ")))] "" "adc\\t%0, %1, %2" [(set_attr "type" "adc_reg")]