diff mbox series

[committed] d: Generate phony targets for content imported files (PR93038)

Message ID 20200322122642.26987-1-ibuclaw@gdcproject.org
State New
Headers show
Series [committed] d: Generate phony targets for content imported files (PR93038) | expand

Commit Message

Jeff Law via Gcc-patches March 22, 2020, 12:26 p.m. UTC
Hi,

This patch is an addition to the last change, which started including
content imported files in the make dependency list.  Now phony targets
are also written out if -MP is given.

Bootstrapped and regression tested on x86_64-linux-gnu.

Committed to trunk.

Regards
Iain.

---
gcc/d/ChangeLog:

2020-03-22  Iain Buclaw  <ibuclaw@gdcproject.org>

	PR d/93038
	* d-lang.cc (deps_write): Generate phony targets for content imported
	files.

gcc/testsuite/ChangeLog:

2020-03-22  Iain Buclaw  <ibuclaw@gdcproject.org>

	PR d/93038
	* gdc.dg/pr93038b.d: New test.

---
 gcc/d/d-lang.cc                 | 39 +++++++++++++++------------------
 gcc/testsuite/gdc.dg/pr93038b.d |  8 +++++++
 2 files changed, 26 insertions(+), 21 deletions(-)
 create mode 100644 gcc/testsuite/gdc.dg/pr93038b.d
diff mbox series

Patch

diff --git a/gcc/d/d-lang.cc b/gcc/d/d-lang.cc
index 514799d8e89..6848c5e9a1c 100644
--- a/gcc/d/d-lang.cc
+++ b/gcc/d/d-lang.cc
@@ -157,26 +157,21 @@  deps_write (Module *module, OutBuffer *buffer, unsigned colmax = 72)
   Modules modlist;
   modlist.push (module);
 
-  Modules phonylist;
-
-  const char *str;
-  unsigned size;
+  vec <const char *> phonylist = vNULL;
   unsigned column = 0;
 
   /* Write out make target module name.  */
   if (d_option.deps_target)
     {
-      size = d_option.deps_target->offset;
-      str = d_option.deps_target->extractString ();
+      buffer->writestring (d_option.deps_target->extractString ());
+      column = d_option.deps_target->offset;
     }
   else
     {
-      str = module->objfile->name->str;
-      size = strlen (str);
+      buffer->writestring (module->objfile->name->str);
+      column = buffer->offset;
     }
 
-  buffer->writestring (str);
-  column = size;
   buffer->writestring (":");
   column++;
 
@@ -185,21 +180,25 @@  deps_write (Module *module, OutBuffer *buffer, unsigned colmax = 72)
     {
       Module *depmod = modlist.pop ();
 
-      str = depmod->srcfile->name->str;
+      const char *modstr = depmod->srcfile->name->str;
 
       /* Skip modules that have already been looked at.  */
-      if (seen_modules.add (str))
+      if (seen_modules.add (modstr))
 	continue;
 
-      dependencies.safe_push (str);
+      dependencies.safe_push (modstr);
 
       /* Add to list of phony targets if is not being compile.  */
       if (d_option.deps_phony && !depmod->isRoot ())
-	phonylist.push (depmod);
+	phonylist.safe_push (modstr);
 
       /* Add imported files to dependency list.  */
       for (size_t i = 0; i < depmod->contentImportedFiles.dim; i++)
-	dependencies.safe_push (depmod->contentImportedFiles[i]);
+	{
+	  const char *impstr = depmod->contentImportedFiles[i];
+	  dependencies.safe_push (impstr);
+	  phonylist.safe_push (impstr);
+	}
 
       /* Search all imports of the module.  */
       for (size_t i = 0; i < depmod->aimports.dim; i++)
@@ -238,8 +237,8 @@  deps_write (Module *module, OutBuffer *buffer, unsigned colmax = 72)
   /* Write out all make dependencies.  */
   for (size_t i = 0; i < dependencies.length (); i++)
     {
-      str = dependencies[i];
-      size = strlen (str);
+      const char *str = dependencies[i];
+      unsigned size = strlen (str);
       column += size;
 
       if (colmax && column > colmax)
@@ -259,12 +258,10 @@  deps_write (Module *module, OutBuffer *buffer, unsigned colmax = 72)
   buffer->writenl ();
 
   /* Write out all phony targets.  */
-  for (size_t i = 0; i < phonylist.dim; i++)
+  for (size_t i = 0; i < phonylist.length (); i++)
     {
-      Module *m = phonylist[i];
-
       buffer->writenl ();
-      buffer->writestring (m->srcfile->name->str);
+      buffer->writestring (phonylist[i]);
       buffer->writestring (":\n");
     }
 }
diff --git a/gcc/testsuite/gdc.dg/pr93038b.d b/gcc/testsuite/gdc.dg/pr93038b.d
new file mode 100644
index 00000000000..04177a7e01a
--- /dev/null
+++ b/gcc/testsuite/gdc.dg/pr93038b.d
@@ -0,0 +1,8 @@ 
+// https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93038
+// { dg-options "-J $srcdir/gdc.dg/fileimports -MMD -MP" }
+// { dg-do compile }
+// { dg-final { scan-file pr93038b.deps "pr93038b.o: \[^\n\]*/pr93038b.d \[ \\\\\n\]*\[^\n\]*/fileimports/pr93038.txt\n\n\[^\n\]*/fileimports/pr93038.txt:" } }
+// { dg-final { file delete pr93038b.deps } }
+module pr93038b;
+
+const VERSION = import("pr93038.txt");