| Message ID | 20200118141204.GA15718@arm.com |
|---|---|
| State | New |
| Headers | show |
| Series | [committed,AArch64] Fix unused variable warning breaking bootstrap. | expand |
Tamar Christina <Tamar.Christina@arm.com> writes: > Hi All, > > This marks the parameter &fi as unused so it doesn't > cause a boostrap failure. > > Bootstrapped aarch64-none-linux-gnu. > > committed under the obvious rule. > > Thanks, > Tamar > > gcc/ChangeLog: > > 2020-01-18 Tamar Christina <tamar.christina@arm.com> > > * config/aarch64/aarch64-sve-builtins-base.cc (memory_vector_mode): > Mark parameter unused. Thanks for the quick fix. Sorry for indulging a personal preference, but for things like this, I think it's nicer to drop the parameter name rather than add ATTRIBUTE_UNUSED. That's the "style" used elsewhere in the file and also keeps the line length under 80 chars. Tested on aarch64-linux-gnu and applied. Richard 2020-01-20 Richard Sandiford <richard.sandiford@arm.com> gcc/ * config/aarch64/aarch64-sve-builtins-base.cc (svld1ro_impl::memory_vector_mode): Remove parameter name. --- gcc/config/aarch64/aarch64-sve-builtins-base.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gcc/config/aarch64/aarch64-sve-builtins-base.cc b/gcc/config/aarch64/aarch64-sve-builtins-base.cc index b48932f6a4f..26f0b8c6652 100644 --- a/gcc/config/aarch64/aarch64-sve-builtins-base.cc +++ b/gcc/config/aarch64/aarch64-sve-builtins-base.cc @@ -1206,7 +1206,7 @@ class svld1ro_impl : public load_replicate { public: machine_mode - memory_vector_mode (const function_instance &fi ATTRIBUTE_UNUSED) const OVERRIDE + memory_vector_mode (const function_instance &) const OVERRIDE { return OImode; }
Hi Richard, > > > > 2020-01-18 Tamar Christina <tamar.christina@arm.com> > > > > * config/aarch64/aarch64-sve-builtins-base.cc > (memory_vector_mode): > > Mark parameter unused. > > Thanks for the quick fix. > > Sorry for indulging a personal preference, but for things like this, I think it's > nicer to drop the parameter name rather than add ATTRIBUTE_UNUSED. > That's the "style" used elsewhere in the file and also keeps the line length > under 80 chars. Ah, I did not know this trick.. Thanks! Tamar. > > Tested on aarch64-linux-gnu and applied. > > Richard > > > 2020-01-20 Richard Sandiford <richard.sandiford@arm.com> > > gcc/ > * config/aarch64/aarch64-sve-builtins-base.cc > (svld1ro_impl::memory_vector_mode): Remove parameter name. > --- > gcc/config/aarch64/aarch64-sve-builtins-base.cc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/gcc/config/aarch64/aarch64-sve-builtins-base.cc > b/gcc/config/aarch64/aarch64-sve-builtins-base.cc > index b48932f6a4f..26f0b8c6652 100644 > --- a/gcc/config/aarch64/aarch64-sve-builtins-base.cc > +++ b/gcc/config/aarch64/aarch64-sve-builtins-base.cc > @@ -1206,7 +1206,7 @@ class svld1ro_impl : public load_replicate { > public: > machine_mode > - memory_vector_mode (const function_instance &fi ATTRIBUTE_UNUSED) > const OVERRIDE > + memory_vector_mode (const function_instance &) const OVERRIDE > { > return OImode; > }
diff --git a/gcc/config/aarch64/aarch64-sve-builtins-base.cc b/gcc/config/aarch64/aarch64-sve-builtins-base.cc index 868a6afaf2e77a77df8a97e2c874d52f5c0b7029..b48932f6a4fd265e1f5d0bd62d222c163857b63e 100644 --- a/gcc/config/aarch64/aarch64-sve-builtins-base.cc +++ b/gcc/config/aarch64/aarch64-sve-builtins-base.cc @@ -1206,7 +1206,7 @@ class svld1ro_impl : public load_replicate { public: machine_mode - memory_vector_mode (const function_instance &fi) const OVERRIDE + memory_vector_mode (const function_instance &fi ATTRIBUTE_UNUSED) const OVERRIDE { return OImode; }