From patchwork Fri Nov 15 08:08:38 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Xionghu Luo X-Patchwork-Id: 1195458 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=209.132.180.131; helo=sourceware.org; envelope-from=gcc-patches-return-513537-incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b="Em/qBlFT"; dkim-atps=neutral Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 47DrbT5KqHz9sP3 for ; Fri, 15 Nov 2019 19:09:09 +1100 (AEDT) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:cc:subject:date:in-reply-to:references:mime-version :content-transfer-encoding:message-id; q=dns; s=default; b=kiJW2 YqAxS7Kcf9Z9s24DPk0XRn3y9uD28E06YaKBYwOdJsRTK/Dq+3O7sPUyT+6Rha5w jL34OharHjtL1gUj07UwZQb4YQVA3c6baY3eIO7WFjHw3bnLf9uUhMCrRLvU0odb C7GGoNsJky4dcs5WaRlM69TOsPXOOrJOCPKdsQ= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:cc:subject:date:in-reply-to:references:mime-version :content-transfer-encoding:message-id; s=default; bh=4HdeN/OGUoP m5lrgy+M1XD/ZUeM=; b=Em/qBlFTRTzDdF9lCAmqmzH93Y/67KW2/gPQBsaMZtB giowB3I59fS4hxg6gQLv/G1sOpHTX9d58SciAcY/jqeZNPJELuOVUJ5Az9JmUFTN qMhT3VnTO98rRiK3Jwbl2k11DojscrOi/zkmb6Jq79XgY3ueXd2SAExvKjAU78Ro = Received: (qmail 33971 invoked by alias); 15 Nov 2019 08:08:52 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 33908 invoked by uid 89); 15 Nov 2019 08:08:52 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-27.4 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, KAM_SHORT, RCVD_IN_DNSWL_LOW, SPF_PASS autolearn=ham version=3.3.1 spammy= X-HELO: mx0a-001b2d01.pphosted.com Received: from mx0a-001b2d01.pphosted.com (HELO mx0a-001b2d01.pphosted.com) (148.163.156.1) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 15 Nov 2019 08:08:50 +0000 Received: from pps.filterd (m0187473.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id xAF86vBg187863 for ; Fri, 15 Nov 2019 03:08:48 -0500 Received: from e06smtp02.uk.ibm.com (e06smtp02.uk.ibm.com [195.75.94.98]) by mx0a-001b2d01.pphosted.com with ESMTP id 2w9ntb4p4v-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Fri, 15 Nov 2019 03:08:48 -0500 Received: from localhost by e06smtp02.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 15 Nov 2019 08:08:45 -0000 Received: from b06cxnps4075.portsmouth.uk.ibm.com (9.149.109.197) by e06smtp02.uk.ibm.com (192.168.101.132) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Fri, 15 Nov 2019 08:08:44 -0000 Received: from b06wcsmtp001.portsmouth.uk.ibm.com (b06wcsmtp001.portsmouth.uk.ibm.com [9.149.105.160]) by b06cxnps4075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id xAF88g7F30933038 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 15 Nov 2019 08:08:42 GMT Received: from b06wcsmtp001.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id C56C3A4054; Fri, 15 Nov 2019 08:08:42 +0000 (GMT) Received: from b06wcsmtp001.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id DBD93A405F; Fri, 15 Nov 2019 08:08:41 +0000 (GMT) Received: from genoa.aus.stglabs.ibm.com (unknown [9.40.192.157]) by b06wcsmtp001.portsmouth.uk.ibm.com (Postfix) with ESMTP; Fri, 15 Nov 2019 08:08:41 +0000 (GMT) From: Xiong Hu Luo To: gcc-patches@gcc.gnu.org Cc: segher@kernel.crashing.org, wschmidt@linux.ibm.com, luoxhu@linux.ibm.com, hubicka@ucw.cz Subject: [PATCH 2/2] Fix comments typo Date: Fri, 15 Nov 2019 02:08:38 -0600 In-Reply-To: <20191115080838.48090-1-luoxhu@linux.ibm.com> References: <20191115080838.48090-1-luoxhu@linux.ibm.com> MIME-Version: 1.0 x-cbid: 19111508-0008-0000-0000-0000032F3558 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 19111508-0009-0000-0000-00004A4E46DC Message-Id: <20191115080838.48090-2-luoxhu@linux.ibm.com> I'm going to install it as obvious. gcc/ChangeLog: 2019-11-15 Luo Xiong Hu * ipa-comdats.c: Fix comments typo. * ipa-profile.c: Fix comments typo. * tree-profile.c (gimple_gen_ic_profiler): Use the new variable __gcov_indirect_call.counters and __gcov_indirect_call.callee. (gimple_gen_ic_func_profiler): Likewise. (pass_ipa_tree_profile::gate): Fix comments typo. --- gcc/ipa-comdats.c | 2 +- gcc/ipa-profile.c | 2 +- gcc/tree-profile.c | 12 ++++++------ 3 files changed, 8 insertions(+), 8 deletions(-) diff --git a/gcc/ipa-comdats.c b/gcc/ipa-comdats.c index b496497ff66..0672d6d6575 100644 --- a/gcc/ipa-comdats.c +++ b/gcc/ipa-comdats.c @@ -18,7 +18,7 @@ along with GCC; see the file COPYING3. If not see . */ /* This is very simple pass that looks for static symbols that are used - exlusively by symbol within one comdat group. In this case it makes + exclusively by symbol within one comdat group. In this case it makes sense to bring the symbol itself into the group to avoid dead code that would arrise when the comdat group from current unit is replaced by a different copy. Consider for example: diff --git a/gcc/ipa-profile.c b/gcc/ipa-profile.c index 61fd5e86681..4b28b94aaad 100644 --- a/gcc/ipa-profile.c +++ b/gcc/ipa-profile.c @@ -563,7 +563,7 @@ ipa_profile (void) histogram.release (); histogram_pool.release (); - /* Produce speculative calls: we saved common traget from porfiling into + /* Produce speculative calls: we saved common target from porfiling into e->common_target_id. Now, at link time, we can look up corresponding function node and produce speculative call. */ diff --git a/gcc/tree-profile.c b/gcc/tree-profile.c index 6a4e62f5bae..b4435b9b2a8 100644 --- a/gcc/tree-profile.c +++ b/gcc/tree-profile.c @@ -73,8 +73,8 @@ static GTY(()) tree ic_tuple_callee_field; /* Do initialization work for the edge profiler. */ /* Add code: - __thread gcov* __gcov_indirect_call_counters; // pointer to actual counter - __thread void* __gcov_indirect_call_callee; // actual callee address + __thread gcov* __gcov_indirect_call.counters; // pointer to actual counter + __thread void* __gcov_indirect_call.callee; // actual callee address __thread int __gcov_function_counter; // time profiler function counter */ static void @@ -381,7 +381,7 @@ gimple_gen_ic_profiler (histogram_value value, unsigned tag) f_1 = foo; __gcov_indirect_call.counters = &__gcov4.main[0]; PROF_9 = f_1; - __gcov_indirect_call_callee = PROF_9; + __gcov_indirect_call.callee = PROF_9; _4 = f_1 (); */ @@ -444,11 +444,11 @@ gimple_gen_ic_func_profiler (void) /* Insert code: - if (__gcov_indirect_call_callee != NULL) + if (__gcov_indirect_call.callee != NULL) __gcov_indirect_call_profiler_v3 (profile_id, ¤t_function_decl); The function __gcov_indirect_call_profiler_v3 is responsible for - resetting __gcov_indirect_call_callee to NULL. */ + resetting __gcov_indirect_call.callee to NULL. */ gimple_stmt_iterator gsi = gsi_start_bb (cond_bb); void0 = build_int_cst (ptr_type_node, 0); @@ -890,7 +890,7 @@ pass_ipa_tree_profile::gate (function *) { /* When profile instrumentation, use or test coverage shall be performed. But for AutoFDO, this there is no instrumentation, thus this pass is - diabled. */ + disabled. */ return (!in_lto_p && !flag_auto_profile && (flag_branch_probabilities || flag_test_coverage || profile_arc_flag));