From patchwork Mon Aug 12 09:02:51 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pierre-Marie de Rodat X-Patchwork-Id: 1145580 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=gcc.gnu.org (client-ip=209.132.180.131; helo=sourceware.org; envelope-from=gcc-patches-return-506674-incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=adacore.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b="cpT3ucd8"; dkim-atps=neutral Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 466Vbh6DFqz9sN1 for ; Mon, 12 Aug 2019 19:17:04 +1000 (AEST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:cc:subject:message-id:mime-version:content-type; q=dns; s=default; b=Kk6eSwPBbaCMx1wZ6UXny7Ukw35oYizv1CLkEeu5HVSpdw88KG BVDE6xkvD0V5G6cij/62p8KTuwPKX7t9Mw+qLJ3ikZG1TYIR4OT3IUp/OwARDnjn +Lb1OW3Tsv2A2GSHVSFewX51ZHngrlkBGg0kjjEBQFfs7CvfwLiPT2bjw= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:cc:subject:message-id:mime-version:content-type; s= default; bh=niioCdn8g3v59+gl6STxIHvSAVM=; b=cpT3ucd89lnFthmPJbGR SDlZ+/l8fJHf0g46qJocP1H6xJFwPe2sLRl/jmiFavv5w0+tOivdmntqlO6bloFU VHYQvUAoc0z2BU/Y+B3ErzXZxw0981W8TGFsnlxnVlHt3yDxMfU3VMlamxsgJ2fL BxS2aMqbEbMUBdClk1bFrFU= Received: (qmail 116386 invoked by alias); 12 Aug 2019 09:10:33 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 50307 invoked by uid 89); 12 Aug 2019 09:03:05 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-10.6 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_2, GIT_PATCH_3, SPF_NEUTRAL autolearn=ham version=3.3.1 spammy= X-HELO: eggs.gnu.org Received: from eggs.gnu.org (HELO eggs.gnu.org) (209.51.188.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 12 Aug 2019 09:03:03 +0000 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hx6EB-0005uT-2C for gcc-patches@gcc.gnu.org; Mon, 12 Aug 2019 05:02:56 -0400 Received: from rock.gnat.com ([2620:20:4000:0:a9e:1ff:fe9b:1d1]:33505) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hx6EA-0005tH-Qr for gcc-patches@gcc.gnu.org; Mon, 12 Aug 2019 05:02:54 -0400 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 204E61164E8; Mon, 12 Aug 2019 05:02:53 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id EaTpg+k+kC98; Mon, 12 Aug 2019 05:02:53 -0400 (EDT) Received: from tron.gnat.com (tron.gnat.com [205.232.38.10]) by rock.gnat.com (Postfix) with ESMTP id BBADD560CB; Mon, 12 Aug 2019 05:02:51 -0400 (EDT) Received: by tron.gnat.com (Postfix, from userid 4862) id BA7F16AF; Mon, 12 Aug 2019 05:02:51 -0400 (EDT) Date: Mon, 12 Aug 2019 05:02:51 -0400 From: Pierre-Marie de Rodat To: gcc-patches@gcc.gnu.org Cc: Bob Duff Subject: [Ada] Prevent crash in Is_Reachable Message-ID: <20190812090251.GA22670@adacore.com> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.23 (2014-03-12) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 2620:20:4000:0:a9e:1ff:fe9b:1d1 X-IsSubscribed: yes This patch fixes a bug in Is_Reachable, which causes a crash when checks are on. Tested on x86_64-pc-linux-gnu, committed on trunk 2019-08-12 Bob Duff gcc/ada/ * libgnat/a-cbmutr.adb (Is_Reachable): Declare Idx to be of the base subtype. Clearly it makes no sense to loop "while Idx >= 0", if Idx is of a nonnegative subtype. --- gcc/ada/libgnat/a-cbmutr.adb +++ gcc/ada/libgnat/a-cbmutr.adb @@ -1767,10 +1767,8 @@ package body Ada.Containers.Bounded_Multiway_Trees is (Container : Tree; From, To : Count_Type) return Boolean is - Idx : Count_Type; - + Idx : Count_Type'Base := From; begin - Idx := From; while Idx >= 0 loop if Idx = To then return True;