Message ID | 20190207164003.meficlxbkcx5zkcl@kam.mff.cuni.cz |
---|---|
State | New |
Headers | show |
Series | Xfail gfortran.dg/pr79966.f90 | expand |
Hi Honza, > PR ipa/88711 > * gfortran.dg/pr79966.f90: Xfail for time being. > Index: ../../gcc/testsuite/gfortran.dg/pr79966.f90 > =================================================================== > --- ../../gcc/testsuite/gfortran.dg/pr79966.f90 (revision 268579) > +++ ../../gcc/testsuite/gfortran.dg/pr79966.f90 (working copy) > @@ -108,5 +108,5 @@ contains > > call RunTPTests() > end program > - > -! { dg-final { scan-ipa-dump "Inlined tp_sum/\[0-9\]+ into runtptests/\[0-9\]+" "inline" } } > +! See PR88711. Inliner is currently not able to figure out that inlining tp_sum is a good idea. > +! { dg-final { scan-ipa-dump "Inlined tp_sum/\[0-9\]+ into runtptests/\[0-9\]+" "inline" { xfail spu-*-* } } } why restrict the xfail to spu only? According to gcc-testresults, the test currently fails everywhere (aarch64, arm*, hppa*, i?86, ia64, m68k, powerpc*, riscv64, sparc*, x86_64). Rainer
On Thu, 7 Feb 2019, Rainer Orth wrote: > Hi Honza, > > > PR ipa/88711 > > * gfortran.dg/pr79966.f90: Xfail for time being. > > Index: ../../gcc/testsuite/gfortran.dg/pr79966.f90 > > =================================================================== > > --- ../../gcc/testsuite/gfortran.dg/pr79966.f90 (revision 268579) > > +++ ../../gcc/testsuite/gfortran.dg/pr79966.f90 (working copy) > > @@ -108,5 +108,5 @@ contains > > > > call RunTPTests() > > end program > > - > > -! { dg-final { scan-ipa-dump "Inlined tp_sum/\[0-9\]+ into runtptests/\[0-9\]+" "inline" } } > > +! See PR88711. Inliner is currently not able to figure out that inlining tp_sum is a good idea. > > +! { dg-final { scan-ipa-dump "Inlined tp_sum/\[0-9\]+ into runtptests/\[0-9\]+" "inline" { xfail spu-*-* } } } > > why restrict the xfail to spu only? According to gcc-testresults, the > test currently fails everywhere (aarch64, arm*, hppa*, i?86, ia64, m68k, > powerpc*, riscv64, sparc*, x86_64). OK if you xfail unconditionally on *-*-* Richard.
Index: ../../gcc/testsuite/gfortran.dg/pr79966.f90 =================================================================== --- ../../gcc/testsuite/gfortran.dg/pr79966.f90 (revision 268579) +++ ../../gcc/testsuite/gfortran.dg/pr79966.f90 (working copy) @@ -108,5 +108,5 @@ contains call RunTPTests() end program - -! { dg-final { scan-ipa-dump "Inlined tp_sum/\[0-9\]+ into runtptests/\[0-9\]+" "inline" } } +! See PR88711. Inliner is currently not able to figure out that inlining tp_sum is a good idea. +! { dg-final { scan-ipa-dump "Inlined tp_sum/\[0-9\]+ into runtptests/\[0-9\]+" "inline" { xfail spu-*-* } } }