diff mbox series

Read avx512vl-vfixupimms*-2.c testcases (PR target/88489)

Message ID 20190117130315.GH30353@tucnak
State New
Headers show
Series Read avx512vl-vfixupimms*-2.c testcases (PR target/88489) | expand

Commit Message

Jakub Jelinek Jan. 17, 2019, 1:03 p.m. UTC 
On Wed, Jan 16, 2019 at 07:12:56PM +0800, Wei Xiao wrote:
> > > Yes, but please test the compiler after the revert. Please also create
> > > a runtime testcase out of the testcase in the PR.
> Yes, we have tested it but current runtime testcase can't cover the corner
> case to expose the incorrectness of SDM. We will add some after the revert.
> 
> > For r267160, I'd expect you want to revert just the config/i386/ part and
> > keep the testcases, they should work even with the changes reverted, right?
> >
> The testcase part also need to be reverted since we have changed them
> according to the incorrect intrinsic list in SDM.

I don't really understand this.

The testcases succeed just fine for me in the current trunk with all the
reversions and test something the current state of the testsuite doesn't
check normally, in particular that the testcases run correctly even when
-mavx512vl is used.  As that misbehaved in the past, we should make sure we
don't break that again.

Uros, is it ok to reapply this to current trunk?

2019-01-17  Jakub Jelinek  <jakub@redhat.com>

	Reapply:
	2018-12-15  Jakub Jelinek  <jakub@redhat.com>

	PR target/88489
	* gcc.target/i386/avx512vl-vfixupimmsd-2.c: New test.
	* gcc.target/i386/avx512vl-vfixupimmss-2.c: New test.



	Jakub

Comments

Wei Xiao Jan. 18, 2019, 2:42 a.m. UTC | #1 
> > > For r267160, I'd expect you want to revert just the config/i386/ part and
> > > keep the testcases, they should work even with the changes reverted, right?
> > >
> > The testcase part also need to be reverted since we have changed them
> > according to the incorrect intrinsic list in SDM.
>
> I don't really understand this.
>
> The testcases succeed just fine for me in the current trunk with all the
> reversions and test something the current state of the testsuite doesn't
> check normally, in particular that the testcases run correctly even when
> -mavx512vl is used.  As that misbehaved in the past, we should make sure we
> don't break that again.
>

You're right. The testcases need to be kept to prevent regression.

> Uros, is it ok to reapply this to current trunk?
Uros Bizjak Jan. 18, 2019, 7:54 a.m. UTC | #2 
On Fri, Jan 18, 2019 at 3:42 AM Wei Xiao <wei.william.xiao@gmail.com> wrote:
>
> > > > For r267160, I'd expect you want to revert just the config/i386/ part and
> > > > keep the testcases, they should work even with the changes reverted, right?
> > > >
> > > The testcase part also need to be reverted since we have changed them
> > > according to the incorrect intrinsic list in SDM.
> >
> > I don't really understand this.
> >
> > The testcases succeed just fine for me in the current trunk with all the
> > reversions and test something the current state of the testsuite doesn't
> > check normally, in particular that the testcases run correctly even when
> > -mavx512vl is used.  As that misbehaved in the past, we should make sure we
> > don't break that again.
> >
>
> You're right. The testcases need to be kept to prevent regression.
>
> > Uros, is it ok to reapply this to current trunk?

Yes, please reapply the tests.

Thanks,
Uros.
diff mbox series

Patch

--- gcc/testsuite/gcc.target/i386/avx512vl-vfixupimmsd-2.c	(nonexistent)
+++ gcc/testsuite/gcc.target/i386/avx512vl-vfixupimmsd-2.c	(revision 268010)
@@ -0,0 +1,20 @@ 
+/* { dg-do run } */
+/* { dg-options "-mavx512vl -O2 -std=gnu99" } */
+/* { dg-require-effective-target avx512vl } */
+/* { dg-require-effective-target c99_runtime } */
+
+#define AVX512VL
+#define AVX512F_LEN 512
+#define AVX512F_LEN_HALF 256
+#include "avx512f-vfixupimmsd-2.c"
+
+static void
+test_256 (void)
+{
+  test_512 ();
+}
+
+static void
+test_128 (void)
+{
+}
--- gcc/testsuite/gcc.target/i386/avx512vl-vfixupimmss-2.c	(nonexistent)
+++ gcc/testsuite/gcc.target/i386/avx512vl-vfixupimmss-2.c	(revision 268010)
@@ -0,0 +1,20 @@ 
+/* { dg-do run } */
+/* { dg-options "-mavx512vl -O2 -std=gnu99" } */
+/* { dg-require-effective-target avx512vl } */
+/* { dg-require-effective-target c99_runtime } */
+
+#define AVX512VL
+#define AVX512F_LEN 512
+#define AVX512F_LEN_HALF 256
+#include "avx512f-vfixupimmss-2.c"
+
+static void
+test_256 (void)
+{
+  test_512 ();
+}
+
+static void
+test_128 (void)
+{
+}