| Message ID | 20181204121113.GI12380@tucnak |
|---|---|
| State | New |
| Headers | show |
| Series | Fix predict-22.c testcase (PR tree-optimization/88285) | expand |
On Tue, 4 Dec 2018, Jakub Jelinek wrote: > Hi! > > All uses of explicit -freorder-blocks-and-partition needs to be guarded with > freorder effective targets, e.g. arm doesn't support -fprofile-use. > > That said, until PR88310 is fixed, this effectively means the test is > UNSUPPORTED anywhere. > > Ok for trunk anyway? OK. > 2018-12-04 Jakub Jelinek <jakub@redhat.com> > > PR tree-optimization/88285 > * gcc.dg/predict-22.c: Only compile on freorder targets. > > --- gcc/testsuite/gcc.dg/predict-22.c.jj 2018-12-02 13:33:16.616161656 +0100 > +++ gcc/testsuite/gcc.dg/predict-22.c 2018-12-04 13:05:34.455226623 +0100 > @@ -1,4 +1,4 @@ > -/* { dg-do compile } */ > +/* { dg-do compile { target freorder } } */ > /* { dg-options "-O2 -fdump-tree-optimized-details-blocks -fdump-rtl-bbpart-details-blocks -freorder-blocks-and-partition" } */ > volatile int v; > void bar (void) __attribute__((leaf, cold)); > > Jakub > >
On 12/4/18 5:11 AM, Jakub Jelinek wrote: > Hi! > > All uses of explicit -freorder-blocks-and-partition needs to be guarded with > freorder effective targets, e.g. arm doesn't support -fprofile-use. > > That said, until PR88310 is fixed, this effectively means the test is > UNSUPPORTED anywhere. > > Ok for trunk anyway? > > 2018-12-04 Jakub Jelinek <jakub@redhat.com> > > PR tree-optimization/88285 > * gcc.dg/predict-22.c: Only compile on freorder targets. OK jeff
--- gcc/testsuite/gcc.dg/predict-22.c.jj 2018-12-02 13:33:16.616161656 +0100 +++ gcc/testsuite/gcc.dg/predict-22.c 2018-12-04 13:05:34.455226623 +0100 @@ -1,4 +1,4 @@ -/* { dg-do compile } */ +/* { dg-do compile { target freorder } } */ /* { dg-options "-O2 -fdump-tree-optimized-details-blocks -fdump-rtl-bbpart-details-blocks -freorder-blocks-and-partition" } */ volatile int v; void bar (void) __attribute__((leaf, cold));