diff mbox series

target/58397: add host_hooks for NetBSD to make precompiled headers work

Message ID 20181125201334.GA12807@SDF.ORG
State New
Headers show
Series target/58397: add host_hooks for NetBSD to make precompiled headers work | expand

Commit Message

Maya Rashish Nov. 25, 2018, 8:13 p.m. UTC
---
 gcc/config.host          |  4 ++
 gcc/config/host-netbsd.c | 85 ++++++++++++++++++++++++++++++++++++++++
 gcc/config/x-netbsd      |  4 ++
 3 files changed, 93 insertions(+)
 create mode 100644 gcc/config/host-netbsd.c
 create mode 100644 gcc/config/x-netbsd

Comments

Krister Walfridsson Nov. 25, 2018, 10:44 p.m. UTC | #1
On Sun, 25 Nov 2018, Maya Rashish wrote:

> gcc/config.host          |  4 ++
> gcc/config/host-netbsd.c | 85 ++++++++++++++++++++++++++++++++++++++++
> gcc/config/x-netbsd      |  4 ++
> 3 files changed, 93 insertions(+)
> create mode 100644 gcc/config/host-netbsd.c
> create mode 100644 gcc/config/x-netbsd

I started a new job a wile back, and my paper work is currently not in 
order. So I do not think I am allowed to approve patches now... :(

    /Krister
Jeff Law Nov. 26, 2018, 9:21 p.m. UTC | #2
On 11/25/18 1:13 PM, Maya Rashish wrote:
> ---
>  gcc/config.host          |  4 ++
>  gcc/config/host-netbsd.c | 85 ++++++++++++++++++++++++++++++++++++++++
>  gcc/config/x-netbsd      |  4 ++
>  3 files changed, 93 insertions(+)
>  create mode 100644 gcc/config/host-netbsd.c
>  create mode 100644 gcc/config/x-netbsd
THanks.  I constructed a ChangeLog entry and committed this patch to the
trunk.

jeff
Hans-Peter Nilsson Nov. 27, 2018, 10 p.m. UTC | #3
Hej!

On Sun, 25 Nov 2018, Krister Walfridsson wrote:
> On Sun, 25 Nov 2018, Maya Rashish wrote:
>
> > gcc/config.host          |  4 ++
> > gcc/config/host-netbsd.c | 85 ++++++++++++++++++++++++++++++++++++++++
> > gcc/config/x-netbsd      |  4 ++
> > 3 files changed, 93 insertions(+)
> > create mode 100644 gcc/config/host-netbsd.c
> > create mode 100644 gcc/config/x-netbsd
>
> I started a new job a wile back, and my paper work is currently not in order.
> So I do not think I am allowed to approve patches now... :(

Ackchyually...

You're right to be cautious about these matters of course, but
to avoid this leading to any kind of precedent, I'll just say
that in my book approving != submitting or committing.

IOW, I wouldn't hesitate to (only) *review* and *approve*
patches that are otherwise in good standing regarding paperwork
(though I don't know if that's the case here), if I had changed
jobs thereby voiding my filed FSF paperwork.

brgds, H-P
diff mbox series

Patch

diff --git a/gcc/config.host b/gcc/config.host
index c65569da2..970d4d549 100644
--- a/gcc/config.host
+++ b/gcc/config.host
@@ -282,6 +282,10 @@  case ${host} in
     out_host_hook_obj=host-openbsd.o
     host_xmake_file="${host_xmake_file} x-openbsd"
     ;;
+  *-*-netbsd*)
+    out_host_hook_obj=host-netbsd.o
+    host_xmake_file="${host_xmake_file} x-netbsd"
+    ;;
   ia64-*-hpux*)
     use_long_long_for_widest_fast_int=yes
     out_host_hook_obj=host-hpux.o
diff --git a/gcc/config/host-netbsd.c b/gcc/config/host-netbsd.c
new file mode 100644
index 000000000..fbd51e39b
--- /dev/null
+++ b/gcc/config/host-netbsd.c
@@ -0,0 +1,85 @@ 
+/* NetBSD host-specific hook definitions.
+   Copyright (C) 2004-2018 Free Software Foundation, Inc.
+
+   This file is part of GCC.
+
+   GCC is free software; you can redistribute it and/or modify it
+   under the terms of the GNU General Public License as published
+   by the Free Software Foundation; either version 3, or (at your
+   option) any later version.
+
+   GCC is distributed in the hope that it will be useful, but WITHOUT
+   ANY WARRANTY; without even the implied warranty of MERCHANTABILITY
+   or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public
+   License for more details.
+
+   You should have received a copy of the GNU General Public License
+   along with GCC; see the file COPYING3.  If not see
+   <http://www.gnu.org/licenses/>.  */
+
+#include "config.h"
+#include "system.h"
+#include "coretypes.h"
+#include "hosthooks.h"
+#include "hosthooks-def.h"
+
+
+#undef HOST_HOOKS_GT_PCH_GET_ADDRESS
+#define HOST_HOOKS_GT_PCH_GET_ADDRESS netbsd_gt_pch_get_address
+#undef HOST_HOOKS_GT_PCH_USE_ADDRESS
+#define HOST_HOOKS_GT_PCH_USE_ADDRESS netbsd_gt_pch_use_address
+
+/* For various ports, try to guess a fixed spot in the vm space
+   that's probably free.  */
+#if defined(__sparc64__)
+# define TRY_EMPTY_VM_SPACE	0x40000000000
+#elif defined(_LP64)
+# define TRY_EMPTY_VM_SPACE	0x400000000000
+#elif defined(__mips__) || defined(__vax__) || defined (__arm__)
+# define TRY_EMPTY_VM_SPACE	0x60000000
+#else
+# define TRY_EMPTY_VM_SPACE	0xb0000000
+#endif
+
+/* Determine a location where we might be able to reliably allocate
+   SIZE bytes.  FD is the PCH file, though we should return with the
+   file unmapped.  */
+
+static void *
+netbsd_gt_pch_get_address (size_t size, int fd)
+{
+  void *addr;
+
+  addr = mmap ((void *) TRY_EMPTY_VM_SPACE, size, PROT_READ | PROT_WRITE,
+	       MAP_PRIVATE | MAP_FIXED, fd, 0);
+
+  /* If we failed the map, that means there's *no* free space.  */
+  if (addr == (void *) MAP_FAILED)
+    return NULL;
+  /* Unmap the area before returning.  */
+  munmap (addr, size);
+
+  return addr;
+}
+
+/* Map SIZE bytes of FD+OFFSET at BASE.  Return 1 if we succeeded at 
+   mapping the data at BASE, -1 if we couldn't.  */
+
+static int
+netbsd_gt_pch_use_address (void *base, size_t size, int fd, size_t offset)
+{
+  void *addr;
+
+  /* We're called with size == 0 if we're not planning to load a PCH
+     file at all.  This allows the hook to free any static space that
+     we might have allocated at link time.  */
+  if (size == 0)
+    return -1;
+
+  addr = mmap (base, size, PROT_READ | PROT_WRITE, MAP_PRIVATE | MAP_FIXED, fd, offset);
+
+  return addr == base ? 1 : -1;
+}
+
+
+const struct host_hooks host_hooks = HOST_HOOKS_INITIALIZER;
diff --git a/gcc/config/x-netbsd b/gcc/config/x-netbsd
new file mode 100644
index 000000000..beef74512
--- /dev/null
+++ b/gcc/config/x-netbsd
@@ -0,0 +1,4 @@ 
+host-netbsd.o : $(srcdir)/config/host-netbsd.c $(CONFIG_H) $(SYSTEM_H) \
+  coretypes.h hosthooks.h hosthooks-def.h $(HOOKS_H)
+	$(COMPILER) -c $(ALL_COMPILERFLAGS) $(ALL_CPPFLAGS) $(INCLUDES) \
+		$(srcdir)/config/host-netbsd.c