From patchwork Fri Jul 13 09:18:36 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom de Vries X-Patchwork-Id: 943374 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=gcc.gnu.org (client-ip=209.132.180.131; helo=sourceware.org; envelope-from=gcc-patches-return-481477-incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b="XOuka328"; dkim-atps=neutral Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 41RnKn4B2gz9s2M for ; Fri, 13 Jul 2018 19:18:37 +1000 (AEST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:cc:subject:message-id:mime-version:content-type; q=dns; s=default; b=XFORhavFLDvy8Y3VLomseRGjR0x0m9C/jJSlayVUwjCNQBKZjj JpDf8jaCHok0EorYUa4/BqMaeE9lpfbMWqaqp41Qhiao9rTfVvn/ZvOhmrlQXFid 2VPy94Ks7X+ypN3gTfhq7BilSQA+lMqjF3Ufd7+wrcfThfR/IzcghBXnA= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:cc:subject:message-id:mime-version:content-type; s= default; bh=3WKaCbMhvCudz88gynSaYyqWHho=; b=XOuka328NXD5r2rKNdMZ 2mVqL6c+JgYxmRnIRxWT3VgB4g9m622Qk44H6kzJS9ECnL1almu/HGOaFFj/7Q7I 1ncOcc26E6QhYAoQjTWVuo/YFBRzVeDgFsJWs4Ank6W5oAu65DQ9Hm7iUu6sYZo8 k7D3LM8hGtWAg++Ey8qAJFc= Received: (qmail 44250 invoked by alias); 13 Jul 2018 09:18:30 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 44238 invoked by uid 89); 13 Jul 2018 09:18:29 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.suse.de Received: from mx2.suse.de (HELO mx1.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 13 Jul 2018 09:18:28 +0000 Received: from relay1.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id B9A82AD60; Fri, 13 Jul 2018 09:18:26 +0000 (UTC) Date: Fri, 13 Jul 2018 11:18:36 +0200 From: Tom de Vries To: gcc-patches@gcc.gnu.org Cc: Jakub Jelinek , Martin Liska Subject: [PATCH][testsuite, guality] Add -fno-ipa-icf in gcc.dg/guality Message-ID: <20180713091835.7behph5r2z4gcek3@delia> MIME-Version: 1.0 Content-Disposition: inline User-Agent: NeoMutt/20170912 (1.9.0) X-IsSubscribed: yes Hi, Optimization fipa-icf breaks debug info (as is noted in PR63572 - "ICF breaks user debugging experience"), which make guality tests clztest.c, ctztest.c and sra-1.c unsupported for option combination "-O2 -flto -fuse-linker-plugin -fno-fat-lto-objects". F.i., in clztest.c foo and bar are merged, and gdb can set a breakpoint on a line in foo, but trying to set a breakpoint on a line in bar results in a breakpoint in main instead. This patch works around the problem by adding -fno-ipa-icf (as is already done in csttest.c and pr43077-1.c) to those testcases: ... -UNSUPPORTED: gcc.dg/guality/clztest.c ... line . g == f +PASS: gcc.dg/guality/clztest.c ... line . g == f -UNSUPPORTED: gcc.dg/guality/ctztest.c ... line . g == f +PASS: gcc.dg/guality/ctztest.c ... line . g == f -UNSUPPORTED: gcc.dg/guality/sra-1.c ... line .+1 a[0] == 4 +PASS: gcc.dg/guality/sra-1.c ... line .+1 a[0] == 4 -UNSUPPORTED: gcc.dg/guality/sra-1.c ... line . a[1] == 14 +PASS: gcc.dg/guality/sra-1.c ... line . a[1] == 14 ... Tested on x86_64. OK for trunk? Thanks, - Tom [testsuite, guality] Add -fno-ipa-icf in gcc.dg/guality 2018-07-13 Tom de Vries * gcc.dg/guality/clztest.c: Add -fno-ipa-icf in dg-options. * gcc.dg/guality/ctztest.c: Same. * gcc.dg/guality/sra-1.c: Same. --- gcc/testsuite/gcc.dg/guality/clztest.c | 2 +- gcc/testsuite/gcc.dg/guality/ctztest.c | 2 +- gcc/testsuite/gcc.dg/guality/sra-1.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/gcc/testsuite/gcc.dg/guality/clztest.c b/gcc/testsuite/gcc.dg/guality/clztest.c index f89c1c31a15..69527561c22 100644 --- a/gcc/testsuite/gcc.dg/guality/clztest.c +++ b/gcc/testsuite/gcc.dg/guality/clztest.c @@ -1,5 +1,5 @@ /* { dg-do run { target { { i?86-*-* x86_64-*-* } && lp64 } } } */ -/* { dg-options "-g" } */ +/* { dg-options "-g -fno-ipa-icf" } */ volatile int vv; diff --git a/gcc/testsuite/gcc.dg/guality/ctztest.c b/gcc/testsuite/gcc.dg/guality/ctztest.c index 5ce6c674be3..276752ac986 100644 --- a/gcc/testsuite/gcc.dg/guality/ctztest.c +++ b/gcc/testsuite/gcc.dg/guality/ctztest.c @@ -1,5 +1,5 @@ /* { dg-do run { target { { i?86-*-* x86_64-*-* } && lp64 } } } */ -/* { dg-options "-g" } */ +/* { dg-options "-g -fno-ipa-icf" } */ volatile int vv; diff --git a/gcc/testsuite/gcc.dg/guality/sra-1.c b/gcc/testsuite/gcc.dg/guality/sra-1.c index a747bc302aa..8ad57cf3f8e 100644 --- a/gcc/testsuite/gcc.dg/guality/sra-1.c +++ b/gcc/testsuite/gcc.dg/guality/sra-1.c @@ -1,6 +1,6 @@ /* PR debug/43983 */ /* { dg-do run } */ -/* { dg-options "-g" } */ +/* { dg-options "-g -fno-ipa-icf" } */ struct A { int i; int j; }; struct B { int : 4; int i : 12; int j : 12; int : 4; };