Message ID | 20180628225259.GH7166@tucnak |
---|---|
State | New |
Headers | show |
Series | Make sure rs6000-modes.h is installed in plugin/include/config/rs6000/ subdir | expand |
On 06/28/2018 04:52 PM, Jakub Jelinek wrote: > Hi! > > The newly added rs6000-modes.h is now included from rs6000.h, so it is > needed when building plugins that include tm.h, but it wasn't listed in the > Makefile fragments and therefore included among PLUGIN_HEADERS. > > Fixed thusly, tested on powerpc64le-linux, ok for trunk and 8.2? > > 2018-06-28 Jakub Jelinek <jakub@redhat.com> > > * config/rs6000/t-rs6000: Append rs6000-modes.h to TM_H. OK. jeff
On Fri, Jun 29, 2018 at 12:52:59AM +0200, Jakub Jelinek wrote: > Hi! > > The newly added rs6000-modes.h is now included from rs6000.h, so it is > needed when building plugins that include tm.h, but it wasn't listed in the > Makefile fragments and therefore included among PLUGIN_HEADERS. > > Fixed thusly, tested on powerpc64le-linux, ok for trunk and 8.2? > > 2018-06-28 Jakub Jelinek <jakub@redhat.com> > > * config/rs6000/t-rs6000: Append rs6000-modes.h to TM_H. Thanks for catching this.
Hi Jakub, On Fri, Jun 29, 2018 at 12:52:59AM +0200, Jakub Jelinek wrote: > The newly added rs6000-modes.h is now included from rs6000.h, so it is > needed when building plugins that include tm.h, but it wasn't listed in the > Makefile fragments and therefore included among PLUGIN_HEADERS. > > Fixed thusly, tested on powerpc64le-linux, ok for trunk and 8.2? Yes please. Thanks! Segher > 2018-06-28 Jakub Jelinek <jakub@redhat.com> > > * config/rs6000/t-rs6000: Append rs6000-modes.h to TM_H.
--- gcc/config/rs6000/t-rs6000.jj 2018-05-06 23:13:00.205627800 +0200 +++ gcc/config/rs6000/t-rs6000 2018-06-28 23:31:41.426185017 +0200 @@ -20,6 +20,7 @@ TM_H += $(srcdir)/config/rs6000/rs6000-builtin.def TM_H += $(srcdir)/config/rs6000/rs6000-cpus.def +TM_H += $(srcdir)/config/rs6000/rs6000-modes.h PASSES_EXTRA += $(srcdir)/config/rs6000/rs6000-passes.def rs6000-c.o: $(srcdir)/config/rs6000/rs6000-c.c