From patchwork Wed May 9 22:32:10 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Steve Kargl X-Patchwork-Id: 911210 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=gcc.gnu.org (client-ip=209.132.180.131; helo=sourceware.org; envelope-from=gcc-patches-return-477458-incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=troutmask.apl.washington.edu Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b="OzY7z5Iv"; dkim-atps=neutral Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 40hB2570jZz9s37 for ; Thu, 10 May 2018 08:32:45 +1000 (AEST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:subject:message-id:reply-to:mime-version:content-type; q=dns; s=default; b=AgBR7/YR4ZJ6ijiaXBh6V0BNujzZBkNQROAuiwblq4X KMGUEytpEzq45s3xonMhYaHDKbCIwdKQS82dxTkwLcGP5Iowq1iOZRLaxDhiKkIh d83Oz6FOboNEWyYtjzhLnLlsJYJCvgaQqxAiqb95N2DJHX8wqJU2Atj0Qw4xnPX0 = DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:subject:message-id:reply-to:mime-version:content-type; s=default; bh=e8JbNVpjJVnDpkCfdTPwjIOok5o=; b=OzY7z5IvAYXqqLseY QVNHYpWw+pubvKlSPL8ag7V0dun0kxUFEv5ftwhx6IvSO6imGeSX8hFYxi0mL1E2 HaYCeo+oFigSqxYGFglCi0gEGPxdfgTWyJdbbH1OeK3XUA1Ek4ABD0FSTnfb7whk GvMxiy7+AGCTz4DkeW61rexkko= Received: (qmail 69732 invoked by alias); 9 May 2018 22:32:25 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 69626 invoked by uid 89); 9 May 2018 22:32:13 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-9.4 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_2, GIT_PATCH_3, KAM_ASCII_DIVIDERS, KAM_LAZY_DOMAIN_SECURITY autolearn=ham version=3.3.2 spammy=H*c:HHx X-Spam-User: qpsmtpd, 2 recipients X-HELO: troutmask.apl.washington.edu Received: from troutmask.apl.washington.edu (HELO troutmask.apl.washington.edu) (128.95.76.21) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 09 May 2018 22:32:12 +0000 Received: from troutmask.apl.washington.edu (localhost [127.0.0.1]) by troutmask.apl.washington.edu (8.15.2/8.15.2) with ESMTPS id w49MWAlJ039289 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Wed, 9 May 2018 15:32:10 -0700 (PDT) (envelope-from sgk@troutmask.apl.washington.edu) Received: (from sgk@localhost) by troutmask.apl.washington.edu (8.15.2/8.15.2/Submit) id w49MWAbj039288; Wed, 9 May 2018 15:32:10 -0700 (PDT) (envelope-from sgk) Date: Wed, 9 May 2018 15:32:10 -0700 From: Steve Kargl To: fortran@gcc.gnu.org, gcc-patches@gcc.gnu.org Subject: [PATCH] PR fortran/70870 -- Reject data object with default initialization Message-ID: <20180509223210.GC46292@troutmask.apl.washington.edu> Reply-To: sgk@troutmask.apl.washington.edu MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.9.2 (2017-12-15) I plan to commit the attach patch on Saturday unless someone objects. 2018-05-09 Steven G. Kargl PR fortran/70870 * data.c (gfc_assign_data_value): Check that a data object does not also have default initialization. 2018-05-09 Steven G. Kargl PR fortran/70870 * gfortran.dg/pr70870_1.f90: New test. Index: gcc/fortran/data.c =================================================================== --- gcc/fortran/data.c (revision 260000) +++ gcc/fortran/data.c (working copy) @@ -491,6 +491,15 @@ gfc_assign_data_value (gfc_expr *lvalue, gfc_expr *rva } else { + if (lvalue->ts.type == BT_DERIVED + && gfc_has_default_initializer (lvalue->ts.u.derived)) + { + gfc_error ("Nonpointer object %qs with default initialization " + "shall not appear in a DATA statement at %L", + symbol->name, &lvalue->where); + return false; + } + /* Overwriting an existing initializer is non-standard but usually only provokes a warning from other compilers. */ if (init != NULL) Index: gcc/testsuite/gfortran.dg/pr70870_1.f90 =================================================================== --- gcc/testsuite/gfortran.dg/pr70870_1.f90 (nonexistent) +++ gcc/testsuite/gfortran.dg/pr70870_1.f90 (working copy) @@ -0,0 +1,9 @@ +! { dg-do compile } +! PR fortran/70870 +! Contributed by Vittorio Zecca + type t + integer :: g=0 ! default initialization + end type + type(t) :: v2 + data v2/t(2)/ ! { dg-error "default initialization shall not" } + end