diff mbox series

PR fortran/83939 -- Enforce F2018 C15100

Message ID 20180311204849.GB56613@troutmask.apl.washington.edu
State New
Headers show
Series PR fortran/83939 -- Enforce F2018 C15100 | expand

Commit Message

Steve Kargl March 11, 2018, 8:48 p.m. UTC 
The attach patch enforces F2018:C15100.  Similar constraints are
present in older versions of the standard.  The patch and testcase
are sufficiently explanatory.  Regression tested on x86_64-*-freebsd.
OK to commit?


2018-03-11  Steven G. Kargl  <kargl@gcc.gnu.org>

	PR fortran/83939
	* resolve.c (resolve_fl_procedure): Enforce F2018:C15100.
2018-03-11  Steven G. Kargl  <kargl@gcc.gnu.org>

	PR fortran/83939
	* gfortran.dg/pr83939.f90

Comments

Jerry DeLisle March 12, 2018, 2:04 a.m. UTC | #1 
On 03/11/2018 01:48 PM, Steve Kargl wrote:
> The attach patch enforces F2018:C15100.  Similar constraints are
> present in older versions of the standard.  The patch and testcase
> are sufficiently explanatory.  Regression tested on x86_64-*-freebsd.
> OK to commit?
> 

Looks OK Steve.

Jerry


> 
> 2018-03-11  Steven G. Kargl  <kargl@gcc.gnu.org>
> 
> 	PR fortran/83939
> 	* resolve.c (resolve_fl_procedure): Enforce F2018:C15100.
> 2018-03-11  Steven G. Kargl  <kargl@gcc.gnu.org>
> 
> 	PR fortran/83939
> 	* gfortran.dg/pr83939.f90
>
diff mbox series

Patch

Index: gcc/fortran/resolve.c
===================================================================
--- gcc/fortran/resolve.c	(revision 258433)
+++ gcc/fortran/resolve.c	(working copy)
@@ -12451,6 +12451,19 @@  resolve_fl_procedure (gfc_symbol *sym, int mp_flag)
 	}
     }
 
+  /* F2018, C15100: "The result of an elemental function shall be scalar,
+     and shall not have the POINTER or ALLOCATABLE attribute."  The scalar
+     pointer is tested and caught elsewhere.  */
+  if (sym->attr.elemental && sym->result
+      && (sym->result->attr.allocatable || sym->result->attr.pointer))
+    {
+      gfc_error ("Function result variable %qs at %L of elemental "
+		 "function %qs shall not have an ALLOCATABLE or POINTER "
+		 "attribute", sym->result->name,
+		 &sym->result->declared_at, sym->name);
+      return false;
+    }
+
   if (sym->attr.is_bind_c && sym->attr.is_c_interop != 1)
     {
       gfc_formal_arglist *curr_arg;
Index: gcc/testsuite/gfortran.dg/pr83939.f90
===================================================================
--- gcc/testsuite/gfortran.dg/pr83939.f90	(nonexistent)
+++ gcc/testsuite/gfortran.dg/pr83939.f90	(working copy)
@@ -0,0 +1,12 @@ 
+! { dg-do compile }
+elemental function f() result(s) ! { dg-error "shall not have an ALLOCATABLE or POINTER" }
+  allocatable s
+  allocate(s)
+  s = 3.5
+end function
+
+elemental function g() result(s) ! { dg-error "shall not have an ALLOCATABLE or POINTER" }
+  pointer s
+  allocate(s)
+  s = 3.5
+end function