| Message ID | 20180206210252.GA238786@intel.com |
|---|---|
| State | New |
| Headers | show |
| Series | Use -fcf-protection=return in cet-intrin-4.c | expand |
> -----Original Message----- > From: Lu, Hongjiu > Sent: Tuesday, February 6, 2018 10:03 PM > To: gcc-patches@gcc.gnu.org > Cc: Uros Bizjak <ubizjak@gmail.com>; Tsimbalist, Igor V > <igor.v.tsimbalist@intel.com> > Subject: [PATCH] Use -fcf-protection=return in cet-intrin-4.c > > Since -fcf-protection requires both -mshstk and -mibt, use > -fcf-protection=return with -mshstk in cet-intrin-4.c. > > OK for trunk? Ok from CET viewpoint. Igor > H.J. > -- > PR target/84243 > * gcc.target/i386/cet-intrin-4.c (dg-options): Use > -fcf-protection=return. > --- > gcc/testsuite/gcc.target/i386/cet-intrin-4.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/gcc/testsuite/gcc.target/i386/cet-intrin-4.c > b/gcc/testsuite/gcc.target/i386/cet-intrin-4.c > index 76ec160543f..437a4cd690c 100644 > --- a/gcc/testsuite/gcc.target/i386/cet-intrin-4.c > +++ b/gcc/testsuite/gcc.target/i386/cet-intrin-4.c > @@ -1,5 +1,5 @@ > /* { dg-do compile } */ > -/* { dg-options "-O -fcf-protection -mshstk" } */ > +/* { dg-options "-O -fcf-protection=return -mshstk" } */ > /* { dg-final { scan-assembler "rdsspd|incsspd\[ \t]+(%|)eax" { target ia32 } } } > */ > /* { dg-final { scan-assembler "rdssp\[dq]\[ \t]+(%|)\[re]ax" { target { ! ia32 } } > } } */ > /* { dg-final { scan-assembler "incssp\[dq]\[ \t]+(%|)\[re]di" { target { ! ia32 } } > } } */ > -- > 2.14.3
On Tue, Feb 6, 2018 at 10:14 PM, Tsimbalist, Igor V <igor.v.tsimbalist@intel.com> wrote: >> -----Original Message----- >> From: Lu, Hongjiu >> Sent: Tuesday, February 6, 2018 10:03 PM >> To: gcc-patches@gcc.gnu.org >> Cc: Uros Bizjak <ubizjak@gmail.com>; Tsimbalist, Igor V >> <igor.v.tsimbalist@intel.com> >> Subject: [PATCH] Use -fcf-protection=return in cet-intrin-4.c >> >> Since -fcf-protection requires both -mshstk and -mibt, use >> -fcf-protection=return with -mshstk in cet-intrin-4.c. >> >> OK for trunk? > > Ok from CET viewpoint. OK. Thanks, Uros. > Igor > >> H.J. >> -- >> PR target/84243 >> * gcc.target/i386/cet-intrin-4.c (dg-options): Use >> -fcf-protection=return. >> --- >> gcc/testsuite/gcc.target/i386/cet-intrin-4.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/gcc/testsuite/gcc.target/i386/cet-intrin-4.c >> b/gcc/testsuite/gcc.target/i386/cet-intrin-4.c >> index 76ec160543f..437a4cd690c 100644 >> --- a/gcc/testsuite/gcc.target/i386/cet-intrin-4.c >> +++ b/gcc/testsuite/gcc.target/i386/cet-intrin-4.c >> @@ -1,5 +1,5 @@ >> /* { dg-do compile } */ >> -/* { dg-options "-O -fcf-protection -mshstk" } */ >> +/* { dg-options "-O -fcf-protection=return -mshstk" } */ >> /* { dg-final { scan-assembler "rdsspd|incsspd\[ \t]+(%|)eax" { target ia32 } } } >> */ >> /* { dg-final { scan-assembler "rdssp\[dq]\[ \t]+(%|)\[re]ax" { target { ! ia32 } } >> } } */ >> /* { dg-final { scan-assembler "incssp\[dq]\[ \t]+(%|)\[re]di" { target { ! ia32 } } >> } } */ >> -- >> 2.14.3 >
diff --git a/gcc/testsuite/gcc.target/i386/cet-intrin-4.c b/gcc/testsuite/gcc.target/i386/cet-intrin-4.c index 76ec160543f..437a4cd690c 100644 --- a/gcc/testsuite/gcc.target/i386/cet-intrin-4.c +++ b/gcc/testsuite/gcc.target/i386/cet-intrin-4.c @@ -1,5 +1,5 @@ /* { dg-do compile } */ -/* { dg-options "-O -fcf-protection -mshstk" } */ +/* { dg-options "-O -fcf-protection=return -mshstk" } */ /* { dg-final { scan-assembler "rdsspd|incsspd\[ \t]+(%|)eax" { target ia32 } } } */ /* { dg-final { scan-assembler "rdssp\[dq]\[ \t]+(%|)\[re]ax" { target { ! ia32 } } } } */ /* { dg-final { scan-assembler "incssp\[dq]\[ \t]+(%|)\[re]di" { target { ! ia32 } } } } */