From patchwork Thu Nov 16 12:53:56 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pierre-Marie de Rodat X-Patchwork-Id: 838542 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=gcc.gnu.org (client-ip=209.132.180.131; helo=sourceware.org; envelope-from=gcc-patches-return-466991-incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b="KAg1EG9w"; dkim-atps=neutral Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3yd1Qs4RcNz9ryv for ; Thu, 16 Nov 2017 23:54:10 +1100 (AEDT) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:cc:subject:message-id:mime-version:content-type; q=dns; s=default; b=KMWYpNhUeKarxuiVrWESg1bvkSkKtxbaouw0ToFvh13DYbMVrg G5OJkZvIoNJREPW0tzNN2Pxas+7TbHs4PQNq+vo7lMdpkNVxwtUpv67kyZDDjXNE 9643vwHtAxZNmvmvuuOTwmkRIlKfD1OX6gjfjQwmuFM6Z34NKnFjRqTJA= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:cc:subject:message-id:mime-version:content-type; s= default; bh=9ijC4Nz7yxXbNhlz8IigMLkb+To=; b=KAg1EG9wGWBjzsfESYJP 2+yqgPV1Dl/YUru75mo81OCcAoPoqnJ/pBgATBypSBRerYhpPZvavIYUflPzD729 ++QYbHxfts93HNvfI+mG3qUsgcy8klE+hlsFeFDkuP2oFaynYgV9b6ZMV8prui/5 y4yt7WZo9qBbBP9ndxGXMKM= Received: (qmail 41592 invoked by alias); 16 Nov 2017 12:54:01 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 41564 invoked by uid 89); 16 Nov 2017 12:53:59 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-11.7 required=5.0 tests=BAYES_00, GIT_PATCH_2, GIT_PATCH_3, KB_WAM_FROM_NAME_SINGLEWORD, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=ham version=3.3.2 spammy=Duff, duff@adacore.com, sk:check_a, U*duff X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 16 Nov 2017 12:53:58 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id AFA1411621F; Thu, 16 Nov 2017 07:53:56 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id Q-9sQrGPSSgx; Thu, 16 Nov 2017 07:53:56 -0500 (EST) Received: from tron.gnat.com (tron.gnat.com [IPv6:2620:20:4000:0:46a8:42ff:fe0e:e294]) by rock.gnat.com (Postfix) with ESMTP id 9D5A011621D; Thu, 16 Nov 2017 07:53:56 -0500 (EST) Received: by tron.gnat.com (Postfix, from userid 4862) id 99CB943A; Thu, 16 Nov 2017 07:53:56 -0500 (EST) Date: Thu, 16 Nov 2017 07:53:56 -0500 From: Pierre-Marie de Rodat To: gcc-patches@gcc.gnu.org Cc: Bob Duff Subject: [Ada] Spurious error on System'To_Address in -gnatc mode Message-ID: <20171116125356.GA103165@adacore.com> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.23 (2014-03-12) X-IsSubscribed: yes This patch fixes a bug where if an address clause specifies a call to System'To_Address as the address, and the code is compiled with the -gnatc switch, the compiler gives a spurious error message. The following test should compile quietly with -gnatc: gcc -c -gnatc counter.ads with System; package Counter is type Bar is record X : Integer; Y : Integer; end record; Null_Bar : constant Bar := (0, 0); Address : constant := 16#D000_0000#; Foo : Bar := Null_Bar; for Foo'Address use System'To_Address (Address); end Counter; Tested on x86_64-pc-linux-gnu, committed on trunk 2017-11-16 Bob Duff * sem_ch13.adb (Check_Expr_Constants): Avoid error message in case of System'To_Address. Index: sem_ch13.adb =================================================================== --- sem_ch13.adb (revision 254797) +++ sem_ch13.adb (working copy) @@ -9783,6 +9783,15 @@ then Check_At_Constant_Address (Prefix (Nod)); + -- Normally, System'To_Address will have been transformed into + -- an Unchecked_Conversion, but in -gnatc mode, it will not, + -- and we don't want to give an error, because the whole point + -- of 'To_Address is that it is static. + + elsif Attribute_Name (Nod) = Name_To_Address then + pragma Assert (Operating_Mode = Check_Semantics); + null; + else Check_Expr_Constants (Prefix (Nod)); Check_List_Constants (Expressions (Nod));