From patchwork Thu Nov 16 10:24:05 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pierre-Marie de Rodat X-Patchwork-Id: 838478 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=gcc.gnu.org (client-ip=209.132.180.131; helo=sourceware.org; envelope-from=gcc-patches-return-466956-incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b="fDnYESVP"; dkim-atps=neutral Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3ycy6H3lftz9t1t for ; Thu, 16 Nov 2017 21:24:39 +1100 (AEDT) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:cc:subject:message-id:mime-version:content-type; q=dns; s=default; b=W8j0KMIm1ehTveDP57TNIht8P2LkP49zA+IaJdQycLyZ8T3qYb CL3cQbnYq2DY/nz7qt5Tg9Ni2D0h3n8ENzcPLL/iLhceT2VusEo6z9hmZce45SZx Hu/sGvgbidPWWL29w/9965Pu/fCRMLGSeBSrxaWGdQxi4+lZVcVjIqlJs= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:cc:subject:message-id:mime-version:content-type; s= default; bh=eS5F0+/jjW4N6qavZTAjszT+gT8=; b=fDnYESVPdzF+8dQa8fbV mpyQ901Tx6vdpuO0Q1r3jfkIEaPB9291T1UGC/9JSWa52DUb/3qtIh6Y0Ce3h/qu nykESI5x08LEeCIyLM0y7I8ciyuk44fO9aLzxPCcuqgaHcVL566FvEokDyGeoKmL Jm4PJ8G8Mv3NFKNEvRFoZaI= Received: (qmail 102699 invoked by alias); 16 Nov 2017 10:24:31 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 102257 invoked by uid 89); 16 Nov 2017 10:24:16 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-11.7 required=5.0 tests=BAYES_00, GIT_PATCH_2, GIT_PATCH_3, KB_WAM_FROM_NAME_SINGLEWORD, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:990 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 16 Nov 2017 10:24:14 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 03374116203 for ; Thu, 16 Nov 2017 05:24:06 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id HMjtgVkfrpsN for ; Thu, 16 Nov 2017 05:24:05 -0500 (EST) Received: from tron.gnat.com (tron.gnat.com [IPv6:2620:20:4000:0:46a8:42ff:fe0e:e294]) by rock.gnat.com (Postfix) with ESMTP id E62AE1161D8 for ; Thu, 16 Nov 2017 05:24:05 -0500 (EST) Received: by tron.gnat.com (Postfix, from userid 4862) id E4F13517; Thu, 16 Nov 2017 05:24:05 -0500 (EST) Date: Thu, 16 Nov 2017 05:24:05 -0500 From: Pierre-Marie de Rodat To: gcc-patches@gcc.gnu.org Cc: kirchev@adacore.com Subject: [Ada] Disallow renamings declaring tagged primitives Message-ID: <20171116102405.GA48698@adacore.com> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.23 (2014-03-12) X-IsSubscribed: yes This patch enables the check which ensures that a subprogram renaming does not declare a primitive operation of a tagged type in instantiations. Tested on x86_64-pc-linux-gnu, committed on trunk 2017-11-16 Hristian Kirtchev * sem_ch8.adb (Check_SPARK_Primitive_Operation): Enable the check in instantiations. Index: sem_ch8.adb =================================================================== --- sem_ch8.adb (revision 254804) +++ sem_ch8.adb (working copy) @@ -2533,16 +2533,11 @@ Typ : Entity_Id; begin - -- Nothing to do when the subprogram appears within an instance - - if In_Instance then - return; - -- Nothing to do when the subprogram is not subject to SPARK_Mode On -- because this check applies to SPARK code only. - elsif not (Present (Prag) - and then Get_SPARK_Mode_From_Annotation (Prag) = On) + if not (Present (Prag) + and then Get_SPARK_Mode_From_Annotation (Prag) = On) then return;