From patchwork Sat Aug 12 01:32:28 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "H.J. Lu" X-Patchwork-Id: 800801 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=gcc.gnu.org (client-ip=209.132.180.131; helo=sourceware.org; envelope-from=gcc-patches-return-460267-incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b="ccv1NE3c"; dkim-atps=neutral Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3xTksH6syMz9t2Z for ; Sat, 12 Aug 2017 11:33:04 +1000 (AEST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:cc:subject:message-id:mime-version:content-type; q=dns; s=default; b=B/xcc4UCC8Y9AWZj/71IDJPwgGO0bkVsGXzsmfZhqWbpRTzY7J 50Goihrjd3Kb1/4tuMtiDqjcS0QUxgwas3vIHmmXtjte55tI2GA3ynBw7Gg+8h2q 3P2qXwwAf1E7G/rL9X/t9bCDhp3OjEMSSlKN7USRosbV2SvoFcWaP0uDM= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:cc:subject:message-id:mime-version:content-type; s= default; bh=x3Kn2hFmIrI47RoTN27THPtnIM4=; b=ccv1NE3csk2Y4ZtBELJX x9fzHpjq+GO9LQF2PWNy/64h2ko6QQvxZ0MZlXbFX+XSNlbxFfA8uZHxo4V8QrNO gKcVUEE96H9VxmQfYCSM0NBBqcLiowsVx7D2/4YzltoLpxhhBppsMgbbWgxmTkmD S517xrDWhDb5CwSpH35AywY= Received: (qmail 98140 invoked by alias); 12 Aug 2017 01:32:49 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 88318 invoked by uid 89); 12 Aug 2017 01:32:33 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.4 required=5.0 tests=AWL, BAYES_00, FREEMAIL_FROM, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, RCVD_IN_SORBS_SPAM, SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mail-pg0-f48.google.com Received: from mail-pg0-f48.google.com (HELO mail-pg0-f48.google.com) (74.125.83.48) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 12 Aug 2017 01:32:31 +0000 Received: by mail-pg0-f48.google.com with SMTP id l64so21384786pge.5 for ; Fri, 11 Aug 2017 18:32:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition:user-agent; bh=1xpythmPv37BTb6Obud8dkaw1OpsQ6m0kmBTxRkjhjI=; b=PXGSDkOU5RdBcgvGHOgGaOHRkQqy3MPv/IIdHXb2ooIAzKQp15pBNpIUDDAYEdEm2L rq1DMbQ2SGGT/6/0S9cFcwfaK2Lk8SQXn5lT2KDMA06mPqSaSbT58QOTWxQZwPbBqGJj /C0VixFlZMdgg6BHY1T5UENi7+i6POm1HEKcTNxK0dK3k3xYVBUVghquc2oLwXWjxkxL RR/z5nYgnddQudSQMWmoAwzjHzChq4vq1BQQM+qoY4iDas9BArM6ZEIXfPAvnE6cI+RN yCu3AsmN4n0s5BAbPnlpudJq7xZxutXQWlNHya5NcRKRGUvIxL878gzF+/ZlJG8mwPfz kJFg== X-Gm-Message-State: AHYfb5h1ZyWVQjg9zmQ/JZqtlUZ3+QeZrGacPP2NdEjdiq4r5Fn49DQ+ 1UG8yGnVJwUSroQa X-Received: by 10.84.232.205 with SMTP id x13mr20063138plm.432.1502501549562; Fri, 11 Aug 2017 18:32:29 -0700 (PDT) Received: from gnu-tools-1.localdomain (c-73-93-86-59.hsd1.ca.comcast.net. [73.93.86.59]) by smtp.gmail.com with ESMTPSA id i133sm4229923pgc.0.2017.08.11.18.32.28 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 11 Aug 2017 18:32:29 -0700 (PDT) Received: by gnu-tools-1.localdomain (Postfix, from userid 1000) id 350491C03C0; Fri, 11 Aug 2017 18:32:28 -0700 (PDT) Date: Fri, 11 Aug 2017 18:32:28 -0700 From: "H.J. Lu" To: gcc-patches@gcc.gnu.org Cc: Uros Bizjak Subject: [PATCH] i386: Replace frame pointer with stack pointer in debug insns Message-ID: <20170812013228.GA3607@gmail.com> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.8.3 (2017-05-23) X-IsSubscribed: yes When we eliminate frame pointer, we should also replace frame pointer with stack pointer - UNITS_PER_WORD in debug insns. This patch fixed: FAIL: gcc.dg/guality/pr58791-5.c -Os line pr58791-5.c:20 b1 == 9 FAIL: gcc.dg/guality/pr58791-5.c -Os line pr58791-5.c:20 b2 == 73 FAIL: gcc.dg/guality/pr58791-5.c -Os line pr58791-5.c:20 b3 == 585 FAIL: gcc.dg/guality/pr58791-5.c -Os line pr58791-5.c:20 b4 == 4681 FAIL: gcc.dg/guality/pr59776.c -Os line pr59776.c:17 s1.f == 5.0 FAIL: gcc.dg/guality/pr59776.c -Os line pr59776.c:17 s1.g == 6.0 FAIL: gcc.dg/guality/pr59776.c -Os line pr59776.c:17 s2.g == 6.0 FAIL: gcc.dg/guality/pr59776.c -Os line pr59776.c:20 s1.f == 5.0 FAIL: gcc.dg/guality/pr59776.c -Os line pr59776.c:20 s1.g == 6.0 FAIL: gcc.dg/guality/pr59776.c -Os line pr59776.c:20 s2.f == 5.0 FAIL: gcc.dg/guality/pr59776.c -Os line pr59776.c:20 s2.g == 6.0 on Linux/i386. Tested on i686 and x86-64. OK for trunk? H.J. --- PR target/81820 * config/i386/i386.c (ix86_finalize_stack_frame_flags): Replace frame pointer with stack pointer - UNITS_PER_WORD in debug insns. --- gcc/config/i386/i386.c | 36 ++++++++++++++++++++++++++++++++++++ 1 file changed, 36 insertions(+) diff --git a/gcc/config/i386/i386.c b/gcc/config/i386/i386.c index b04321a8d40..0094f2c4441 100644 --- a/gcc/config/i386/i386.c +++ b/gcc/config/i386/i386.c @@ -14281,6 +14281,42 @@ ix86_finalize_stack_frame_flags (void) df_scan_blocks (); df_compute_regs_ever_live (true); df_analyze (); + + if (flag_var_tracking) + { + /* Since frame pointer is no longer needed, replace it with + stack pointer - UNITS_PER_WORD in debug insns. */ + df_ref ref, next; + for (ref = DF_REG_USE_CHAIN (HARD_FRAME_POINTER_REGNUM); + ref; ref = next) + { + rtx_insn *insn = DF_REF_INSN (ref); + /* Make sure the next ref is for a different instruction, + so that we're not affected by the rescan. */ + next = DF_REF_NEXT_REG (ref); + while (next && DF_REF_INSN (next) == insn) + next = DF_REF_NEXT_REG (next); + + if (DEBUG_INSN_P (insn)) + { + bool changed = false; + for (; ref != next; ref = DF_REF_NEXT_REG (ref)) + { + rtx *loc = DF_REF_LOC (ref); + if (*loc == hard_frame_pointer_rtx) + { + *loc = plus_constant (Pmode, + stack_pointer_rtx, + -UNITS_PER_WORD); + changed = true; + } + } + if (changed) + df_insn_rescan (insn); + } + } + } + recompute_frame_layout_p = true; }