diff mbox

[1/1] Remove redundant definition of srcrootpre

Message ID 20170605073016.GA7935@SDF.ORG
State New
Headers show

Commit Message

Maya Rashish June 5, 2017, 7:30 a.m. UTC 
This script has the only occurrence of it, and in this line
it defines and exports it.

---
 config-ml.in | 1 -
 1 file changed, 1 deletion(-)

Comments

Jeff Law June 6, 2017, 5:45 p.m. UTC | #1 
On 06/05/2017 01:30 AM, coypu wrote:
> This script has the only occurrence of it, and in this line
> it defines and exports it.
> 
> ---
>  config-ml.in | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/config-ml.in b/config-ml.in
> index 47f153350..58c80a35c 100644
> --- a/config-ml.in
> +++ b/config-ml.in
> @@ -493,7 +493,6 @@ multi-do:
>  	  true; \
>  	else \
>  	  rootpre=`${PWD_COMMAND}`/; export rootpre; \
> -	  srcrootpre=`cd $(srcdir); ${PWD_COMMAND}`/; export srcrootpre; \
>  	  lib=`echo "$${rootpre}" | sed -e 's,^.*/\([^/][^/]*\)/$$,\1,'`; \
>  	  compiler="$(CC)"; \
>  	  for i in `$${compiler} --print-multi-lib 2>/dev/null`; do \
> 
I think this is used outside GCC (newlib in particular).  It may be a
remnant of when folks used to build everything in a single unified tree
for crosses.

jeff
Maya Rashish June 8, 2017, 9:39 a.m. UTC | #2 
I paid extra attention to it because it appeared in the last line of a
build failure likely caused by shell tools differences. cd rarely outputs
the new directory for me.
diff mbox

Patch

diff --git a/config-ml.in b/config-ml.in
index 47f153350..58c80a35c 100644
--- a/config-ml.in
+++ b/config-ml.in
@@ -493,7 +493,6 @@  multi-do:
 	  true; \
 	else \
 	  rootpre=`${PWD_COMMAND}`/; export rootpre; \
-	  srcrootpre=`cd $(srcdir); ${PWD_COMMAND}`/; export srcrootpre; \
 	  lib=`echo "$${rootpre}" | sed -e 's,^.*/\([^/][^/]*\)/$$,\1,'`; \
 	  compiler="$(CC)"; \
 	  for i in `$${compiler} --print-multi-lib 2>/dev/null`; do \