From patchwork Tue Apr 25 08:04:44 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnaud Charlet X-Patchwork-Id: 754622 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3wBwkD37T7z9s82 for ; Tue, 25 Apr 2017 18:05:24 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b="i0MwlNqM"; dkim-atps=neutral DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:cc:subject:message-id:mime-version:content-type; q=dns; s=default; b=M/AALL4pERO6CrsS6BqVjjbSGAzYvY27/nkzpUGGDpSOKT5s+t 4xEln8rQPTH+FBPG37PI2++VLVfXv3p5KNNfff2AcSsdtBmtbxiL6BUiBujZ3JRH fzj+77f21bjIAxL18HCTsIiqs7YJN1jzI/DtNEn/vhITPQDLerQi5E4ZM= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:cc:subject:message-id:mime-version:content-type; s= default; bh=a9tCE1j+EzzJR72F/OWLKXgcMgE=; b=i0MwlNqMpCUdWbqWM8Ak CeIO565MlkrROoUR9yrT0iKNOjwBtX9wcRFWDxsF/dBURlQU5sRRP3kwJnpmjiLB cymdzi6OV+obeupJBrXcQZuVl97ApvWlKMjqt1EjhXvI5F40jcamzuZql41JRYnd +mDKKhgsFaJgAjZFksZ3rME= Received: (qmail 98351 invoked by alias); 25 Apr 2017 08:04:47 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 98287 invoked by uid 89); 25 Apr 2017 08:04:46 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-10.6 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 25 Apr 2017 08:04:44 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id A4B0729D85; Tue, 25 Apr 2017 04:04:44 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id ApB62+PQrlzT; Tue, 25 Apr 2017 04:04:44 -0400 (EDT) Received: from tron.gnat.com (tron.gnat.com [205.232.38.10]) by rock.gnat.com (Postfix) with ESMTP id 93D5811740B; Tue, 25 Apr 2017 04:04:44 -0400 (EDT) Received: by tron.gnat.com (Postfix, from userid 4192) id 9255B521; Tue, 25 Apr 2017 04:04:44 -0400 (EDT) Date: Tue, 25 Apr 2017 04:04:44 -0400 From: Arnaud Charlet To: gcc-patches@gcc.gnu.org Cc: Bob Duff Subject: [Ada] Illegal renaming of conditional expression Message-ID: <20170425080444.GA145038@adacore.com> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.23 (2014-03-12) This patch corrects a compiler bug that caused an illegal renaming to not be detected. In particular, it wasn't detected if the name in the renaming is a qualified expression whose operand is a conditional expression, and the type is a by-reference type. Tested on x86_64-pc-linux-gnu, committed on trunk 2017-04-25 Bob Duff * sem_util.adb (Is_Object_Reference): In the case of N_Explicit_Dereference, return False if it came from a conditional expression. Index: sem_util.adb =================================================================== --- sem_util.adb (revision 247137) +++ sem_util.adb (working copy) @@ -13548,8 +13548,14 @@ (Is_Object_Reference (Prefix (N)) or else Is_Access_Type (Etype (Prefix (N)))); + -- An explicit dereference denotes an object, except that a + -- conditional expression gets turned into an explicit dereference + -- in some cases, and conditional expressions are not object + -- names. + when N_Explicit_Dereference => - return True; + return not Nkind_In + (Original_Node (N), N_If_Expression, N_Case_Expression); -- A view conversion of a tagged object is an object reference