diff mbox

Fix typos in comments throughout source tree

Message ID 20170404111945.GO4425@redhat.com
State New
Headers show

Commit Message

Jonathan Wakely April 4, 2017, 11:19 a.m. UTC 
On 03/04/17 23:31 +0100, Jonathan Wakely wrote:
>On 03/04/17 20:06 +0100, Jonathan Wakely wrote:
>>On 03/04/17 11:48 -0700, Mike Stump wrote:
>>>[ dup, I sent the wrong from the wrong email address, you might not see it because of that ]
>>>
>>>>On Apr 3, 2017, at 11:47 AM, Mike Stump <mrs@mrs.kithrup.com> wrote:
>>>>
>>>>On Apr 3, 2017, at 10:53 AM, Jonathan Wakely <jwakely@redhat.com> wrote:
>>>>>
>>>>>This fixes lots of typos throughout the tree. Can this be committed to
>>>>>trunk as obvious?
>>>>
>>>>Yes, it can.  However, I like it when even this patch is reviewed.  I reviewed it, looks good.
>>>>
>>>>You missed initialisers -> initializers.
>>
>>Ah yes, in a couple of places.
>>
>>I think the original email about these typos only covered words
>>beginning with the letters A to E, so there are bound to be lots more
>>typos unfixed :-)
>>
>>
>>>>Not sure I like datastructures, should be data structures?
>>
>>Will do. I also forgot to do something about the "accestor ???" part
>>
>> We provide accestor to the inline_summary datastructure and
>> basic logic updating the parameters when inlining is performed.
>>
>>I don't know what that's supposed to say. "access"? "accessors"?
>
>I went for "access".
>
>Thanks for the review.
>
>
>>>>figure out that poth parameters  -> figure out that both parameters
>>
>>I'll fix that.
>>
>>>>>I've bootstrapped the C and C++ compilers, but not Ada, and of course
>>>>>not compiled all the target changes in gcc/config/*
>>>>>
>>>>>Is one big commit OK, or one per-ChangeLog? Or something else?
>>>>
>>>>I'd just do one big commit.
>>>
>>
>>Will do, thanks.
>>

Here's one more that somebody reported to the unofficial github
mirror: https://github.com/gcc-mirror/gcc/pull/6/files

Committed to trunk.

Comments

Mike Stump April 4, 2017, 3:30 p.m. UTC | #1 
On Apr 4, 2017, at 4:19 AM, Jonathan Wakely <jwakely@redhat.com> wrote:
> Here's one more that somebody reported to the unofficial github
> mirror: https://github.com/gcc-mirror/gcc/pull/6/files
> 
> Committed to trunk.

Thanks.
diff mbox

Patch

commit e14421f33a7b205127f2c2d271666603aa384313
Author: Jonathan Wakely <jwakely@redhat.com>
Date:   Tue Apr 4 11:09:06 2017 +0100

    	* ansidecl.h (ATTRIBUTE_PACKED): Fix typo in comment.

diff --git a/include/ansidecl.h b/include/ansidecl.h
index 6c0c837..25f33da 100644
--- a/include/ansidecl.h
+++ b/include/ansidecl.h
@@ -252,7 +252,7 @@  So instead we use the macro below and test it against specific values.  */
 # endif /* GNUC >= 3.0 */
 #endif /* ATTRIBUTE_ALIGNED_ALIGNOF */
 
-/* Useful for structures whose layout must much some binary specification
+/* Useful for structures whose layout must match some binary specification
    regardless of the alignment and padding qualities of the compiler.  */
 #ifndef ATTRIBUTE_PACKED
 # define ATTRIBUTE_PACKED __attribute__ ((packed))