From patchwork Fri Feb 17 09:31:16 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Martin Jambor X-Patchwork-Id: 729097 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3vPnpp3XJnz9s7r for ; Fri, 17 Feb 2017 20:31:45 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b="df+tK/KZ"; dkim-atps=neutral DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; q=dns; s=default; b=haXEv8q8uN/tGIdL/ VasHoOoPhTYOvjkue4c5EDKbKzDm8IOVjrgtNqxQKVdeq2g6ldoINqO9COVTK660 OJIfh83RWWAyZF3/686pUTQf53mLCfKquL2ZE4LVTRRxReQPgFghduw2J5B/NX+e 0+roed3w21weWNip6YZxjxEFLk= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=default; bh=pOLchPUsqblFPf1qBbaxdh/ GetQ=; b=df+tK/KZvGfVYFAEeaPBmfXFYsSUVeFZLf+uw3efv58tB/6Wb3H+Ls+ HWUx0UK2YHDTH6Pt/MvdKiNQvr34PEA7DsP9HWUHMtXvaeOeqO4YmikLySVFI1Wv PqStruXSkn2NIPCHfRnvLfaZEMXNch7MP+gTiPxoTM3y1O2Ss6Ds= Received: (qmail 19879 invoked by alias); 17 Feb 2017 09:31:38 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 19870 invoked by uid 89); 17 Feb 2017 09:31:37 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, SPF_PASS autolearn=ham version=3.3.2 spammy=him X-HELO: mx2.suse.de Received: from mx2.suse.de (HELO mx2.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 17 Feb 2017 09:31:27 +0000 Received: from relay2.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id AD4DCADFC; Fri, 17 Feb 2017 09:31:24 +0000 (UTC) Date: Fri, 17 Feb 2017 10:31:16 +0100 From: Martin Jambor To: Jakub Jelinek Cc: GCC Patches , "Joseph S. Myers" Subject: Re: [PATCH] Properly deprecate -fipa-cp-alignment Message-ID: <20170217093116.k3ivjmsu5bciopd3@virgil.suse.cz> Mail-Followup-To: Jakub Jelinek , GCC Patches , "Joseph S. Myers" References: <20170208124124.hufnye2g2es4s6fv@virgil.suse.cz> <20170208124917.GE1849@tucnak> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20170208124917.GE1849@tucnak> User-Agent: Mutt/1.6.2 (2016-07-01) X-IsSubscribed: yes Hi, On Wed, Feb 08, 2017 at 01:49:17PM +0100, Jakub Jelinek wrote: > On Wed, Feb 08, 2017 at 01:41:24PM +0100, Martin Jambor wrote: > > 2017-02-08 Martin Jambor > > > > * common.opt (-finstrument-functions-exclude-file-list): Remove Var > > and Optimization, Document as deprecated and superseded by > > -fipa-bit-cp. > > * doc/invoke.texi (Option Summary): Remove -fipa-cp-alignment. > > (Optimize Options): Likewise. > > (-fipa-cp-alignment): Document as deprecated. > > --- > > gcc/common.opt | 4 ++-- > > gcc/doc/invoke.texi | 11 +++-------- > > 2 files changed, 5 insertions(+), 10 deletions(-) > > > > diff --git a/gcc/common.opt b/gcc/common.opt > > index ad6baa3db68..661235ee4a9 100644 > > --- a/gcc/common.opt > > +++ b/gcc/common.opt > > @@ -1612,8 +1612,8 @@ Common Report Var(flag_ipa_cp_clone) Optimization > > Perform cloning to make Interprocedural constant propagation stronger. > > > > fipa-cp-alignment > > -Common Report Var(flag_ipa_cp_alignment) Optimization > > -Perform alignment discovery and propagation to make Interprocedural constant propagation stronger. > > +Common Report > > +This switch is deprecated. Use -fipa-bit-cp instead. > > I think this should be > Common Ignore > Does nothing. Preserved for backward compatibility. > instead, but Joseph is the option handling maintainer, so CCing him. > Thanks for pointing me to the right direction, I have added a second space after the dot and changed the patch to the one below. It has passed bootstrap, testing and I have also tested with make info. OK for trunk? Thanks, Martin 2017-02-16 Martin Jambor * common.opt (-fipa-cp-alignment): Mark as ignored and preserved for backward compatibility only. * doc/invoke.texi (Option Summary): Remove -fipa-cp-alignment. (Optimize Options): Likewise. (-fipa-cp-alignment): Document as deprecated. --- gcc/common.opt | 4 ++-- gcc/doc/invoke.texi | 11 +++-------- 2 files changed, 5 insertions(+), 10 deletions(-) diff --git a/gcc/common.opt b/gcc/common.opt index ad6baa3db68..1f6aa8dd02a 100644 --- a/gcc/common.opt +++ b/gcc/common.opt @@ -1612,8 +1612,8 @@ Common Report Var(flag_ipa_cp_clone) Optimization Perform cloning to make Interprocedural constant propagation stronger. fipa-cp-alignment -Common Report Var(flag_ipa_cp_alignment) Optimization -Perform alignment discovery and propagation to make Interprocedural constant propagation stronger. +Common Ignore +Does nothing. Preserved for backward compatibility. fipa-bit-cp Common Report Var(flag_ipa_bit_cp) Optimization diff --git a/gcc/doc/invoke.texi b/gcc/doc/invoke.texi index 56ca53f490b..ad617c02c31 100644 --- a/gcc/doc/invoke.texi +++ b/gcc/doc/invoke.texi @@ -371,7 +371,7 @@ Objective-C and Objective-C++ Dialects}. -fif-conversion2 -findirect-inlining @gol -finline-functions -finline-functions-called-once -finline-limit=@var{n} @gol -finline-small-functions -fipa-cp -fipa-cp-clone @gol --fipa-cp-alignment -fipa-bit-cp @gol +-fipa-bit-cp @gol -fipa-pta -fipa-profile -fipa-pure-const -fipa-reference -fipa-icf @gol -fira-algorithm=@var{algorithm} @gol -fira-region=@var{region} -fira-hoist-pressure @gol @@ -7054,7 +7054,6 @@ also turns on the following optimization flags: -finline-small-functions @gol -findirect-inlining @gol -fipa-cp @gol --fipa-cp-alignment @gol -fipa-bit-cp @gol -fipa-sra @gol -fipa-icf @gol @@ -8066,12 +8065,8 @@ This flag is enabled by default at @option{-O3}. @item -fipa-cp-alignment @opindex -fipa-cp-alignment -When enabled, this optimization propagates alignment of function -parameters to support better vectorization and string operations. - -This flag is enabled by default at @option{-O2} and @option{-Os}. It -requires that @option{-fipa-cp} is enabled. -@option{-fipa-cp-alignment} is obsolete, use @option{-fipa-bit-cp} instead. +This option has been superseded by @option{-fipa-bit-cp} and is now +deprecated. Use @option{-fipa-bit-cp} instead. @item -fipa-bit-cp @opindex -fipa-bit-cp