Message ID | 20170209152056.GM1849@tucnak |
---|---|
State | New |
Headers | show
Return-Path: <gcc-patches-return-448273-incoming=patchwork.ozlabs.org@gcc.gnu.org> X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3vK1xm5YQsz9ryk for <incoming@patchwork.ozlabs.org>; Fri, 10 Feb 2017 02:21:16 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b="qFg20fHG"; dkim-atps=neutral DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:cc:subject:message-id:reply-to:references:mime-version :content-type:content-transfer-encoding:in-reply-to; q=dns; s= default; b=ksDAYEHa4NRGYX7vLSp2Qmm5k2uOYecmeFD796hj9oWK4Q8odytSw JwPmdSEqmnDXGTWPhMGaanadRPd2bJY77a7t9X0n+EphBSODh79BVHtBDdZrndNZ BvOP+NpKF0VNhiDbvgUmj5+Cs/sNK/wfAf64pcgsih2h7ESa+3aA8Y= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:cc:subject:message-id:reply-to:references:mime-version :content-type:content-transfer-encoding:in-reply-to; s=default; bh=99FkGqKgpzr2IbhSEKq9V7k9AnU=; b=qFg20fHG3NO0djJggYwD41U/Ep+k LJ694qpBE73dmkMQ6rXkITxJQuNNxigzE6UpY+1wbDtaVEbx5+6le3cwUv6x+taV aYHMgAMWRYQ5uy+OQ0vLX9oU1iVab7ZbXRQ8ZwpyVEbOsa7935WwPWx2qGotUykV 1roKhWAyZL0Hh08= Received: (qmail 112479 invoked by alias); 9 Feb 2017 15:21:07 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: <gcc-patches.gcc.gnu.org> List-Unsubscribe: <mailto:gcc-patches-unsubscribe-incoming=patchwork.ozlabs.org@gcc.gnu.org> List-Archive: <http://gcc.gnu.org/ml/gcc-patches/> List-Post: <mailto:gcc-patches@gcc.gnu.org> List-Help: <mailto:gcc-patches-help@gcc.gnu.org> Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 112470 invoked by uid 89); 9 Feb 2017 15:21:06 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00, RP_MATCHES_RCVD, SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Allocate, *lo, noisy, 12527 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 09 Feb 2017 15:21:04 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 81581683FC; Thu, 9 Feb 2017 15:21:04 +0000 (UTC) Received: from tucnak.zalov.cz (ovpn-116-76.ams2.redhat.com [10.36.116.76]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id v19FL1jr009858 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Thu, 9 Feb 2017 10:21:04 -0500 Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.15.2/8.15.2) with ESMTP id v19FKw5Z003266; Thu, 9 Feb 2017 16:20:59 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.15.2/8.15.2/Submit) id v19FKuQ9003265; Thu, 9 Feb 2017 16:20:56 +0100 Date: Thu, 9 Feb 2017 16:20:56 +0100 From: Jakub Jelinek <jakub@redhat.com> To: Chung-Lin Tang <chunglin_tang@mentor.com> Cc: gcc-patches <gcc-patches@gcc.gnu.org>, Nathan Sidwell <nathan@acm.org>, Cesar Philippidis <cesar@codesourcery.com> Subject: Re: [Patch 2/5] OpenACC tile clause support, omp-low parts Message-ID: <20170209152056.GM1849@tucnak> Reply-To: Jakub Jelinek <jakub@redhat.com> References: <c5f37d54-c921-50c0-6b42-b4b6fa5813b0@mentor.com> <20161111100030.GV3541@tucnak.redhat.com> <b5b14823-7ff8-8cb3-9faa-3782b7ab6af1@mentor.com> <20161118111536.GU3541@tucnak.redhat.com> <6f729e16-65f7-decc-8c57-33180a78fb9b@mentor.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <6f729e16-65f7-decc-8c57-33180a78fb9b@mentor.com> User-Agent: Mutt/1.7.1 (2016-10-04) X-IsSubscribed: yes |
--- gcc/omp-offload.c.jj 2017-02-09 15:00:09.000000000 +0100 +++ gcc/omp-offload.c 2017-02-09 16:16:01.344737892 +0100 @@ -1252,7 +1252,7 @@ oacc_loop_auto_partitions (oacc_loop *lo noisy = false; #endif - if (assign && (!outer_assign | loop->inner)) + if (assign && (!outer_assign || loop->inner)) { /* Allocate outermost and non-innermost loops at the outermost non-innermost available level. */
On Tue, Nov 29, 2016 at 08:23:45PM +0800, Chung-Lin Tang wrote: > Adjusted and re-tested using the way you advised, attached updated patch. This broke bootstrap on all arches: ../../gcc/omp-offload.c: In function ‘unsigned int oacc_loop_auto_partitions(oacc_loop*, unsigned int, bool)’: ../../gcc/omp-offload.c:1255:18: warning: suggest parentheses around operand of ‘!’ or change ‘|’ to ‘||’ or ‘!’ to ‘~’ [-Wparentheses] if (assign && (!outer_assign | loop->inner)) ^~~~~~~~~~~~~ It isn't immediately clear what you wanted to do there, but in order to quickly fix the bootstrap problem, I've committed following patch. If you meant something different (such as if (assign && !(outer_assign || loop->inner)) ), please submit a fix for review and make sure to bootstrap and regtest it. 2017-02-09 Jakub Jelinek <jakub@redhat.com> * omp-offload.c (oacc_loop_auto_partitions): Use || instead of | to avoid warning. Jakub