From patchwork Thu Jul 21 19:43:23 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jonathan Wakely X-Patchwork-Id: 651433 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3rwPNc3XdCz9sf9 for ; Fri, 22 Jul 2016 05:44:00 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b=msscV7AY; dkim-atps=neutral DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:subject:message-id:references:mime-version:content-type :in-reply-to; q=dns; s=default; b=bSj0t8hcKz5/SkQckLW5Lo5OXHDC00 LYEwkzcrCrZ49NHkmgEk0acUiDLrDuetOzufSkfpYCDXJ5YhpoDqoGBkbH0qP3++ NsPpckS5AzMeIP8yYfUHAw4/jyX1MEMLSPUZRP3OI5+RmkdATqHT0W9//rOd+Qir mEgTlgpSCT5zI= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:subject:message-id:references:mime-version:content-type :in-reply-to; s=default; bh=7DbYYY+0QA6RKQIr5j1pVXaCcgs=; b=mssc V7AYoM1JAsrpX+F+HJr2k/6pyFNeCToNbi4ncWuttPzOMVs3lV5Jyg+0kX93SPlE jYAS8KEztZsyA4bDNpOIm3ddVNtYaFRd8au6naKYN06bMX01Wr/+QVXy+3iABnT/ 3mgwYZ8pVeXc500ztPfKBAmaS3j9o6j7ozkhKgg= Received: (qmail 51862 invoked by alias); 21 Jul 2016 19:43:39 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 51844 invoked by uid 89); 21 Jul 2016 19:43:38 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=BAYES_00, RP_MATCHES_RCVD, SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1851 X-Spam-User: qpsmtpd, 2 recipients X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 21 Jul 2016 19:43:25 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 31FBEC00F0AC; Thu, 21 Jul 2016 19:43:24 +0000 (UTC) Received: from localhost (ovpn-116-61.ams2.redhat.com [10.36.116.61]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u6LJhNNF007892; Thu, 21 Jul 2016 15:43:23 -0400 Date: Thu, 21 Jul 2016 20:43:23 +0100 From: Jonathan Wakely To: libstdc++@gcc.gnu.org, gcc-patches@gcc.gnu.org Subject: [PATCH 2/4] Fix undefined behaviour in libstdc++ testsuite Message-ID: <20160721194322.GG4264@redhat.com> References: <20160721193831.GF4264@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20160721193831.GF4264@redhat.com> X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.6.2 (2016-07-01) This one just fixes some missing returns, where the functions should have been declared to return void anyway. Fix missing returns in libstdc++ testsuite * testsuite/24_iterators/container_access.cc: Fix missing returns. * testsuite/24_iterators/range_access_cpp14.cc: Likewise. Tested powerpc64-linux, committed to trunk. commit 485fa6438286f25d3e1b66e7280d2c5105628416 Author: redi Date: Thu Jul 21 19:38:44 2016 +0000 Fix missing returns in libstdc++ testsuite * testsuite/24_iterators/container_access.cc: Fix missing returns. * testsuite/24_iterators/range_access_cpp14.cc: Likewise. git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/trunk@238608 138bc75d-0d04-0410-961f-82ee72b054a4 diff --git a/libstdc++-v3/testsuite/24_iterators/container_access.cc b/libstdc++-v3/testsuite/24_iterators/container_access.cc index a9cb54e..f4d4f7e 100644 --- a/libstdc++-v3/testsuite/24_iterators/container_access.cc +++ b/libstdc++-v3/testsuite/24_iterators/container_access.cc @@ -47,7 +47,7 @@ test02() static_assert(!e); } -int +void test03() { std::initializer_list il{1,2,3}; @@ -67,7 +67,7 @@ test03() } -int +void test04() { std::vector v{1,2,3}; diff --git a/libstdc++-v3/testsuite/24_iterators/range_access_cpp14.cc b/libstdc++-v3/testsuite/24_iterators/range_access_cpp14.cc index 9292fa6..79fb0f4b 100644 --- a/libstdc++-v3/testsuite/24_iterators/range_access_cpp14.cc +++ b/libstdc++-v3/testsuite/24_iterators/range_access_cpp14.cc @@ -48,7 +48,7 @@ test02() constexpr auto ce __attribute__((unused)) = std::cend(i); } -int +void test03() { std::initializer_list il{1}; @@ -60,7 +60,7 @@ test03() VERIFY(std::crend(il) == std::reverse_iterator(il.begin())); } -int +void test04() { std::vector v{1};