| Message ID | 20160530231954.126536-1-marbacz@gmail.com |
|---|---|
| State | New |
| Headers | show |
On 05/30/2016 05:19 PM, Marcin Baczyński wrote: > Hi, > this is my first GCC patch, so please bear with me if something is wrong with > it in an obvious way. > > I've found two unused macros in gcc/diagnostic.h. Is the patch okay as is? > Bootstrapped on x86_64-pc-linux-gnu. > > 2016-05-31 Marcin Baczyński <marbacz@gmail.com> > > * gcc/diagnostic.h (diagnostic_line_cutoff, diagnostic_flush_buffer): > delete. This is fine for the trunk. Please install. THanks, jeff
2016-06-09 18:35 GMT+02:00 Jeff Law <law@redhat.com>: > On 05/30/2016 05:19 PM, Marcin Baczyński wrote: >> >> Hi, >> this is my first GCC patch, so please bear with me if something is wrong >> with >> it in an obvious way. >> >> I've found two unused macros in gcc/diagnostic.h. Is the patch okay as is? >> Bootstrapped on x86_64-pc-linux-gnu. >> >> 2016-05-31 Marcin Baczyński <marbacz@gmail.com> >> >> * gcc/diagnostic.h (diagnostic_line_cutoff, diagnostic_flush_buffer): >> delete. > > This is fine for the trunk. Please install. > Thanks for the approval. As for installing, I don't have write access to the repository, so could someone with the access do it, please? > THanks, > jeff
On 06/09/2016 12:35 PM, Marcin Baczyński wrote: > 2016-06-09 18:35 GMT+02:00 Jeff Law <law@redhat.com>: >> On 05/30/2016 05:19 PM, Marcin Baczyński wrote: >>> >>> Hi, >>> this is my first GCC patch, so please bear with me if something is wrong >>> with >>> it in an obvious way. >>> >>> I've found two unused macros in gcc/diagnostic.h. Is the patch okay as is? >>> Bootstrapped on x86_64-pc-linux-gnu. >>> >>> 2016-05-31 Marcin Baczyński <marbacz@gmail.com> >>> >>> * gcc/diagnostic.h (diagnostic_line_cutoff, diagnostic_flush_buffer): >>> delete. >> >> This is fine for the trunk. Please install. >> > > Thanks for the approval. As for installing, I don't have write access > to the repository, so could someone with the access do it, please? OK. I took care of committing to the repository. Thanks, jeff
diff --git a/gcc/diagnostic.h b/gcc/diagnostic.h index 48ae50d..58d77df 100644 --- a/gcc/diagnostic.h +++ b/gcc/diagnostic.h @@ -231,12 +231,6 @@ diagnostic_inhibit_notes (diagnostic_context * context) /* Same as output_prefixing_rule. Works on 'diagnostic_context *'. */ #define diagnostic_prefixing_rule(DC) ((DC)->printer->wrapping.rule) -/* Maximum characters per line in automatic line wrapping mode. - Zero means don't wrap lines. */ -#define diagnostic_line_cutoff(DC) ((DC)->printer->wrapping.line_cutoff) - -#define diagnostic_flush_buffer(DC) pp_flush ((DC)->printer) - /* True if the last module or file in which a diagnostic was reported is different from the current one. */ #define diagnostic_last_module_changed(DC, MAP) \
Hi, this is my first GCC patch, so please bear with me if something is wrong with it in an obvious way. I've found two unused macros in gcc/diagnostic.h. Is the patch okay as is? Bootstrapped on x86_64-pc-linux-gnu. 2016-05-31 Marcin Baczyński <marbacz@gmail.com> * gcc/diagnostic.h (diagnostic_line_cutoff, diagnostic_flush_buffer): delete. --- gcc/diagnostic.h | 6 ------ 1 file changed, 6 deletions(-)