| Message ID | 20160505101224.GC27545@redhat.com |
|---|---|
| State | New |
| Headers | show |
On 5 May 2016 at 12:12, Jonathan Wakely <jwakely@redhat.com> wrote: > On 04/05/16 17:19 +0100, Andre Vieira (lists) wrote: >> >> On 20/04/16 18:40, Jonathan Wakely wrote: >>> >>> On 19/04/16 19:07 +0100, Jonathan Wakely wrote: >>>> >>>> This was reported as a bug in the Filesystem library, but it's >>>> actually a problem in the codecvt_utf8 facet that it uses. >>> >>> >>> The fix had a silly typo meaning it didn't work for big endian >>> targets, which was revealed by the improved tests I added. >>> >>> Tested x86_64-linux and powerpc64-linux, committed to trunk. >>> >>> >> Hi Jonathan, >> >> We are seeing experimental/filesystem/path/native/string.cc fail on >> baremetal targets. I'm guessing this is missing a >> 'dg-require-filesystem-ts', as seen on other tests like >> experimental/filesystem/path/modifiers/swap.cc. >> >> Cheers, >> Andre > > > Sorry about that, I've committed the missing directive. > > Hi, I've seen you've backported the main patch to the gcc-6 branch, you forgot to add the follow-up "Add dg-require-filesystem-ts directive to test". Christophe
On 26 May 2016 at 13:58, Christophe Lyon <christophe.lyon@linaro.org> wrote: > On 5 May 2016 at 12:12, Jonathan Wakely <jwakely@redhat.com> wrote: >> On 04/05/16 17:19 +0100, Andre Vieira (lists) wrote: >>> >>> On 20/04/16 18:40, Jonathan Wakely wrote: >>>> >>>> On 19/04/16 19:07 +0100, Jonathan Wakely wrote: >>>>> >>>>> This was reported as a bug in the Filesystem library, but it's >>>>> actually a problem in the codecvt_utf8 facet that it uses. >>>> >>>> >>>> The fix had a silly typo meaning it didn't work for big endian >>>> targets, which was revealed by the improved tests I added. >>>> >>>> Tested x86_64-linux and powerpc64-linux, committed to trunk. >>>> >>>> >>> Hi Jonathan, >>> >>> We are seeing experimental/filesystem/path/native/string.cc fail on >>> baremetal targets. I'm guessing this is missing a >>> 'dg-require-filesystem-ts', as seen on other tests like >>> experimental/filesystem/path/modifiers/swap.cc. >>> >>> Cheers, >>> Andre >> >> >> Sorry about that, I've committed the missing directive. >> >> > Hi, > > I've seen you've backported the main patch to the gcc-6 branch, you > forgot to add the follow-up "Add dg-require-filesystem-ts directive to > test". > And likewise for the gcc-5 branch. > Christophe
On 26/05/16 14:02 +0200, Christophe Lyon wrote: >> I've seen you've backported the main patch to the gcc-6 branch, you >> forgot to add the follow-up "Add dg-require-filesystem-ts directive to >> test". >> >And likewise for the gcc-5 branch. Both fixed now, sorry about that, again.
commit 775381d7e53d5a68a2725b6b72f081d254d9380b
Author: Jonathan Wakely <jwakely@redhat.com>
Date: Thu May 5 10:42:35 2016 +0100
Add dg-require-filesystem-ts directive to test
* testsuite/experimental/filesystem/path/native/string.cc: Add
dg-require-filesystem-ts directive.
diff --git a/libstdc++-v3/testsuite/experimental/filesystem/path/native/string.cc b/libstdc++-v3/testsuite/experimental/filesystem/path/native/string.cc
index 05ff57c..e56fda7 100644
--- a/libstdc++-v3/testsuite/experimental/filesystem/path/native/string.cc
+++ b/libstdc++-v3/testsuite/experimental/filesystem/path/native/string.cc
@@ -16,6 +16,7 @@
// <http://www.gnu.org/licenses/>.
// { dg-options "-std=gnu++11 -lstdc++fs" }
+// { dg-require-filesystem-ts "" }
#include <experimental/filesystem>
#include <string>