From patchwork Mon Feb 22 21:27:47 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jakub Jelinek X-Patchwork-Id: 586559 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 086FC140662 for ; Tue, 23 Feb 2016 08:28:13 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b=uxMtPboX; dkim-atps=neutral DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:cc:subject:message-id:reply-to:references:mime-version :content-type:in-reply-to; q=dns; s=default; b=xzOQ4FkSZuDuRXDtp BSU8/ei3teZ6sn6NKRO6juFA3IFDB8OnpHrNPwOHKQAy4bhX0ck5PggcOa7Zrw6W GijLt/Fjp26Rijlj0jxZvVvN2aRKmHUZ9eQ7olks+NHyJVeV8qxxCiHHwOi71/RY X5yXRI9BasvJnFi6DuH3E0n2Qs= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:cc:subject:message-id:reply-to:references:mime-version :content-type:in-reply-to; s=default; bh=r751l2PEtmuqv85lIc5kA0F VFcE=; b=uxMtPboXmvADdfkdKHZ0KmbKWtV+mTBwQiWv0tnIYU6/mzfmJ8hvCiu Tvs9KGGlhsCigCJam2INxYzWtugOUV4NpXvjOJYXj34Blwejb5G1fo2CkURFHhRc Eo8LFXhb7vhvZNvxMqHVZmELQvJP0J3eF8T9fIVyA6qdNYHyiqp0= Received: (qmail 77485 invoked by alias); 22 Feb 2016 21:28:01 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 77282 invoked by uid 89); 22 Feb 2016 21:28:00 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00, RP_MATCHES_RCVD, SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=@xref, xref, Hx-languages-length:1294 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Mon, 22 Feb 2016 21:27:55 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (Postfix) with ESMTPS id 14D5A2DC372; Mon, 22 Feb 2016 21:27:54 +0000 (UTC) Received: from tucnak.zalov.cz ([10.3.113.11]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u1MLRqKb021151 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Mon, 22 Feb 2016 16:27:53 -0500 Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.15.2/8.15.2) with ESMTP id u1MLRnX9024798; Mon, 22 Feb 2016 22:27:50 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.15.2/8.15.2/Submit) id u1MLRlC9024797; Mon, 22 Feb 2016 22:27:47 +0100 Date: Mon, 22 Feb 2016 22:27:47 +0100 From: Jakub Jelinek To: Jeff Law Cc: Andreas Schwab , gcc-patches@gcc.gnu.org, Matthias Klose Subject: Re: [PATCH] Fix bootstrap on m68k (PR target/69885) Message-ID: <20160222212747.GT3017@tucnak.redhat.com> Reply-To: Jakub Jelinek References: <20160222130839.GJ3017@tucnak.redhat.com> <56CB16A5.4090007@redhat.com> <20160222142815.GK3017@tucnak.redhat.com> <56CB3421.7070005@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <56CB3421.7070005@redhat.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-IsSubscribed: yes On Mon, Feb 22, 2016 at 09:15:29AM -0700, Jeff Law wrote: > Yea, as it's currently written, it's a bit vague. I think your suggesting > of saying that VOIDmode should not be used is what we need. I'll leave the > final word-smithing to you. Here is what I've committed. 2016-02-22 Jakub Jelinek PR target/69885 * doc/md.texi (ashl@var{m}3): Document that mode of operand 2 must be specified. Jakub --- gcc/doc/md.texi.jj 2016-02-12 00:50:55.000000000 +0100 +++ gcc/doc/md.texi 2016-02-22 17:20:00.910016901 +0100 @@ -5283,7 +5283,9 @@ Arithmetic-shift operand 1 left by a num 2, and store the result in operand 0. Here @var{m} is the mode of operand 0 and operand 1; operand 2's mode is specified by the instruction pattern, and the compiler will convert the operand to that -mode before generating the instruction. The meaning of out-of-range shift +mode before generating the instruction. The shift or rotate expander +or instruction pattern should explicitly specify the mode of the operand 2, +it should never be @code{VOIDmode}. The meaning of out-of-range shift counts can optionally be specified by @code{TARGET_SHIFT_TRUNCATION_MASK}. @xref{TARGET_SHIFT_TRUNCATION_MASK}. Operand 2 is always a scalar type.