From patchwork Fri Dec 4 10:00:28 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tobias Burnus X-Patchwork-Id: 552646 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 7D7A81402E2 for ; Fri, 4 Dec 2015 21:00:45 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b=nfPkQJyc; dkim-atps=neutral DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; q=dns; s=default; b=bh1tVg8kGvEiKBM/t o0aEM5x4Nk/AGM4uPqBEfjLKrK1g9J7vcKOEX8E7eQIvBPAxu9Ruv5THetg58v/u GemE4zvxOdDkKCS71BCKJHpE3O2epOCTmvOYETKsbatbFCf/LrrreQjEF+UzkH+G 9SlfcZTDaugkcs2M821JkRBYOE= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=default; bh=BMvKVxGG+MiLn/OxTBIiEE2 633Y=; b=nfPkQJycTn3AFWv6+4ynFiXN5vlbJTeIxoX1C5SDeiZzg7NhjyJ1vuE WWF4HVjX/EeaIKWWwBn3I/8uFMbTKzI6jqFi4eolN+zDNAp5ifJLFb+TYqbbE3Ib DBNZ5Cx2sTiKExEIo84im03k2WuyXJgyPtylJVRU8uftqbcyy77s= Received: (qmail 95913 invoked by alias); 4 Dec 2015 10:00:36 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 95885 invoked by uid 89); 4 Dec 2015 10:00:36 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=0.6 required=5.0 tests=AWL, BAYES_50, KAM_LAZY_DOMAIN_SECURITY, T_RP_MATCHES_RCVD autolearn=no version=3.3.2 X-HELO: outpost19.zedat.fu-berlin.de Received: from outpost19.zedat.fu-berlin.de (HELO outpost19.zedat.fu-berlin.de) (130.133.4.112) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 04 Dec 2015 10:00:35 +0000 Received: from relay1.zedat.fu-berlin.de ([130.133.4.67]) by outpost.zedat.fu-berlin.de (Exim 4.85) with esmtp (envelope-from ) id <1a4nAG-002xnQ-58>; Fri, 04 Dec 2015 11:00:32 +0100 Received: from mx.physik.fu-berlin.de ([160.45.64.218]) by relay1.zedat.fu-berlin.de (Exim 4.85) with esmtps (envelope-from ) id <1a4nAG-002kN7-3R>; Fri, 04 Dec 2015 11:00:32 +0100 Received: from login1.physik.fu-berlin.de ([160.45.66.207]) by mx.physik.fu-berlin.de with esmtps (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1a4nAC-0001iS-T4; Fri, 04 Dec 2015 11:00:28 +0100 Received: from tburnus by login1.physik.fu-berlin.de with local (Exim 4.80 #3 (Debian)) id 1a4nAC-0001b0-Ml; Fri, 04 Dec 2015 11:00:28 +0100 Date: Fri, 4 Dec 2015 11:00:28 +0100 From: Tobias Burnus To: gcc-patches@gcc.gnu.org Cc: Manuel =?iso-8859-1?B?TPNwZXotSWLh8WV6?= Subject: Re: PR c/68657 - Add missing 'Warning' flags to c-family/c.opt + java/lang.opt Message-ID: <20151204100028.GA5781@physik.fu-berlin.de> References: <20151204095928.GB1250@physik.fu-berlin.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20151204095928.GB1250@physik.fu-berlin.de> User-Agent: Mutt/1.5.21 (2010-09-15) And now with attached patch ... On Fri, Dec 04, 2015 at 10:59:29AM +0100, Tobias Burnus wrote: > A few warning options lack the 'Warning' flag, which since r228094 (2015-09-24) > has the effect that -W(no-)error= doesn't work for them. Additionally, > --help=warnings doesn't work for them either. > > Successfully bootstrapped with c,c++,fortran,lto,go,objc,obj-c++,java on > x86-64-gnu-linux & checked whether the issue in the PR was fixed. > > I intent to commit the patch tomorrow as obvious unless someone has objections. > > Tobias gcc/c-family/ PR c/68657 * c.opt (Wpsabi, Wfloat-conversion, Wsign-conversion): Add 'Warning' flag. gcc/java/ PR c/68657 * lang.opt (Wdeprecated, Wextraneous-semicolon, Wout-of-date, Wredundant-modifiers): Add 'Warning' flag. diff --git a/gcc/c-family/c.opt b/gcc/c-family/c.opt index aafd802..758f88f 100644 --- a/gcc/c-family/c.opt +++ b/gcc/c-family/c.opt @@ -267,3 +267,3 @@ Warn if a subobject has an abi_tag attribute that the complete object type does Wpsabi -C ObjC C++ ObjC++ LTO Var(warn_psabi) Init(1) Undocumented LangEnabledBy(C ObjC C++ ObjC++,Wabi) +C ObjC C++ ObjC++ LTO Var(warn_psabi) Init(1) Undocumented Warning LangEnabledBy(C ObjC C++ ObjC++,Wabi) @@ -437,3 +437,3 @@ This switch is deprecated; use -Werror=implicit-function-declaration instead. Wfloat-conversion -C ObjC C++ ObjC++ Var(warn_float_conversion) LangEnabledBy(C ObjC C++ ObjC++,Wconversion) +C ObjC C++ ObjC++ Var(warn_float_conversion) Warning LangEnabledBy(C ObjC C++ ObjC++,Wconversion) Warn for implicit type conversions that cause loss of floating point precision. @@ -839,3 +839,3 @@ C ObjC C++ ObjC++ EnabledBy(Wextra) Wsign-conversion -C ObjC C++ ObjC++ Var(warn_sign_conversion) LangEnabledBy(C ObjC,Wconversion) +C ObjC C++ ObjC++ Var(warn_sign_conversion) Warning LangEnabledBy(C ObjC,Wconversion) Warn for implicit type conversions between signed and unsigned integers. diff --git a/gcc/java/lang.opt b/gcc/java/lang.opt index 7399d57..9fd2580 100644 --- a/gcc/java/lang.opt +++ b/gcc/java/lang.opt @@ -116,3 +116,3 @@ Java Wdeprecated -Java Var(warn_deprecated) +Java Var(warn_deprecated) Warning ; Documented for C @@ -120,3 +120,3 @@ Java Var(warn_deprecated) Wextraneous-semicolon -Java Var(flag_extraneous_semicolon) +Java Var(flag_extraneous_semicolon) Warning Warn if deprecated empty statements are found. @@ -124,3 +124,3 @@ Warn if deprecated empty statements are found. Wout-of-date -Java Var(flag_newer) Init(1) +Java Var(flag_newer) Init(1) Warning Warn if .class files are out of date. @@ -128,3 +128,3 @@ Warn if .class files are out of date. Wredundant-modifiers -Java Var(flag_redundant) +Java Var(flag_redundant) Warning Warn if modifiers are specified when not necessary.