From patchwork Thu Dec 3 06:26:30 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Steve Kargl X-Patchwork-Id: 552048 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3A1A714029E for ; Thu, 3 Dec 2015 17:26:48 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b=UT6A3/uP; dkim-atps=neutral DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; q=dns; s=default; b=C0i9wu1DGLwYcqLNy AdRiLhLwVVfLVljRlfvXYmjHUnQvXvRl3FPWxzrUL1afHS2PZUnGlK/+x26YyvlP imDB1fkBWmqKsMgAkyf/YNBlzVBTXj1f7qIHb00Z1ipUHLOKNZyy5aGb3alHln8l d9YY0Wccd1bjemgkmkSD7n9/jM= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=default; bh=9UKhsh37xzB8Rb2Hm+9fyix u7kM=; b=UT6A3/uPY7h59ubVzTZ9gv5bpxjiRQ0/VzXQ0o/eOE13mgey+c3tDF1 N+Rz+77PBlGnz+ETYmCHcKqdoLHdptCqsb9+cvOQKz5gNUD9pt7oAsNjaPCie5bL 2t5pvm+V81XMvGKqJ+DLPRc5uOcsOacr38U498XL/193QaLUAqqU= Received: (qmail 26570 invoked by alias); 3 Dec 2015 06:26:35 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 26540 invoked by uid 89); 3 Dec 2015 06:26:34 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=0.0 required=5.0 tests=AWL, BAYES_50, KAM_LAZY_DOMAIN_SECURITY, T_RP_MATCHES_RCVD autolearn=no version=3.3.2 X-Spam-User: qpsmtpd, 2 recipients X-HELO: troutmask.apl.washington.edu Received: from troutmask.apl.washington.edu (HELO troutmask.apl.washington.edu) (128.95.76.21) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 03 Dec 2015 06:26:32 +0000 Received: from troutmask.apl.washington.edu (localhost [127.0.0.1]) by troutmask.apl.washington.edu (8.15.2/8.15.2) with ESMTPS id tB36QU2x062172 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Wed, 2 Dec 2015 22:26:30 -0800 (PST) (envelope-from sgk@troutmask.apl.washington.edu) Received: (from sgk@localhost) by troutmask.apl.washington.edu (8.15.2/8.15.2/Submit) id tB36QUDF062171; Wed, 2 Dec 2015 22:26:30 -0800 (PST) (envelope-from sgk) Date: Wed, 2 Dec 2015 22:26:30 -0800 From: Steve Kargl To: Paul Richard Thomas Cc: "fortran@gcc.gnu.org" , gcc-patches Subject: Re: [Patch, fortran] PR68534 - No error on mismatch in number of arguments between submodule and module interface Message-ID: <20151203062630.GA62157@troutmask.apl.washington.edu> References: <20151128161940.GA97246@troutmask.apl.washington.edu> <20151203060233.GA62024@troutmask.apl.washington.edu> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20151203060233.GA62024@troutmask.apl.washington.edu> User-Agent: Mutt/1.5.24 (2015-08-30) On Wed, Dec 02, 2015 at 10:02:33PM -0800, Steve Kargl wrote: > Paul, > > I'm stumped. Something is broken on i386-*-freebsd. :-( > > Running /mnt/kargl/gcc/gcc/testsuite/gfortran.dg/dg.exp ... > FAIL: gfortran.dg/submodule_10.f08 -O (internal compiler error) > FAIL: gfortran.dg/submodule_10.f08 -O (test for excess errors) > FAIL: gfortran.dg/submodule_11.f08 -O0 (internal compiler error) > FAIL: gfortran.dg/submodule_11.f08 -O0 (test for excess errors) > FAIL: gfortran.dg/submodule_11.f08 -O1 (internal compiler error) > FAIL: gfortran.dg/submodule_11.f08 -O1 (test for excess errors) > FAIL: gfortran.dg/submodule_11.f08 -O2 (internal compiler error) > FAIL: gfortran.dg/submodule_11.f08 -O2 (test for excess errors) > FAIL: gfortran.dg/submodule_11.f08 -O3 -fomit-frame-pointer -funroll-loops -fpeel-loops -ftracer -finline-functions (internal compiler error) > FAIL: gfortran.dg/submodule_11.f08 -O3 -fomit-frame-pointer -funroll-loops -fpeel-loops -ftracer -finline-functions (test for excess errors) > FAIL: gfortran.dg/submodule_11.f08 -O3 -g (internal compiler error) > FAIL: gfortran.dg/submodule_11.f08 -O3 -g (test for excess errors) > FAIL: gfortran.dg/submodule_11.f08 -Os (internal compiler error) > FAIL: gfortran.dg/submodule_11.f08 -Os (test for excess errors) Well, if I change the order of the conditionals decl.c:4831, I can get rid of the above FAILs. Index: decl.c =================================================================== --- decl.c (revision 231219) +++ decl.c (working copy) @@ -4826,7 +4826,7 @@ ok: /* Abbreviated module procedure declaration is not meant to have any formal arguments! */ - if (!sym->abr_modproc_decl && formal && !head) + if (formal && !head && sym && !sym->abr_modproc_decl) arg_count_mismatch = true; for (p = formal, q = head; p && q; p = p->next, q = q->next)