From patchwork Wed Dec 2 17:00:21 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kirill Yukhin X-Patchwork-Id: 551483 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id D7F9A14032C for ; Thu, 3 Dec 2015 04:00:59 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b=vt3XfXxM; dkim-atps=neutral DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; q=dns; s=default; b=BWXLDMzFkSDrHUoeZ oS+NY+OML/SMTxnN0niUhHfMr15CI8eP/ONVE2yAcLRKXG2DiooFem91IVG8PZTC eVfLTm0CcvzEtPxnHZAXuUjGQqTAjYFu5NgLVIJ+3EfdSBYfclU1GEsbykMh3nNf gHNt0wKRiJ9xrS4a8qqZwEaoXo= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=default; bh=l01iuBnBTuVNPZSCuvtqeFk immc=; b=vt3XfXxMUUjANYNC1Rpdh2LkzVd9taQzdtn9mDyuE3U005kDIbdCQS5 hm6gZtCrSMV1zJ19dJJ8zWnVVSHmbQ9Wv4EFoUpjUHMk/9tfM6wsUK8vJ+IWZwqP vbkwLP1+fQ62J+WYWWbMQzIo5qkgfccFqQVaXqiilIhHJJPdRoro= Received: (qmail 79891 invoked by alias); 2 Dec 2015 17:00:50 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 79875 invoked by uid 89); 2 Dec 2015 17:00:49 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL, BAYES_00, FREEMAIL_FROM, RCVD_IN_DNSWL_LOW, SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-wm0-f54.google.com Received: from mail-wm0-f54.google.com (HELO mail-wm0-f54.google.com) (74.125.82.54) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Wed, 02 Dec 2015 17:00:48 +0000 Received: by wmec201 with SMTP id c201so263113921wme.0 for ; Wed, 02 Dec 2015 09:00:45 -0800 (PST) X-Received: by 10.28.170.133 with SMTP id t127mr6838989wme.65.1449075645451; Wed, 02 Dec 2015 09:00:45 -0800 (PST) Received: from msticlxl57.ims.intel.com (irdmzpr01-ext.ir.intel.com. [192.198.151.36]) by smtp.gmail.com with ESMTPSA id v196sm4035780wmv.10.2015.12.02.09.00.43 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 02 Dec 2015 09:00:44 -0800 (PST) Date: Wed, 2 Dec 2015 20:00:21 +0300 From: Kirill Yukhin To: GCC Patches Cc: Uros Bizjak Subject: Re: [PATCH, i386, AVX-512] Split out mask version for vec_extract_hi_. Message-ID: <20151202170019.GB39390@msticlxl57.ims.intel.com> References: <20151130104601.GA24154@msticlxl57.ims.intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20151130104601.GA24154@msticlxl57.ims.intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-IsSubscribed: yes Hello, On 30 Nov 13:46, Kirill Yukhin wrote: > Hello, > Patch in the bottom splits masked version of vec_extract_hi_ > to block AVX-1512VL insn generation for KNL and cures ICE on spec2k6/450.soplex. > > Bootstrapped and regtesed. > > If no objections - I'll commit on Wednesday. > > gcc/ > * config/i386/sse.md (define_insn "vec_extract_hi__maskm"): > Remove "prefix_extra". > (define_insn "vec_extract_hi__mask"): New. > (define_insn "vec_extract_hi_"): Remove masking. > gcc/testsuite/ > * gcc.target/i386/avx512vl-vextractf32x4-1.c: Fix scan pattern. > It looks like I forgot to fix i32x4 test as well. Patch in the bottom fixes it (and a regression on 32b). If no objections - I'll check it into main trunk tomorrow. gcc/testsuite/ * gcc.target/i386/avx512vl-vextracti32x4-1.c: Fix scan pattern. --- Thanks, K diff --git a/gcc/testsuite/gcc.target/i386/avx512vl-vextracti32x4-1.c b/gcc/testsuite/gcc.target/i386/avx512vl-vextracti32x4-1.c index 7ee87dd..0826a0b 100644 --- a/gcc/testsuite/gcc.target/i386/avx512vl-vextracti32x4-1.c +++ b/gcc/testsuite/gcc.target/i386/avx512vl-vextracti32x4-1.c @@ -1,6 +1,6 @@ /* { dg-do compile } */ /* { dg-options "-mavx512vl -O2" } */ -/* { dg-final { scan-assembler-times "vextracti32x4\[ \\t\]+\[^\{\n\]*%xmm\[0-9\]+(?:\n|\[ \\t\]+#)" 1 } } */ +/* { dg-final { scan-assembler-times "vextracti\(?:128|32x4\)\[ \\t\]+\[^\{\n\]*%xmm\[0-9\]+(?:\n|\[ \\t\]+#)" 1 } } */ /* { dg-final { scan-assembler-times "vextracti32x4\[ \\t\]+\[^\{\n\]*%xmm\[0-9\]+\{%k\[1-7\]\}(?:\n|\[ \\t\]+#)" 1 } } */ /* { dg-final { scan-assembler-times "vextracti32x4\[ \\t\]+\[^\{\n\]*%xmm\[0-9\]+\{%k\[1-7\]\}\{z\}(?:\n|\[ \\t\]+#)" 1 } } */