From patchwork Mon Apr 27 08:31:26 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Hubicka X-Patchwork-Id: 464895 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id A307F1402B6 for ; Mon, 27 Apr 2015 18:31:41 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=pass reason="1024-bit key; unprotected key" header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b=COR1fBC9; dkim-adsp=none (unprotected policy); dkim-atps=neutral DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:subject:message-id:mime-version:content-type; q=dns; s= default; b=f6vyu7sPKSYVvWXufg5Yh6jBFggQ4VfTRr9XIXMxIRVJoWnVBLnMP E/p7+EYST24yO1UJjuioaKyn3BLd6UT4suzlcVyqflku2aZC4sVeL5swxgYsKHep CmwZ4oeXvqCa4jr/Xnuad15WLU0ROSHA9NMxTGLELvoLo1wNmLJfSo= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:subject:message-id:mime-version:content-type; s= default; bh=f5+/Yvi+VC04fM/RUHPIa83ddyw=; b=COR1fBC9dxAh2EWOb/NQ uzwVOJTHa8J3sPZ1I0CdzIlfkNVjaWUHmJQ346Rb+N2dKoHyCq4Lq52PX9uZQZXb c32nYmB6K9aJ5pegd/1Q7VndL0UOTjQHcNFlZNknx2BCw01XPModfqkUOd5s331b V5CaKhLHKsA9KwDmLNHmOYY= Received: (qmail 13296 invoked by alias); 27 Apr 2015 08:31:33 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 13283 invoked by uid 89); 27 Apr 2015 08:31:33 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL, BAYES_00, KAM_LAZY_DOMAIN_SECURITY, T_RP_MATCHES_RCVD autolearn=no version=3.3.2 X-HELO: nikam.ms.mff.cuni.cz Received: from nikam.ms.mff.cuni.cz (HELO nikam.ms.mff.cuni.cz) (195.113.20.16) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Mon, 27 Apr 2015 08:31:31 +0000 Received: by nikam.ms.mff.cuni.cz (Postfix, from userid 16202) id B0B955447C0; Mon, 27 Apr 2015 10:31:26 +0200 (CEST) Date: Mon, 27 Apr 2015 10:31:26 +0200 From: Jan Hubicka To: gcc-patches@gcc.gnu.org, rguenther@suse.de Subject: Fix librayr name of __builtin_allocal_with_align Message-ID: <20150427083126.GB46857@kam.mff.cuni.cz> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.21 (2010-09-15) Hi, build_common_builtin_nodes declares both __builtin_alloca and __builtin_alloca_with_align to have library name "alloca". This actually triggers warning in an updated ODR violation detector on "alloca" being declared twice. __builtin_alloca_with_align IMO do not have library equivalent and I think this is a pasto (__builtin_alloca_with_align is not documented in extend.texi). It is not clear to me if there was some intention behind this oddity though. I have bootstrapped/regtested x86_64 with the following. OK? Honza * tree.c (build_common_builtin_nodes): Do not build __builtin_alloca_with_align as equivalent of library alloca. Index: tree.c =================================================================== --- tree.c (revision 222391) +++ tree.c (working copy) @@ -10088,7 +10098,8 @@ build_common_builtin_nodes (void) ftype = build_function_type_list (ptr_type_node, size_type_node, size_type_node, NULL_TREE); local_define_builtin ("__builtin_alloca_with_align", ftype, - BUILT_IN_ALLOCA_WITH_ALIGN, "alloca", + BUILT_IN_ALLOCA_WITH_ALIGN, + "__builtin_alloca_with_align", ECF_MALLOC | ECF_NOTHROW | ECF_LEAF); /* If we're checking the stack, `alloca' can throw. */