| Message ID | 20150220144330.GB1746@tucnak.redhat.com |
|---|---|
| State | New |
| Headers | show |
On 02/20/15 07:43, Jakub Jelinek wrote: > Hi! > > As written in the PR, this testcase is supposed to be blacklisted on > (lp64) powerpc*-*-linux* unless powerpc_elfv2 and also on nvptx, > but apparently neither of those blacklistings really work. > tcl or dejagnu or the target expression parser are unhappy about the > missing {}s, it doesn't like cond1 && cond2 && cond3 but wants > { { cond1 && cond2 } && cond3 } instead (fixes the powerpc* blacklisting) > and was missing another pair of {}s around the whole thing (that should fix > nvptx). > > Regtested on x86_64-linux and i686-linux, additionally tested with > replacing the various targets in the expression with x86_64-*-* instead > and checking the test became UNSUPPORTED as it should. Ok for trunk? > > 2015-02-20 Jakub Jelinek <jakub@redhat.com> > > PR testsuite/64158 > * gcc.dg/pr44194-1.c: Add two extra {} pairs to fix up powerpc*-*-linux* > and nvptx-*-* blacklisting. Got to love the unholy trinity of dejagnu, expect & tcl... OK. jeff
--- gcc/testsuite/gcc.dg/pr44194-1.c.jj 2014-11-11 00:06:05.000000000 +0100 +++ gcc/testsuite/gcc.dg/pr44194-1.c 2015-02-20 12:45:55.419301827 +0100 @@ -1,4 +1,4 @@ -/* { dg-do compile { target { { { { { { { { i?86-*-* x86_64-*-* } && x32 } || lp64 } && { ! s390*-*-* } } && { ! hppa*64*-*-* } } && { ! alpha*-*-* } } && { { ! powerpc*-*-linux* } || powerpc_elfv2 } && { ! nvptx-*-* } } } } } */ +/* { dg-do compile { target { { { { { { { { { { i?86-*-* x86_64-*-* } && x32 } || lp64 } && { ! s390*-*-* } } && { ! hppa*64*-*-* } } && { ! alpha*-*-* } } && { { ! powerpc*-*-linux* } || powerpc_elfv2 } } && { ! nvptx-*-* } } } } } } */ /* { dg-options "-O2 -fdump-rtl-dse1 -fdump-rtl-final" } */ /* Restrict to 64-bit targets since 32-bit targets usually return small
Hi! As written in the PR, this testcase is supposed to be blacklisted on (lp64) powerpc*-*-linux* unless powerpc_elfv2 and also on nvptx, but apparently neither of those blacklistings really work. tcl or dejagnu or the target expression parser are unhappy about the missing {}s, it doesn't like cond1 && cond2 && cond3 but wants { { cond1 && cond2 } && cond3 } instead (fixes the powerpc* blacklisting) and was missing another pair of {}s around the whole thing (that should fix nvptx). Regtested on x86_64-linux and i686-linux, additionally tested with replacing the various targets in the expression with x86_64-*-* instead and checking the test became UNSUPPORTED as it should. Ok for trunk? 2015-02-20 Jakub Jelinek <jakub@redhat.com> PR testsuite/64158 * gcc.dg/pr44194-1.c: Add two extra {} pairs to fix up powerpc*-*-linux* and nvptx-*-* blacklisting. Jakub