From patchwork Thu Jan 22 20:44:47 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jakub Jelinek X-Patchwork-Id: 431997 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 7D66C14017D for ; Fri, 23 Jan 2015 07:45:04 +1100 (AEDT) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:cc:subject:message-id:reply-to:references:mime-version :content-type:in-reply-to; q=dns; s=default; b=qdWjfMR3NxZBNMWBe 4RAf6SMk89eKgNY6OobPQhW9Bn6EQjdAhV1iqWVt+TpcdDtnQlCaNfmvrsRfZmt7 3v+SWvpUMklg+v2gQ7qEWuNEbxB0A2HZZwgVRwsE8d6vPXSFGm3XkiXa9KVOr+aS 3bMR9mMLiAoKIsQBQ8fj6YuIys= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:cc:subject:message-id:reply-to:references:mime-version :content-type:in-reply-to; s=default; bh=IzV9++tZ05IL3N+b5iXExPR FXbc=; b=T5IM73/ROJRQRJz9dMDTT+PJ7TBUM3AWi098PqGotpvGcfhw8XzNOss 3ScEReKRY31m274XU2/7GFc5YkuVzPFx8rT9sChXTIdQkA95/rzEryX545xt1Z3R Aq4wFlW5roeCeA12cQfweD1bzFl3tO41MSbXN/eULulIys23VoIs= Received: (qmail 20871 invoked by alias); 22 Jan 2015 20:44:57 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 20859 invoked by uid 89); 22 Jan 2015 20:44:56 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL, BAYES_00, SPF_HELO_PASS, SPF_PASS, T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 22 Jan 2015 20:44:54 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t0MKip6t015759 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 22 Jan 2015 15:44:52 -0500 Received: from tucnak.zalov.cz (ovpn-116-98.ams2.redhat.com [10.36.116.98]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t0MKin09007299 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=NO); Thu, 22 Jan 2015 15:44:51 -0500 Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.14.9/8.14.9) with ESMTP id t0MKim2L013337; Thu, 22 Jan 2015 21:44:48 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.14.9/8.14.9/Submit) id t0MKil1J013336; Thu, 22 Jan 2015 21:44:47 +0100 Date: Thu, 22 Jan 2015 21:44:47 +0100 From: Jakub Jelinek To: Dmitry Vyukov Cc: Kostya Serebryany , Venkataramanan Kumar , "gcc-patches@gcc.gnu.org" , Christophe Lyon Subject: Re: [PING]: [PATCH]: Conditionally include target specific files while building TSAN Message-ID: <20150122204447.GN1746@tucnak.redhat.com> Reply-To: Jakub Jelinek References: <20150122140336.GA1746@tucnak.redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) X-IsSubscribed: yes On Thu, Jan 22, 2015 at 06:16:53PM +0400, Dmitry Vyukov wrote: > On Thu, Jan 22, 2015 at 5:03 PM, Jakub Jelinek wrote: > > On Thu, Jan 22, 2015 at 07:30:50PM +0530, Venkataramanan Kumar wrote: > >> ping. > >> > >> Forgot to mention, GCC bootstraps and regression testing passed on x86_64. > > > > Well, without a change from upstream to guard the HACKY_CALL and actual tsan > > port to non-x86_64 this patch doesn't solve anything. > > > I've just committed that change upstream: > http://llvm.org/viewvc/llvm-project?view=revision&revision=226829 > Now we need to summon +Kostya to update gcc version of runtime. Here is what I've committed: 2015-01-22 Jakub Jelinek * tsan/tsan_rtl.h: Cherry pick upstream r226829. Jakub --- libsanitizer/tsan/tsan_rtl.h (revision 226828) +++ libsanitizer/tsan/tsan_rtl.h (revision 226829) @@ -679,7 +679,7 @@ void AcquireReleaseImpl(ThreadState *thr // The trick is that the call preserves all registers and the compiler // does not treat it as a call. // If it does not work for you, use normal call. -#if TSAN_DEBUG == 0 +#if TSAN_DEBUG == 0 && defined(__x86_64__) // The caller may not create the stack frame for itself at all, // so we create a reserve stack frame for it (1024b must be enough). #define HACKY_CALL(f) \